main Koha release repository branch master updated. v18.11.00-430-g89ae6cc

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

main Koha release repository branch master updated. v18.11.00-430-g89ae6cc

Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  89ae6cc3bfea81dea8d6995965a44b92c34764aa (commit)
       via  cfea47cb064362bbb1fc93769be4b7df3a8e2fae (commit)
       via  7a58d0215907c05b0b82944141f6f4d4595c3979 (commit)
       via  f3f5b98fd909f9e13aa4e45a16dc275ef4ee8489 (commit)
       via  5b160af2a051dc3693f04dabf320d0995cf26160 (commit)
       via  04e121a741a442f5b557e11864eb69be9d0c3ded (commit)
       via  558742577d3902cd5e2abf5c3f165c6425e163da (commit)
       via  dc6be66e2b2ec5917d7bec020d4e94c40baa9f6c (commit)
       via  a628dab3b60d64e383ef2ffa20e5ea1c80f9b9d9 (commit)
       via  3c2cc8da26f7a907c0b51f928ffb100eefbfa692 (commit)
       via  0e220869f5a3327eee8f9426d648fbcaaa0fd7fa (commit)
       via  0939d44c22cda569faf4c0c60fd67de04097b34d (commit)
       via  3cfc8ae24c99647fcf5f55ce0e6c6521a3f3ff83 (commit)
       via  5bb04247477dce80fbacf9993be3164518c03df6 (commit)
       via  c0e6051ac5bd0190a6491ecc853614a156014d88 (commit)
       via  74b6a659e5ec831e99beaad2f9ce6dad6409a3a0 (commit)
       via  713f873626404e7904bebd0b97dee1d9f67745fc (commit)
       via  6ec979057b2b4f10fe469d2655fa0fcb47af1cb7 (commit)
       via  ae258098d9cfbc6d6ea211f8bcbb6c50c15b0ecd (commit)
       via  0844f2c174c83ce3da11be07511730b0c220e5ad (commit)
       via  619d97b91d075bd7d48c95102029a8d89269be6f (commit)
       via  ea36265697c85cfb1f7de0b2344ef8647dc31387 (commit)
       via  556877ccd518dd32fb3604c39ecd5c6fcd0811fe (commit)
       via  102b1ca4bf3b1721f496417473643ff951c13833 (commit)
       via  870191d40611e3e7414388d4dd911446a2059225 (commit)
       via  c7f47ea36a8992356c6c055a22891ea168cbdc9c (commit)
      from  df611b17d12b63bb2f14909969ff8e8f67a332d0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 89ae6cc3bfea81dea8d6995965a44b92c34764aa
Author: Katrin Fischer <[hidden email]>
Date:   Sat Jan 5 06:45:05 2019 +0000

    Bug 22116: Add price formatting to rental charge and replacement price on items tab in staff
   
    Adds formatting to replacement price and rental charge on items
    tab.
   
    To test:
    - Add a rental charge to one or more of your item types
    - Edit a record with some items, add replacement cost to some
    - Find or create a record with your rental charged itemtype (MARC21:942$c)
    - Go to the staff detail page of those records
    - Check "Items" tab for
      - Rental charge on top
      - Replacement price for items
    - Verify information is displayed correctly when toggling CurrencyFormat
      system preference
   
    Signed-off-by: Jack Kelliher <[hidden email]>
    Signed-off-by: Martin Renvoize <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit cfea47cb064362bbb1fc93769be4b7df3a8e2fae
Author: Katrin Fischer <[hidden email]>
Date:   Tue Feb 5 00:42:34 2019 +0100

    Bug 21441: Fix wrong reference to a 'holds' table on system information tab
   
    It looks like a typo snuck in on the about page, listing a holds
    table instead of reserves.
   
    To test:
    - Manually create the same PK (reserve_id) in reserves and old_reserves
    - Verify that the message on about > system information now
      correctly lists those tables (not holds and old_reserves)
   
    Signed-off-by: Owen Leonard <[hidden email]>
    Signed-off-by: Martin Renvoize <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit 7a58d0215907c05b0b82944141f6f4d4595c3979
Author: Jasmine Amohia <[hidden email]>
Date:   Wed Jan 16 01:37:22 2019 +0000

    Bug 21840: Fixed some typos in the templates
   
    intranet-tmpl/prog/en/modules/ill/ill-requests.tt:13
    Bibliograpic record ID --> Bibliographic record ID
   
    intranet-tmpl/prog/en/modules/acqui/basket.tt:547
    Can't cancel order, ([% books_loo.holds_on_order | html %]) holds are linked with this order cancel holds first -->  ... with this order. Cancel holds first
   
    intranet-tmpl/prog/en/modules/acqui/parcel.tt
    Can't cancel order, ([% loop_order.holds_on_order | html %]) holds are linked with this order cancel holds first --> ... with this order. Cancel holds first
   
    intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt:32
    Print this slabel --> Print this label
   
    Test plan:
    1. Check that the fixes in the patch are correct
   
    Signed-off-by: Katrin Fischer <[hidden email]>
    Signed-off-by: Martin Renvoize <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit f3f5b98fd909f9e13aa4e45a16dc275ef4ee8489
Author: Kyle M Hall <[hidden email]>
Date:   Mon Feb 11 07:15:11 2019 -0500

    Bug 21829: (QA follow-up) - Update the number of unit tests
   
    Signed-off-by: Kyle M Hall <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit 5b160af2a051dc3693f04dabf320d0995cf26160
Author: Jonathan Druart <[hidden email]>
Date:   Wed Nov 14 09:38:01 2018 -0300

    Bug 21829: Correctly format dateexpiry in notices (date only)
   
    dateexpiry is a date, we should not display the time
    part in notice.
   
    Test plan:
    Create a notice with borrowers.dateexpiry, generate this notice.
    The value should be displayed without the time part
   
    Signed-off-by: Kyle M Hall <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit 04e121a741a442f5b557e11864eb69be9d0c3ded
Author: Jonathan Druart <[hidden email]>
Date:   Wed Nov 14 09:37:58 2018 -0300

    Bug 21829: Add tests for dateexpiry format in notices
   
    Signed-off-by: Kyle M Hall <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit 558742577d3902cd5e2abf5c3f165c6425e163da
Author: Katrin Fischer <[hidden email]>
Date:   Thu Dec 20 23:37:02 2018 +0000

    Bug 22009: Fix error messages for filing rules and splitting rules.
   
    Some error messages were doubled up with different error codes.
   
    To test:
    I am not sure how to trigger those from the GUI, might
    require a code review/code changes.
   
    Signed-off-by: Jonathan Druart <[hidden email]>
    Signed-off-by: Martin Renvoize <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit dc6be66e2b2ec5917d7bec020d4e94c40baa9f6c
Author: Katrin Fischer <[hidden email]>
Date:   Sun Jan 13 10:06:22 2019 +0100

    Bug 22119: Add price formatting in more places in circulation
   
    This adds some missing Price filters to some places in circulation.
    To check verify the amount are displayed according to setting
    of CurrencyFormat (use FR or CH for seeing a change)
   
    Use a patron account with no pending fines at the beginning
    for all tests.
   
    1)
    - Switch RentalFeesCheckoutConfirmation to "Ask"
    - Check out an item with a rental charge
    - Verify message is formatted correctly:
      Rental charge for this item: ...
   
    2)
    - Switch RentalsInNoissuesCharge to "Don't include"
    - Make sure patron has only Rental fines on their account
    - Check out another item
    - Verify message is formatted correctly:
      The patron has unpaid charges for holds, rentals etc ...
   
    3)
    - Switch BatchCheckouts to "Allow"
    - Add the patron category of your test patron to BatchCheckoutsValidCategories
    - Checkout any item
    - Verify the message in the information column is formatted correctly:
      The patron has unpaid charges for holds, rentals etc of ...
   
    Signed-off-by: Jasmine Amohia <[hidden email]>
    Signed-off-by: Martin Renvoize <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit a628dab3b60d64e383ef2ffa20e5ea1c80f9b9d9
Author: Katrin Fischer <[hidden email]>
Date:   Sat Jan 5 17:39:42 2019 +0000

    Bug 22121: Display 'Price paid' on ILL requests according to CurrencyFormat pref
   
    To test:
    - Install BLDSS backend
      see: https://wiki.koha-community.org/wiki/ILL_backends
    - Add a new BLDSS ILL request
    - Edit ILL request
    - Fill in Price paid field
    - Verify Price paid is formatted correctly on 'Manage ILL request'
      page
   
    Signed-off-by: Ethan Amohia <[hidden email]>
    Signed-off-by: Martin Renvoize <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit 3c2cc8da26f7a907c0b51f928ffb100eefbfa692
Author: Katrin Fischer <[hidden email]>
Date:   Sun Jan 13 11:15:27 2019 +0100

    Bug 22120: Add price formattig to patron summary print
   
    The patron summary print lists the replacement prices
    and rental charges of items and totals them. With this
    patch they will be formatted according to the
    CurrencyFormat system preference.
   
    To test:
    - Find or create a patron with some checkouts
    - Make sure some items have replacement price set
      and some have a rental charge
    - "Print summary" from the account in staff
    - Verify that charges and prices in the checkouts
      table are formatted correctly
    - Toggle CurrencyFormat to different settings
   
    Signed-off-by: helene hickey <[hidden email]>
    Signed-off-by: Martin Renvoize <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit 0e220869f5a3327eee8f9426d648fbcaaa0fd7fa
Author: Katrin Fischer <[hidden email]>
Date:   Mon Jan 14 05:41:48 2019 +0000

    Bug 17347: Ignore whitespace before and after on renewing
   
    When an item is checked out, Koha ignores whitespace
    at the beginning and the end of the entered barcode.
    This makes life easier, if a barcode is C&P from another
    page. This patch makes the renewal page behave the same.
   
    To test:
    - Checkout an item
    - Renew the item from the renew tab or renewal page
      entering the barcode with leading and trailing
      whitespace
    - "Barcode not found"
    - Apply patch
    - Try again
    - Barcode should be found now
   
    Signed-off-by: Owen Leonard <[hidden email]>
    Signed-off-by: Devinim <[hidden email]>
    Signed-off-by: Martin Renvoize <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit 0939d44c22cda569faf4c0c60fd67de04097b34d
Author: Pasi Kallinen <[hidden email]>
Date:   Tue Nov 27 11:53:32 2018 +0200

    Bug 21885: Calendar to-date starts before end-date
   
    When adding new holidays to the calendar, you pick the start date,
    and then the end date, but the end date calendar will start from
    current date, not from the picked start date. Sometimes this means
    many extra clicks to pick an end date.
   
    Make the end date calendar start from the beginning date by default.
   
    Test plan:
   
    1) Go to the tools -> calendar
    2) Pick a start date somewhere in the future, and then open the
       end date calendar. Notice how it starts before the start date
       of the date range.
    3) Apply patch.
    4) Pick a start date in the future. The end date calendar should
       automatically default to the same date.
    5) Change the start date a day backwards, note how the end date
       does not change.
    6) Change the start date after the end date, note how the end date
       adjusts, so it is not in the past.
   
    Signed-off-by: Pasi Kallinen <[hidden email]>
   
    Signed-off-by: Owen Leonard <[hidden email]>
   
    Signed-off-by: Katrin Fischer <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit 3cfc8ae24c99647fcf5f55ce0e6c6521a3f3ff83
Author: Tomas Cohen Arazi <[hidden email]>
Date:   Wed Jan 30 15:31:43 2019 -0300

    Bug 22238: Remove koha-*-sip scripts in favor of koha-sip
   
    This patch removes traces from the (deprecated) koha-*-sip scripts.
   
    To test:
    - Apply the patch
    - Verify no traces of koha-*-sip remain on the codebase (besides
      Release Notes, koha-common.links and the koha-sip script):
      $ cd kohaclone
      $ git grep koha-start-sip
      $ git grep koha-stop-sip
      $ git grep koha-enable-sip
    => SUCCESS: No traces!
    - Create the following symlinks:
      $ sudo ln -s /usr/sbin/koha-sip  /usr/sbin/koha-start-sip
      $ sudo ln -s /usr/sbin/koha-sip  /usr/sbin/koha-stop-sip
      $ sudo ln -s /usr/sbin/koha-sip  /usr/sbin/koha-enable-sip
    - Try the koha-*-zebra commands:
      $ sudo koha-stop-sip kohadev
      $ sudo koha-start-sip kohadev
      $ sudo koha-restart-sip kohadev
    => SUCCESS: They all work as expected!
   
    - Sign off :-D!
   
    Signed-off-by: Kyle M Hall <[hidden email]>
    Signed-off-by: Martin Renvoize <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit 5bb04247477dce80fbacf9993be3164518c03df6
Author: Tomas Cohen Arazi <[hidden email]>
Date:   Wed Jan 30 09:44:21 2019 -0300

    Bug 22235: (follow-up) Make koha-remove stop SIP server if required
   
    Signed-off-by: Kyle M Hall <[hidden email]>
    Signed-off-by: Martin Renvoize <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit c0e6051ac5bd0190a6491ecc853614a156014d88
Author: Tomas Cohen Arazi <[hidden email]>
Date:   Wed Jan 30 09:37:47 2019 -0300

    Bug 22235: Make maintenance scripts use koha-sip instead of koha-*-sip
   
    This patch makes all maintenance scripts use **koha-sip** instead of
    the old **koha-*-sip** scripts.
   
    To test:
    - Run:
      $ perl misc4dev/cp_debian_files.pl
      $ sudo service koha-common stop
    => SUCCESS: No errors and the SIP-related sevices are stopped
      $ sudo service koha-common start
    => SUCCESS: No errors and the SIP-related services are started
      $ sudo service koha-common restart
    => SUCCESS: No erros and SIP-related services are running
      $ sudo koha-create --create-db test
      $ sudo koha-sip --enable test
      $ sudo koha-sip --start test
      $ sudo koha-disable test
    => SUCCESS: No errors, instance disabled, no SIP running for test
    - Sign off :-D
   
    Signed-off-by: Kyle M Hall <[hidden email]>
    Signed-off-by: Martin Renvoize <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit 74b6a659e5ec831e99beaad2f9ce6dad6409a3a0
Author: Tomas Cohen Arazi <[hidden email]>
Date:   Wed Jan 30 09:12:36 2019 -0300

    Bug 18562: Tab completion in bash
   
    This patch adds the fancy tab completion in bash.
   
    To test:
    - Run:
      $ source debian/koha-common.bash-completion
      $ sudo koha-sip <tab>
    - Play with all the options
    => SUCCESS: The combinations make sense (e.g. only SIP-enabled instances
      are completed for --start, --stop, --restart, -v and --verbose are not
      offered if the other one is already in there, --enable only applies to
      SIP-disabled instances, etc).
    - Sign off :-D
   
    Signed-off-by: Kyle M Hall <[hidden email]>
    Signed-off-by: Martin Renvoize <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit 713f873626404e7904bebd0b97dee1d9f67745fc
Author: Tomas Cohen Arazi <[hidden email]>
Date:   Wed Jan 30 09:12:25 2019 -0300

    Bug 18562: Add manpage for koha-sip
   
    This patch adds the manpage for koha-sip.
   
    To test:
    - Apply this patch
    - Run:
      $ kshell
     k$ prove xt/verify-debian-docbook.t
    => SUCCESS: Tests pass!
    - Run:
      $ misc4dev/cp_debian_files.pl
      $ man koha-sip
    => SUCCESS: The man page shows correctly.
    - Sign off :-D
   
    Signed-off-by: Kyle M Hall <[hidden email]>
    Signed-off-by: Martin Renvoize <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit 6ec979057b2b4f10fe469d2655fa0fcb47af1cb7
Author: Tomas Cohen Arazi <[hidden email]>
Date:   Wed Jan 30 08:42:53 2019 -0300

    Bug 18562: Add koha-sip maintenance script
   
    This patch introduces a single script to handle all actions on SIP
    servers for Koha instances. It is intended to be a replacement for:
   
    - koha-start-sip
    - koha-stop-sip
    - koha-enable-sip
   
    It adds a function called is_sip_running to koha-functions.sh.
   
    To test:
    - Apply this patch
    - Run:
      $ misc4dev/cp_debian_files.pl
      $ sudo koha-sip --enable kohadev
      $ sudo koha-sip --start kohadev
      $ sudo koha-sip --status kohadev
    => SUCCESS: The SIP server is running for kohadev
    - Run:
      $ sudo koha-sip --restart --verbose kohadev
      $ sudo koha-sip --status kohadev
    => SUCCESS: The SIP server is running for kohadev
    - Run:
      $ sudo koha-sip --stop kohadev
      $ sudo koha-sip --status kohadev
    => SUCCESS: The SIP server is not running for kohadev
    - Play with other combinations like enabling an already enabled
    instance, etc. Remember you need to remove the
    /etc/koha/sites/kohadev/SIPconfig.xml file so it is considered disabled.
    - Sign off :-D
   
    Signed-off-by: Kyle M Hall <[hidden email]>
    Signed-off-by: Martin Renvoize <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit ae258098d9cfbc6d6ea211f8bcbb6c50c15b0ecd
Author: Owen Leonard <[hidden email]>
Date:   Fri Feb 8 12:52:48 2019 +0000

    Bug 22293: Sticky toolbar making vendor form uneditable
   
    The new floating toolbar plugin doesn't like a particular combination of
    markup: A toolbar inside a form which is styled "display:inline." The
    staff client CSS styles forms that way globally, so it must be
    explicitly overridden in these situations.
   
    Changing the default will have broad consequences, so I propose an
    inline style to fix this.
   
    To test, apply the patch and go to Acquisitions. Add or edit a vendor
    and confirm that after scrolling down the page the form is still
    editable.
   
    Signed-off-by: Andrew Isherwood <[hidden email]>
    Signed-off-by: Mikaël Olangcay Brisebois <[hidden email]>
   
    Signed-off-by: Katrin Fischer <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit 0844f2c174c83ce3da11be07511730b0c220e5ad
Author: Liz Rea <[hidden email]>
Date:   Thu Jan 31 22:41:29 2019 +0000

    Bug 22282: Fix PDF issue when exporting PDF in French format.
   
    Fixing up QA comments, keeping 1st instance and removing the 2nd.
    Original test plan by Christophe Croullebois.
   
    To test :
    Without the patch :
   
    1° select in Acquisitions preferences/OrderPdfFormat French 3-page
    2° restart plack if needed
    3° In acqui/basketgroup.pl select closed tab
    4° Click on "Export as PDF" button
    5° You should see a blank page saying "Internal Server Error"
   
    With the patch :
   
    Do the same
   
    Signed-off-by: Maryse Simard <[hidden email]>
   
    Signed-off-by: Katrin Fischer <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit 619d97b91d075bd7d48c95102029a8d89269be6f
Author: Katrin Fischer <[hidden email]>
Date:   Mon Jan 14 12:47:25 2019 +0000

    Bug 22110: Fix editing of adjustments for CurrencyFormat != US
   
    When using CurrencyFormat FR or CH the editing an amount behave
    badly. Example: changing displayed 1,00 to 1,11 would save as 1,00.
   
    At the moment Koha only understands decimal dot, not comma.
    So every time data is entered, we use decimal dot.
   
    1) Add an adjustment to an invoice
    2) Change system preference CurrencyFormat to FR or CH
    3) Verify the amount displays with a decimal comma
    4) Try changing the amount to something like 1,11
    5) Save the amount
    6) Verify it shows 1.00
    7) Apply patch
    8) Refresh the invoice page if necessary
    9) Verify amount is now shown as 1.00
    10) Repeat test, use 1.11
    11) Verify it will be stored correctly.
   
    Signed-off-by: Mackey Johnstone <[hidden email]>
    Signed-off-by: mikael <[hidden email]>
    Signed-off-by: Martin Renvoize <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit ea36265697c85cfb1f7de0b2344ef8647dc31387
Author: Nick Clemens <[hidden email]>
Date:   Wed Feb 6 12:49:58 2019 +0000

    Bug 22278: Clear cache when creating new report groups or subgroups
   
    When a user adds a new group we create it, then fetch the groups from the cache. However, we aren't clearing the cache on creation. This patch fixes that
   
    To test:
     0) Start a new report
     1) Pick create for the group
     2) Enter code and value
     3) Save
     4) You remain on the page and value and code are now empty (ok)
     5) BUT: The pull down for the group remains "None" instead of reflecting
        the new group
     6) Open a new tab and browse to reports - note the group exists and the report is in it
     7) On original tab save report again, the group was not selected so is lost
     8) Apply patch
     9) Retest with a new report
    10) Group is created, saved, and selected upon save
    11) Subsequent edits include the new group
    12) Test with subgroups as well
   
    Signed-off-by: Liz Rea <[hidden email]>
   
    Signed-off-by: Katrin Fischer <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit 556877ccd518dd32fb3604c39ecd5c6fcd0811fe
Author: Alex Arnaud <[hidden email]>
Date:   Thu Feb 7 17:22:17 2019 +0100

    Bug 21738: unit tests for HoldTitle
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit 102b1ca4bf3b1721f496417473643ff951c13833
Author: Alex Arnaud <[hidden email]>
Date:   Fri Jan 4 16:33:39 2019 +0100

    Bug 21738: make call of CanBookBeReserved more safe
   
    Signed-off-by: Kyle M Hall <[hidden email]>
   
    Signed-off-by: Katrin Fischer <[hidden email]>
   
    Signed-off-by: Katrin Fischer <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit 870191d40611e3e7414388d4dd911446a2059225
Author: Alex Arnaud <[hidden email]>
Date:   Tue Nov 13 09:44:51 2018 +0100

    Bug 21738: check items count in C4:ILSDI::HoldTitle
   
    Test plan:
      - Try holding a title without items via ILS-DI
        (cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1&bib_id=1),
      - you get an error,
      - apply this patch,
      - try again,
      - you should get the code "Notitems"Bug 21738: check items count in
        C4:ILSDI::HoldTitle
   
    Signed-off-by: Kyle M Hall <[hidden email]>
   
    Signed-off-by: Katrin Fischer <[hidden email]>
   
    Signed-off-by: Katrin Fischer <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

commit c7f47ea36a8992356c6c055a22891ea168cbdc9c
Author: Jose-Mario Monteiro-Santos <[hidden email]>
Date:   Thu Jan 17 16:41:58 2019 -0500

    Bug 18723: Change dot into comma
   
    This fixes the regression that multiplies the amount entered by 100
    when CurrencyFormat is set to FR. It replaces the last dot with a
    comma before dealing with the value of ActualCost and ReplacementCost.
   
    Test Plan:
    a)Replicate the issue:
        0- Set CurrencyFormat to FR
        1- Go to Acquisitions
        2- Search for a Vendor
        3- Click on "New basket"
        4- Give basket a name and click "Save"
        5- Click on "Add to basket"
        6- Add an order through preferred method
        7- In Accounting details, enter a vendor price with dot decimal (i.e. 19.44)
        8- Save your order line
        9- Click on "Close this basket"
        10- Confirm closing of basket by clicking on "Yes, close"
        11- Click on "Receive shipment"
        12- Enter an invoice number and click "Next"
        13- Click on "Receive" to the right of your order
        14- In Accounting details, notice the Actual cost is written with a decimal dot.
        15- Change the Actual cost, using a dot decimal (i.e 20.99)
        16- Receive the order
        17- Click on "Save"
        18- In "Already received" notice the price is multiplied by 100 (i.e. 2099,00)
        19- Click on "Cancel receipt"
        20- Click on "Receive" to the right of your order
        21- In Accounting details, change the Actual cost, using a comma decimal (i.e. 20,99)
        22- Receive the order
        23- Click on "Save"
        24- In "Already received", notice the price is correct.
    b)Apply the patch
    c)Test the patch:
        1- Click on "Cancel receipt"
        2- Click on "Receive to the right of your order
        3- Change the Actual cost/Replacement cost, using a dot decimal (21.99)
        4- Receive the order
        5- Click on "Save"
        6- Notice that the Actual cost and the Replacement cost use commas
        7- Change the Actual cost, using a comma decimal (21,99)
        8- Click on "Save"
        9- In "Already received", notice the price is still correct.
   
    Signed-off-by: Victor Grousset <[hidden email]>
   
    Signed-off-by: Katrin Fischer <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>

-----------------------------------------------------------------------

Summary of changes:
 C4/ILSDI/Services.pm                               |   12 ++
 C4/Letters.pm                                      |    2 +-
 C4/Reserves.pm                                     |    2 +-
 Koha/pdfformat/layout3pagesfr.pm                   |    2 +-
 acqui/finishreceive.pl                             |   10 ++
 catalogue/moredetail.pl                            |    4 +-
 circ/renew.pl                                      |    1 +
 debian/docs/koha-common.xml                        |   21 +--
 debian/docs/koha-enable-sip.xml                    |   57 --------
 debian/docs/{koha-zebra.xml => koha-sip.xml}       |   35 +++--
 debian/docs/koha-start-sip.xml                     |   53 -------
 debian/docs/koha-stop-sip.xml                      |   52 -------
 debian/koha-common.bash-completion                 |   46 ++++--
 debian/koha-common.init                            |    9 +-
 debian/koha-common.install                         |    4 +-
 debian/koha-common.links                           |    5 +-
 debian/scripts/koha-disable                        |    2 +-
 debian/scripts/koha-enable-sip                     |   38 -----
 debian/scripts/koha-functions.sh                   |   14 ++
 debian/scripts/koha-remove                         |    4 +
 debian/scripts/{koha-zebra => koha-sip}            |  148 ++++++++++++--------
 debian/scripts/koha-start-sip                      |   68 ---------
 debian/scripts/koha-stop-sip                       |   45 ------
 koha-tmpl/intranet-tmpl/prog/en/modules/about.tt   |    2 +-
 .../intranet-tmpl/prog/en/modules/acqui/basket.tt  |    2 +-
 .../intranet-tmpl/prog/en/modules/acqui/invoice.tt |    2 +-
 .../prog/en/modules/acqui/orderreceive.tt          |    2 +-
 .../intranet-tmpl/prog/en/modules/acqui/parcel.tt  |    2 +-
 .../prog/en/modules/acqui/supplier.tt              |    2 +-
 .../prog/en/modules/admin/classsources.tt          |    4 +-
 .../prog/en/modules/catalogue/moredetail.tt        |    5 +-
 .../prog/en/modules/circ/circulation.tt            |    4 +-
 .../en/modules/circ/circulation_batch_checkouts.tt |    2 +-
 .../prog/en/modules/ill/ill-requests.tt            |    5 +-
 .../prog/en/modules/labels/spinelabel-print.tt     |    2 +-
 .../prog/en/modules/members/moremember-print.tt    |    8 +-
 .../prog/en/modules/tools/holidays.tt              |   24 +++-
 members/summary-print.pl                           |    2 +-
 reports/guided_reports.pl                          |    9 +-
 reserve/request.pl                                 |    1 -
 t/db_dependent/ILSDI_Services.t                    |   13 +-
 t/db_dependent/Letters.t                           |   17 ++-
 t/db_dependent/Reserves.t                          |    8 +-
 43 files changed, 292 insertions(+), 458 deletions(-)
 delete mode 100644 debian/docs/koha-enable-sip.xml
 copy debian/docs/{koha-zebra.xml => koha-sip.xml} (61%)
 delete mode 100644 debian/docs/koha-start-sip.xml
 delete mode 100644 debian/docs/koha-stop-sip.xml
 delete mode 100755 debian/scripts/koha-enable-sip
 copy debian/scripts/{koha-zebra => koha-sip} (57%)
 delete mode 100755 debian/scripts/koha-start-sip
 delete mode 100755 debian/scripts/koha-stop-sip


hooks/post-receive
--
main Koha release repository
_______________________________________________
koha-commits mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits