main Koha release repository branch master updated. v18.05.00-724-g293e84d
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 293e84d38dd25ae5bd08c2cdd5ce064f4201a79c (commit)
via c427952783776bd9e6f79ee3860f968bea5b82a9 (commit)
via cf3dbedae75b19ffd649725dddce212b63738582 (commit)
via 4e8d22a51bf707d3e160a87a125bd8d8f9eb04e6 (commit)
via 5d2ef635627fd35f721c086e7b6491a7e82b958a (commit)
via 0c4460c2fbb6fb678381921911d9030419cc9700 (commit)
via 5acdbb1d2dcb0bd2719f88aa6905c2cf91fab1db (commit)
via 59b78fd095ecf7db88f339cc2f03d923b095130d (commit)
via b8104d8882790b45c1d3b65386bd37ed1cc671d7 (commit)
via 5ef7f04f58dd470b85988b866a2e608256904da8 (commit)
via 765c28c8e3a7e11afac1a061ebd296f18f3ef8a5 (commit)
via fac3944aa1c6c0c43e5ceac77fe1d163b22bf3e2 (commit)
via 51a769bb59efe1b4511805734d2ef73b8fbbac81 (commit)
via 42c94d185ab44c075073dd08762c4bb71df77b16 (commit)
via 18d85cc8d72b55880e88c5364a3819965c8a2831 (commit)
via 83e515820abb6e2fa8ddf30f61b3f4972a48ed10 (commit)
via 030047da428521c248868e3ee5d655afd3bed05b (commit)
via bf7082f854a1db9eb5b7eb77e5f450d018d8e07b (commit)
via 331af8521b5fba4b5553c182888a4017b2ce9c3a (commit)
via 68138b225807a857ddbddef7680c43f2b10de87e (commit)
via 235654a3cfa5b6e323489408ddc7875281bb1f50 (commit)
via 3fedae85f25ef5f587d567b51b86aab776d87311 (commit)
via 46c992948ea28ae2bebc7f9042df6434319b80bf (commit)
via be0a897648e4ae1ebb429d0829c22a8534a81606 (commit)
from a9e859942c8cf8c4de8e872fb3ed79b5f80fa19a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
Author: Jonathan Druart <[hidden email]>
Date: Fri Aug 31 13:51:18 2018 -0300
Bug 21293: Remove another misplaced html filter on housebound.tt
Author: Owen Leonard <[hidden email]>
Date: Thu Aug 30 16:43:09 2018 +0000
Bug 21293: Display of housebound delivery information broken by Bug 13618
This patch corrects the patron housebound details template. A stray
"html" filter broke display of delivery information.
To test, apply the patch and enable the HouseboundModule system
- Open a patron record and select the "Housebound" tab in the left-hand
- Click "Add a new deliver" and save some delivery details.
- Upon saving you should be directed back to the housebound details
page. All the details of the delivery you saved should appear
Author: Kyle M Hall <[hidden email]>
Date: Sat Sep 30 08:02:57 2017 -0400
Bug 19469: Add ability to split view of holds view on record by pickup library and/or itemtype
It is possible to set up circulation rules to limit trapping of holds by pickup library and itemtype.
To make it easier to understand which holds will be trapped in a given circumstance,
it would be nice if we could optionally group holds by pickup library and/or itemtype.
1) Apply this patch set
2) Run updatedatabase.pl
3) Enable AllowHoldItemTypeSelection
4) Pick a record and create holds with various pickup libraries and itemtype combinations
5) Enable HoldsSplitQueueNumbering
6) Try the different combinations of HoldsSplitQueue
7) Ensure the hold "arrows" move the items correctly
* Up and down arrows should move hold above or below the adjacent hold within a hold fieldset
* Top and borrom arrows should move hold to the top or bottom within a hold fieldset
Author: Pasi Kallinen <[hidden email]>
Date: Mon Aug 20 07:30:45 2018 +0300
Bug 21248: Fix COinS carp in MARC details page on unknown record
Looking up a nonexistent record in the MARC details -page causes
the COinS to carp. The fix is trivial, just move the COinS call
couple lines, after the record existence check.
1) reset_all for kohadevbox
2) log in to staff client - admin/admin
3) search catalogue for green
4) tweak the top URL to have a bad biblionumber (eg. 9999)
5) cat /var/log/koha/kohadev/plack-err.log
-- floody! with errors.
6) echo | sudo tee /var/log/koha/kohadev/plack-err.log
8) repeat steps 2 through 5.
-- just nice starting messages, not floody.
9) run koha qa test tools
Bug 13779: sessionID declared twice in C4::Auth::checkauth()
The bug is that $sessionID is declared twice in C4::Auth::checkauth().
At the moment, this doesn't actually create a problem, because no
one seems to be using the $sessionID which is returned by checkauth(),
except in the case of opac/external/overdrive/auth.pl which skips
the second declartion as it doesn't require auth.
This patch removes the redefining of the $sessionID variable.
In terms of testing, try logging in with a username and password
and see if it works. The only risk this patch would pose is breaking
auth I would think, since nothing is actually using the return value
from checkauth() for $sessionID.
It was initially defined near the top of the function (~line 791).
I believe the scoping would mean the correct version of $sessionID
would be used in the latter lines for the unset'ing.
I have skimmed code to see if the sessionID return value is used.
I did not test overdrive, as I do not know how. However, this is
the only area, I think this could possibly break. This change makes
sense to me.
QA: Please test overdrive.
opac/external/overdrive/auth.pl only checks if the value is set, so
this patch might fix/break something there?
opac/svc/overdrive same kind of check.
Signed-off-by: Marcel de Rooy <[hidden email]>
This is a (tiny) code improvement. Now we consistently return the session
id that is also stored in the returned cookie. (Which can be an 'anon'
Fact is that Koha almost everywhere ignores the returned session id and
sometimes gets the session from the cookie (obviously). The session id is
also passed to the template by get_template_and_user but never used in
As mentioned, the two overdrive scripts are the exception. But since both
test on both $user && $sessionID, they will not choke on an anynonomous
session id without userid. So theoretically fine, but not tested.
Author: Nick Clemens <[hidden email]>
Date: Fri Sep 7 11:33:44 2018 +0000
Bug 21324: Fix column defs and spans
1 - Open a bastket in acquisitions
2 - Order some items
3 - Close the basket
4 - Receive some items
5 - Note the columns are out of alingment on parcel.pl
6 - Note a JS error breaking datatable on 'Already received'
7 - Apply patch
8 - Things should be better
Author: Tomas Cohen Arazi <[hidden email]>
Date: Wed Aug 29 13:46:39 2018 -0300
Bug 21285: Add missing select2x2.png file
This file is part of the Select2 jquery plugin, but wasn't added when
the use of the plugin was introduced in Koha.
- On a high DPI screen (retina mac?) on Chrome or Safari
- Edit an item
=> FAIL: dropdowns using Select2 (like 'Shelving location') don't display the icons (down arrow and cross) and a default value is wrongly selected
=> FAIL: the inspector says the requested select2x2.png file returned a 400 error.
- Apply this patch
- Reload the edit page
=> SUCCESS: Things display correctly! Dropdowns without selected values
=> SUCCESS: No errors fetching select2x2.png
- Sign off :-D
Author: Tomas Cohen Arazi <[hidden email]>
Date: Mon Jul 23 11:14:47 2018 -0300
Bug 21116: Add API routes through plugins
This patch adds plugins the capability of injecting new routes on the
The plugins should provide the following methods to be considered valid API-generating plugins:
- 'api_routes': returning the 'path' component of the OpenAPI specification corresponding to the routes served by the plugin
- 'api_namespace': it should return a namespace to be used for grouping the endpoints provided by the plugin
otherwise, they will be just skipped.
All plugin-generated routes will be added the 'contrib' namespace, and
will end up placed inside /contrib/<namespace>, where <namespace> is what the 'api_namespace' returns.
A sample endpoint will be added to the Kitchen Sink plugin, and tests
are being written.
- Apply this patches
k$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t
=> SUCCESS: Tests pass!
- Install the (latest) KitchenSink plugin
- Point your browser to the API like this:
http://koha-intra.myDNSname.org:8081/api/v1/.html => SUCCESS: The /contrib/kitchensink/patrons/:patron_id/bother endpoint
implemented by the plugin has been merged!
- Sign off! :-D
Author: Tomas Cohen Arazi <[hidden email]>
Date: Mon Aug 27 16:24:09 2018 -0300
Bug 21116: Unit tests
This path implements unit tests for the route-from-plugin development.
It adds the required methods to the Koha::Plugin::Test plugin
distributed along with the tests. A second plugin implementing invalid
OpenAPI specs is added (Koha::Plugin::BadAPIRoute).
Edit: I made terminology changes to make it less rude.