main Koha release repository branch 3.22.x updated. v3.22.19-2-gc0e64cb

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

main Koha release repository branch 3.22.x updated. v3.22.19-2-gc0e64cb

Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.22.x has been updated
       via  c0e64cbc14750d61b853e1324827dcfb5eed3bc3 (commit)
      from  2907d4bf907ec1d3f6a618f29bc5859837b559e4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c0e64cbc14750d61b853e1324827dcfb5eed3bc3
Author: Jonathan Druart <[hidden email]>
Date:   Fri Feb 24 11:44:23 2017 +0100

    Bug 18022: Fix possible crash if CircAutoPrintQuickSlip=clear screen
    If CircAutoPrintQuickSlip is set to clear screen, the $borrowernumber variable
    is reset but $borrower.
    In 16.11.x and before that causes the app to crash, because
    $borrower->{flags} is set to a hashref by GetMemberDetails, if
    $borrowernumber is set.
    This case is better handled in master (17.05) but side-effects could
    happen: if $borrowernumber is reset, $borrower should be reset too.
    The way to drive this behaviour is terrible and lot of things should be
    done to clean this area. This patch is a quick and easy fix to make it
    backportable easily.
    Test plan:
    On master, no change expected
    On 16.11 and before:
    0. Set CircAutoPrintQuickSlip=clear screen
    1. Create a new patron
    2. Set permission for this patron to 'reservesforothers' (or something
    3. Go on the circulation tab
    4. Do not fill the barcode input and submit
    => Without this patch you will get an error
    Can't use string ("64") as a HASH ref while "strict refs"....
    => With this patch apply you will get a blank screen (expected
    I would recommend to test this patch with the other value of
    CircAutoPrintQuickSlip as well
    (cherry picked from commit 34565e7f7d38298d37f449520dd5bc20cec833f8)
    Signed-off-by: Julian Maurice <[hidden email]>


Summary of changes:
 circ/ |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

main Koha release repository
koha-commits mailing list
[hidden email]