main Koha release repository branch 18.11.x updated. v18.11.02-114-g99cd91a

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

main Koha release repository branch 18.11.x updated. v18.11.02-114-g99cd91a

Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  99cd91ad2dbbc1c24bf4aea41865147013f947bb (commit)
       via  9199083de8637d96148b873cc745c1a81fe78d01 (commit)
       via  0f0218bc838bee7b55853a456334fd2518b5784c (commit)
       via  9c823701268d07feb149e219ece7c88d89d47732 (commit)
       via  f2151c1bbc98003576606d8b1bd2cb2453e6925a (commit)
       via  413f34ba244af3560861785f5aa74ab457f00b02 (commit)
       via  2da377435f03ced75d2f9deb782f9838f4cafbdf (commit)
       via  411f8faffdd0b9eb7c158ab8717029dd10721bcb (commit)
       via  7f5602a3c36d7975f7f31698459d5e80b0287f77 (commit)
       via  09ef59cf797853a3b85928ce0c6cf4e084cac64d (commit)
       via  39acd694cafab8cacd36df329b8a9cda89ed6bd9 (commit)
       via  567c0df6ee1510fbfa1085460e678ee9e0a4dfa4 (commit)
       via  150de6dfe7f7d18f5b61e45b0442802c2f61fe9f (commit)
       via  55b20ad1a7b8afa5c385bd3f9825014d40936ba1 (commit)
       via  dcc0478089f5fde72426d94810bed6430df73a34 (commit)
       via  41115fc79dfd16be62dd56e1946e0a2e08c6a2fc (commit)
      from  491ad8fc3389be9db46eb8d42f03f78befd69e66 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 99cd91ad2dbbc1c24bf4aea41865147013f947bb
Author: Aleisha Amohia <[hidden email]>
Date:   Wed Dec 19 20:32:32 2018 +0000

    Bug 20000: Use Modern::Perl in installer scripts
   
    To test:
   
    Check that we are using Modern::Perl when strict *and* warnings were used before,
    and commented lines and FIXMEs have been removed from the rest, out of
    files listed below.
   
    data/mysql/backfill_statistics.pl
    data/mysql/labels_upgrade.pl
    data/mysql/patroncards_upgrade.pl
    data/mysql/update22to30.pl
    data/mysql/updatedatabase.pl
    externalmodules.pl
    html-template-to-template-toolkit.pl
    install.pl
   
    Sponsored-by: Catalyst IT
    Signed-off-by: Maryse Simard <[hidden email]>
   
    Signed-off-by: Katrin Fischer <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>
    (cherry picked from commit 20a38ee50e6fe62712e299bcec9e939dc2bbb58e)
    Signed-off-by: Martin Renvoize <[hidden email]>

commit 9199083de8637d96148b873cc745c1a81fe78d01
Author: Marcel de Rooy <[hidden email]>
Date:   Mon Nov 12 11:48:23 2018 +0100

    Bug 21808: Field 711 is not handled correctly in showAuthor XSLT for relator term or code
   
    The test should check $4 or $e for fields ne 111,711.
    And should check $4 or $j for 111,711.
   
    Test plan:
    Edit a record, add a meeting in 711 without $4 but with $j.
    Without this patch the term is not visible, with this patch it is.
   
    Signed-off-by: Pierre-Marc Thibault <[hidden email]>
   
    Signed-off-by: Kyle M Hall <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>
    (cherry picked from commit 6179f23dd8b4ed24add2e76c7b8e193372052201)
    Signed-off-by: Martin Renvoize <[hidden email]>

commit 0f0218bc838bee7b55853a456334fd2518b5784c
Author: Kyle M Hall <[hidden email]>
Date:   Thu Jan 10 14:32:22 2019 -0500

    Bug 22097: CataloguingLog should be suppressed for item branch transfers
   
    Bug 18816 missed the fact that a branch transfer triggers ModItem and
    thus generates an action log line. We should not be creating those
    action logs, especially considering the transfers table itself already
    documents the transfer.
   
    Test Plan:
    1) Enable CataloguingLog
    2) Transfer an item to another branch
    3) Note the new action log line created
    4) Apply this patch
    5) Create another item transfer
    6) No new action log line should be created!
   
    Signed-off-by: Owen Leonard <[hidden email]>
   
    Signed-off-by: Katrin Fischer <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>
    (cherry picked from commit b3c25b64b868b56423c50b9df4fac4bb55947679)
    Signed-off-by: Martin Renvoize <[hidden email]>

commit 9c823701268d07feb149e219ece7c88d89d47732
Author: Jonathan Druart <[hidden email]>
Date:   Tue Dec 11 10:13:42 2018 -0300

    Bug 21907: Fix article requests count for non-superlibrarians
   
    The query generates "Column 'branchcode' in where clause is ambiguous"
   
    Test plan:
    1 - Enable 'IndependentBranchesPatronModifications' and article requests
    2 - Sign in as non-superlibrarian
    3 - View plack log
    4 - Refresh mainpage, see error in logs
   
    Signed-off-by: Nick Clemens <[hidden email]>
   
    Signed-off-by: Katrin Fischer <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>
    (cherry picked from commit ab9e4ca6a46519ddc69ad76837407c0a4f0ed0cd)
    Signed-off-by: Martin Renvoize <[hidden email]>

commit f2151c1bbc98003576606d8b1bd2cb2453e6925a
Author: Owen Leonard <[hidden email]>
Date:   Wed Oct 3 16:07:19 2018 +0000

    Bug 16231: Correct permission handling in subscription edit
   
    This patch corrects the way subscription edit menu items are displayed
    according to the user's permissions settings.
   
    To test, apply the patch and log in to the staff client as a user who
    has permission to create, edit, and delete subscriptions.
   
    - Locate an subscription and view the details for it.
    - Confirm that each "Edit" menu item works correctly.
    - Repeat the process when logged in as a user with varying combinations
      of create, edit, and delete permissions.
    - Test as a user limited by IndependentBranches.
   
    Signed-off-by: Charles Farmer <[hidden email]>
   
    Signed-off-by: Katrin Fischer <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>
    (cherry picked from commit 7520ede89987a7a65301debdda46950a6364ebfd)
    Signed-off-by: Martin Renvoize <[hidden email]>

commit 413f34ba244af3560861785f5aa74ab457f00b02
Author: Martin Renvoize <[hidden email]>
Date:   Fri Feb 1 09:55:54 2019 +0000

    Bug 22254: Correction to datehandling in test
   
    Adding 13 months is not always the same as adding 1 month and then
    adding 12 months in DateTime maths.  This patch rectified the test
    to match the correct behaviour in koha.
   
    Test plan.
   
    1) Modify the test (around line 268) to test against the suspect
       leap date of 2019-01-31 and watch the test fail.
    2) Apply the patch (which also adds this modification to test
       for such a leap date) and watch the test now pass.
   
    Signed-off-by: Tomas Cohen Arazi <[hidden email]>
   
    Signed-off-by: Katrin Fischer <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>
    (cherry picked from commit 1da0ba48b6fdf38cfd3d3ea63ec076b15995610f)
    Signed-off-by: Martin Renvoize <[hidden email]>

commit 2da377435f03ced75d2f9deb782f9838f4cafbdf
Author: Nick Clemens <[hidden email]>
Date:   Fri Jan 4 18:37:09 2019 +0000

    Bug 19915: (follow-up) Fix test count from rebase
   
    https://bugs.koha-community.org/show_bug.cgi?id=19905
   
    Signed-off-by: Katrin Fischer <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>
    (cherry picked from commit a32653a66fa02f1fe9002647d337261bf36d62e0)
    Signed-off-by: Martin Renvoize <[hidden email]>

commit 411f8faffdd0b9eb7c158ab8717029dd10721bcb
Author: Nick Clemens <[hidden email]>
Date:   Thu Nov 1 13:11:16 2018 +0000

    Bug 19915: Don't delete in tests
   
    https://bugs.koha-community.org/show_bug.cgi?id=19905
   
    Signed-off-by: Katrin Fischer <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>
    (cherry picked from commit 9961e2c08f8dba0896ed4f6bfa6a7befebd28d5d)
    Signed-off-by: Martin Renvoize <[hidden email]>

commit 7f5602a3c36d7975f7f31698459d5e80b0287f77
Author: Nick Clemens <[hidden email]>
Date:   Fri Jun 15 04:10:39 2018 +0000

    Bug 19915: Only show class sources in use
   
    Signed-off-by: Marcel de Rooy <[hidden email]>
   
    https://bugs.koha-community.org/show_bug.cgi?id=19905
   
    Signed-off-by: Katrin Fischer <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>
    (cherry picked from commit a8259c38dbe910188ece5126d226166014e001ed)
    Signed-off-by: Martin Renvoize <[hidden email]>

commit 09ef59cf797853a3b85928ce0c6cf4e084cac64d
Author: Nick Clemens <[hidden email]>
Date:   Thu Jan 4 15:00:28 2018 +0000

    Bug 19915: Use cn_sort values for getting inventory items
   
    To test:
    1 - Catalog an item under LCC with callnumber GT95
    2 - cn_sort should calculate as GT0095
    3 - Go to inventory tool
    4 - Enter a range that should have your item e.g LC GT90 to GT100
    5 - Item is not returned
    6 - Apply patch
    7 - Item should be returned
    8 - Verify things otherwise work as expected
   
    Signed-off-by: Anne-Claire Bernaudin <[hidden email]>
   
    Signed-off-by: Marcel de Rooy <[hidden email]>
   
    https://bugs.koha-community.org/show_bug.cgi?id=19905
   
    Signed-off-by: Katrin Fischer <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>
    (cherry picked from commit d2ce727e260f6b45266a8147aee7654811a44fa1)
    Signed-off-by: Martin Renvoize <[hidden email]>

commit 39acd694cafab8cacd36df329b8a9cda89ed6bd9
Author: Marcel de Rooy <[hidden email]>
Date:   Fri Jul 6 11:20:47 2018 +0200

    Bug 19915: (QA follow-up) Tidy up GetItemsForInventory.t
   
    Standard edits like modules, schema, Koha objects instead of DBIC.
    Removing unneeded autoflush.
    Moving initial test to a first subtest.
    No need to clear issues if you clear items.
    Adding a FIXME for OldWay; would be nice to remove that code..
   
    Signed-off-by: Marcel de Rooy <[hidden email]>
   
    https://bugs.koha-community.org/show_bug.cgi?id=19905
   
    Signed-off-by: Katrin Fischer <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>
    (cherry picked from commit c345d30cc8284f690f375faa140de49e62358709)
    Signed-off-by: Martin Renvoize <[hidden email]>

commit 567c0df6ee1510fbfa1085460e678ee9e0a4dfa4
Author: Nick Clemens <[hidden email]>
Date:   Thu Jan 4 14:53:14 2018 +0000

    Bug 19915: Add unit test to GetItemsForInventory.t
   
    prove -v t/db_dependent/Items/GetItemsForInventory.t
   
    Signed-off-by: Anne-Claire Bernaudin <[hidden email]>
   
    Signed-off-by: Marcel de Rooy <[hidden email]>
    Moved the betwen typo edit back here.
   
    https://bugs.koha-community.org/show_bug.cgi?id=19905
   
    Signed-off-by: Katrin Fischer <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>
    (cherry picked from commit 186209875a4951b15faded3f8c47eba71716c7af)
    Signed-off-by: Martin Renvoize <[hidden email]>

commit 150de6dfe7f7d18f5b61e45b0442802c2f61fe9f
Author: Marcel de Rooy <[hidden email]>
Date:   Wed Jan 30 15:37:10 2019 +0000

    Bug 22236: Translation should generate tags with consistent attribute order
   
    When running misc/translator/translate, the order of attributes in the translated templates is not consistent and may vary. This is caused by the random order of hash keys in perl.
   
    This causes things like this in run 1:
    <input type="submit" class="btn" value="Plaats aanvraag" />
    And this in run 2:
    <input value="Plaats aanvraag" type="submit" class="btn" />
    As you can see, there is actually no difference apart from the order.
   
    When comparing the result of various translation runs, I would rather get rid of such noise and only see the real changes.
   
    The needed change is not trivial to find, but only requires a simple addition to a sort operation in tmpl_process3.pl. The current sort only makes sure that the '/' comes at the end. We should sort the names of the keys too when this value is 0 (just meaning: no end tag symbol).
   
    Test plan:
    [1] Run a translation without this patch and set a few templates aside.
    [2] Run a translation with this patch.
    [3] Run a compare (diff) on the templates copied in step 1. Verify that the
        only changes are found in the sort order of attributes in html tags.
   
    Signed-off-by: Pierre-Marc Thibault <[hidden email]>
   
    Signed-off-by: Josef Moravec <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>
    (cherry picked from commit fb62e8d1fc8b210a5b23801b7b8faff3280bf638)
    Signed-off-by: Martin Renvoize <[hidden email]>

commit 55b20ad1a7b8afa5c385bd3f9825014d40936ba1
Author: Fridolin Somers <[hidden email]>
Date:   Thu Jan 31 09:12:13 2019 +0100

    Bug 22242: Javascript error in value builder cased by Select2
   
    Same as Bug 17780 but in value builders.
   
    Select2 (Bug 13501) introduced divs and inputs that broke some
    assumptions about the expected HTML structure. This patch checks if
    input has name attribute, because some inputs in Select2 have not.
   
    It brakes value builders marc21_linking_section.tt and
    unimarc_field_4XX.tt.
   
    Test plan :
    1)  On a MARC21 database
    2)  Define 774$0 as a regular subfield
    3)  Define 774$4 with an authorised value category
    4)  Define 774$t with value builder marc21_linking_section
    5)  Create a new record
    6)  Use value builder in 774$t
    7)  Search for a record and click choose
    8)  Without patch : a popup window does not close and show a blank
        screen
    9)  With patch : popup windows get close and you see in field 774 $0 and
        $t field with values
    10) Same tests with a UNIMARC database on field 461 with value builder
        unimarc_field_4XX.tt
   
    Signed-off-by: Owen Leonard <[hidden email]>
   
    Tested successfully with MARC21
   
    Signed-off-by: Josef Moravec <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>
    (cherry picked from commit 3ca0234d34ac9708a8335cfa97805fb7498201bf)
    Signed-off-by: Martin Renvoize <[hidden email]>

commit dcc0478089f5fde72426d94810bed6430df73a34
Author: Tomas Cohen Arazi <[hidden email]>
Date:   Thu Jan 24 14:29:09 2019 -0300

    Bug 19816: Implement dateonly for rfc3339 format
   
    This patch implements the dateonly option for the rfc3339. This is
    described in the OpenAPI 2.0 specification [1]. The required output
    format is described on RFC 3339 [2], as 'full-date'.
   
    [1] https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#dataTypeFormat
    [2] https://tools.ietf.org/html/rfc3339#section-5.6
   
    To test:
    - Apply the regression tests patch
    - Run:
     k$ prove t/DateUtils.t
    => FAIL: Tests fail because dateonly is not implemented
    - Apply this patch
    - Run:
     k$ prove t/DateUtils.t
    => SUCCESS: Tests pass!
    - Sign off :-D
   
    Signed-off-by: Josef Moravec <[hidden email]>
    Signed-off-by: Martin Renvoize <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>
    (cherry picked from commit b2dce05ddff8a047e7770ea241b1edd9b798212e)
    Signed-off-by: Martin Renvoize <[hidden email]>

commit 41115fc79dfd16be62dd56e1946e0a2e08c6a2fc
Author: Tomas Cohen Arazi <[hidden email]>
Date:   Thu Jan 24 14:27:28 2019 -0300

    Bug 19816: Regression tests
   
    This patch adds tests for the rfc3339 behaviour when dateonly => 1.
   
    To test:
    - Run:
      $ kshell
     k$ prove t/DateUtils.t
    => SUCCESS: Tests pass
    - Apply this patch
    - Run:
     k$ prove t/DateUtils.t
    => FAIL: dateonly is not implemented
   
    Signed-off-by: Josef Moravec <[hidden email]>
    Signed-off-by: Martin Renvoize <[hidden email]>
   
    Signed-off-by: Nick Clemens <[hidden email]>
    (cherry picked from commit 7e69ab62a5ef3fbd350c6606d25b5ab6f6bc168e)
    Signed-off-by: Martin Renvoize <[hidden email]>

-----------------------------------------------------------------------

Summary of changes:
 C4/Items.pm                                        |   14 +++--
 Koha/DateUtils.pm                                  |    9 ++-
 installer/data/mysql/backfill_statistics.pl        |    3 +-
 installer/data/mysql/labels_upgrade.pl             |    3 -
 installer/data/mysql/patroncards_upgrade.pl        |    3 -
 installer/data/mysql/update22to30.pl               |    1 -
 installer/data/mysql/updatedatabase.pl             |    3 +-
 installer/externalmodules.pl                       |    5 +-
 installer/html-template-to-template-toolkit.pl     |    3 +-
 installer/install.pl                               |    3 +-
 .../prog/en/includes/serials-toolbar.inc           |   35 +++++++----
 .../value_builder/marc21_linking_section.tt        |    1 +
 .../cataloguing/value_builder/unimarc_field_4XX.tt |    1 +
 .../prog/en/modules/tools/inventory.tt             |   13 ++++-
 .../prog/en/xslt/MARC21slim2intranetDetail.xsl     |    2 +-
 .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl    |    2 +-
 mainpage.pl                                        |    2 +-
 misc/translator/tmpl_process3.pl                   |    1 +
 t/DateUtils.t                                      |    5 +-
 t/db_dependent/Items/GetItemsForInventory.t        |   61 ++++++++++++++++++--
 t/db_dependent/Koha/Patrons.t                      |    8 +--
 tools/inventory.pl                                 |   10 ++++
 22 files changed, 138 insertions(+), 50 deletions(-)


hooks/post-receive
--
main Koha release repository
_______________________________________________
koha-commits mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits