main Koha release repository branch 17.05.x updated. v17.05.01-29-gf4b6e59

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

main Koha release repository branch 17.05.x updated. v17.05.01-29-gf4b6e59

Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.05.x has been updated
       via  f4b6e5963ff3511d54f1af1f66d1fb7c1e2cfb4a (commit)
       via  306055cd81a8f61cd25025f89bdb5e8d90a33caf (commit)
      from  bb14ce9d657f2a30621a0a6465809cef1f820f3c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f4b6e5963ff3511d54f1af1f66d1fb7c1e2cfb4a
Author: Marcel de Rooy <[hidden email]>
Date:   Thu Jun 22 08:55:16 2017 +0200

    Bug 18214: Add check for shared or public list
    Following the idea behind bug 10865, we are only showing the permissions
    when the list is shared or public.
    Adding a simple test in opac-shelves here.
    Note 1: Since the owner can always add or delete entries, the permissions
    will not be relevant anymore for a strictly private list.
    Note 2: Staff view always shows the permissions. This could have been
    changed here too, but that change is far less urgent (bug 10865 did not
    touch staff view and bug 18228 will rearrange permissions anyway).
    Test plan:
    [1] Verify on OPAC that you see the permissions for a private list with
        shares or a public list. And you do not see them for a private list
        without shares.
    Signed-off-by: Marcel de Rooy <[hidden email]>
    (cherry picked from commit b494837c8d17a29936e2c2bcc067120c26876855)
    Signed-off-by: Fridolin Somers <[hidden email]>

commit 306055cd81a8f61cd25025f89bdb5e8d90a33caf
Author: Marcel de Rooy <[hidden email]>
Date:   Mon Mar 6 09:44:48 2017 +0100

    Bug 18214: Cannot edit list permissions of a private list
    If you have disabled the pref OpacAllowPublicListCreation, your users are
    not able to edit the list permissions for private/shared lists.
    For a private list they may only be theoretically relevant, but for a shared
    list they are relevant.
    Since we do not always know the history of a list (has it been public or
    shared, does it contains entries from other users) and therefore permissions
    are even relevant for a currently private list, we should just allow editing
    these permissions.
    Test plan:
    [1] Do not yet apply this patch.
    [2] Disable OpacAllowPublicListCreation.
    [3] Create a private list in OPAC. Edit the list. Verify that you do not
        see the permission combo boxes.
    [4] Apply this patch. Edit the list again. Do they appear now?
    Signed-off-by: Marcel de Rooy <[hidden email]>
    Signed-off-by: Magnus Enger <[hidden email]>
    Works as advertised.
    (cherry picked from commit 3d2eddaf3da3e090d00b4e5823f8f70a70c06ea1)
    Signed-off-by: Fridolin Somers <[hidden email]>


Summary of changes:
 koha-tmpl/opac-tmpl/bootstrap/en/modules/ |    2 ++
 1 file changed, 2 insertions(+)

main Koha release repository
koha-commits mailing list
[hidden email]