main Koha release repository branch 17.05.x updated. v17.05.01-20-g45c3133

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

main Koha release repository branch 17.05.x updated. v17.05.01-20-g45c3133

Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.05.x has been updated
       via  45c31333a879e35ecf7ddc12d5305002c80ba065 (commit)
       via  a5370edb9b90150f7aa4000c42ec523b9c0cbea8 (commit)
      from  07672a77c666354578467c2a35c0f2ea7e512c73 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 45c31333a879e35ecf7ddc12d5305002c80ba065
Author: Marcel de Rooy <[hidden email]>
Date:   Mon May 29 12:08:40 2017 +0200

    Bug 18607: Adjusting unit tests for monthly serial frequencies
   
    The changes in the first patch require some corrections as well as
    additional test cases.
   
    GetNextDate.t: Since the calculation for multiple issues per unit has
    slightly changed, a few dates (day 15 or day 16) have been changed in the
    unit test; when we use 2/month, the algorithm now always adds 15 days.
    Added a few test descriptions in this regard too.
   
    GetFictiveIssueNumber.t: Add the monthly subtest with two test cases. In
    the first case we tests multiple units per issue, and in the second case
    we test multiple issues per unit (month).
   
    Test plan:
    [1] Run t/db_dependent/Serials/GetFictiveIssueNumber.t
    [2] Run t/db_dependent/Serials/GetNextDate.t
   
    Signed-off-by: Marcel de Rooy <[hidden email]>
   
    Signed-off-by: Josef Moravec <[hidden email]>
   
    Signed-off-by: Kyle M Hall <[hidden email]>
   
    Signed-off-by: Jonathan Druart <[hidden email]>
    (cherry picked from commit 05a49035ccff1d962ef0c21ca1b154e07ba5dba7)
    Signed-off-by: Fridolin Somers <[hidden email]>

commit a5370edb9b90150f7aa4000c42ec523b9c0cbea8
Author: Marcel de Rooy <[hidden email]>
Date:   Tue May 16 14:46:55 2017 +0200

    Bug 18607: Fix date calculations for monthly frequencies in Serials
   
    Similarly to the solution of bug 18356, this patch fixes the date
    calculation for monthly frequencies.
   
    The calculation in GetFictiveIssueNumber now makes use of the new
    _delta_units sub introduced on bug 18356.
   
    The calculation in _get_next_date_month is also very similar to the one
    in _get_next_date_year. I do not merge them here, but this could still
    be considered later on. At least consistency is achieved now between
    both routines. The connection with firstacquidate has been cut thru
    just like for year units.
   
    Test plan:
    [1] Without this patch, look at the prediction pattern for a
        subscription with first issue on Feb 21 and 5 per month. The first
        issues will be 21, 22, 23, 24, 25. Then jumping to 21, 23, 25, etc.
    [2] Apply the patch. Look at the same prediction pattern. You will now
        see 6 day intervals and a new cycle starting on the 21st.
        So Feb 21, 27, Mar 5, 11, 17 and Mar 21, 27, etc.
    [3] Edit an subscription. Try a few other monthly frequencies.
    [4] The next patch adjusts related unit tests.
   
    Signed-off-by: Marcel de Rooy <[hidden email]>
   
    Signed-off-by: Josef Moravec <[hidden email]>
   
    Signed-off-by: Kyle M Hall <[hidden email]>
   
    Signed-off-by: Jonathan Druart <[hidden email]>
    (cherry picked from commit adfcd8d79c6691fb1062a2a5874a736b7792d303)
    Signed-off-by: Fridolin Somers <[hidden email]>

-----------------------------------------------------------------------

Summary of changes:
 C4/Serials.pm                                  |   40 ++++++++++----------
 t/db_dependent/Serials/GetFictiveIssueNumber.t |   47 +++++++++++++++++++++++-
 t/db_dependent/Serials/GetNextDate.t           |   18 ++++-----
 3 files changed, 73 insertions(+), 32 deletions(-)


hooks/post-receive
--
main Koha release repository
_______________________________________________
koha-commits mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
Loading...