QA Tools

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

QA Tools

Marcel de Rooy

Hi Jonathan,

 

Got this warning from qa tools:

POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666

 

Looking at the code in qa tools, I come across:

 

            } elsif ( $before->{rating} > $after->{rating} ) {

                # Not sure we can reach this

                @diff = ('POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666');

 

When I removed a routine from C4::Biblio, this happens:

Before

C4::Biblio has a Pod::Coverage rating of 0.96078431372549

After

C4::Biblio has a Pod::Coverage rating of 0.96

 

If we have N subroutines and 2 without POD and a score of 2/N, and I remove one routine, we will now have 2 / N – 1.

This means that the before > after test does not work here. Raises a false negative.

 

Marcel

 

 


_______________________________________________
Koha-devel mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Loading...