[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #42 from Jacek Ablewicz <[hidden email]> ---
(In reply to Marcel de Rooy from comment #41)
> Especially the "Few subtle changes" patch makes a few additional refinements
> in this regard.

I can see an accommodation in this commit for missing $authtypefrom (for a
postponed merge, when the old record is already deleted), but it doesn't look
quite relevant to empty @record_from ;). I think there may be a problem in the
code which is located above that instead, namely

    my $authfrom = Koha::Authorities->find($mergefrom);
    my $authtypefrom = $authfrom ?
Koha::Authority::Types->find($authfrom->authtypecode) : undef;
    my $auth_tag_to_report_from = $authtypefrom ?
$authtypefrom->auth_tag_to_report : '';
    my @record_from;
    @record_from = $MARCfrom->field($auth_tag_to_report_from)->subfields() if
$auth_tag_to_report_from && $MARCfrom &&
$MARCfrom->field($auth_tag_to_report_from);

If the search

    my $authfrom = Koha::Authorities->find($mergefrom);

fails (I'm guessing it will fail, for the postponed "real" merge ?), $MARCfrom
will be ignored, no matter what (it's not used anywhere else in the merge()
subroutine) and @record_from will be empty.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Loading...