[Bug 7488] New: Errors with logs about moremember.pl / Messaging.pm

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7488

             Bug #: 7488
           Summary: Errors with logs about moremember.pl / Messaging.pm
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: master
          Platform: All
        OS/Version: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]
         QAContact: [hidden email]


When accessing a borrower detail page, the following lines appear in the logs:

[Wed Feb  1 15:55:44 2012] moremember.pl: Use of uninitialized value in
concatenation (.) or string at
/home/asaurat/workspace/versions/community/C4/Members/Messaging.pm line 216.
[Wed Feb  1 15:55:44 2012] moremember.pl: Use of uninitialized value in
concatenation (.) or string at
/home/asaurat/workspace/versions/community/C4/Members/Messaging.pm line 216.
[Wed Feb  1 15:55:44 2012] moremember.pl: Use of uninitialized value in
concatenation (.) or string at
/home/asaurat/workspace/versions/community/C4/Members/Messaging.pm line 216.

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7488

--- Comment #1 from Adrien SAURAT <[hidden email]> 2012-02-01 15:12:56 UTC ---
Created attachment 7411
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7411
proposed patch

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7488

--- Comment #2 from Adrien SAURAT <[hidden email]> 2012-02-01 15:17:05 UTC ---
Comment on attachment 7411
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7411
proposed patch

Proposed a very simple patch with minimal consequences. It will correct the bug
and nothing more.

But maybe we could go further, if the 'transport_X' is not mandatory it may be
better to avoid sending anything when the 'message_transport_type' is not
defined (NULL in DB).

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7488

Adrien SAURAT <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7488

--- Comment #3 from Ian Walls <[hidden email]> 2012-02-03 23:53:33 UTC ---
Can you provide a test case where message_transport_type would be undefined?
Under what circumstances is this allowed?

It doesn't seem logical to me (at first blush) that this should come up under
any normal usage scenario, so finding the root of the problem and fixing it
there may be a better course of action, rather than chasing down manifestations
like this.

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7488

Jared Camins-Esakov <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from Jared Camins-Esakov <[hidden email]> ---
I cannot reproduce this error. Could you explain the steps to reproduce?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7488

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |m

--- Comment #5 from Jonathan Druart <[hidden email]> ---
Adrien,
I have got the same problem on my install. I don't know why. Execute queries in
installer/data/mysql/.../sample_notices_message_transports.sql to populate your
message_transports table.
It should fix these warnings.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7488

--- Comment #6 from Jared Camins-Esakov <[hidden email]> ---
(In reply to comment #5)
> Adrien,
> I have got the same problem on my install. I don't know why. Execute queries
> in installer/data/mysql/.../sample_notices_message_transports.sql to
> populate your message_transports table.
> It should fix these warnings.

Jonathan,

Does that mean that this bug should be marked INVALID or WONTFIX?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/