[Bug 7432] New: Changing frameworks should refresh cache

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432

             Bug #: 7432
           Summary: Changing frameworks should refresh cache
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: master
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: System Administration
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]
         QAContact: [hidden email]
                CC: [hidden email]


I see several small problems when using memcache and making changes to the
bibliographic frameworks:

Changes are not reflected immediately, but only after restarting the memcache
server. This is a problem, because often you want to configure and immediately
check if your changes are correct by refreshing the cataloging screen. At the
moment this is really confusing. I am not sure when or if the cache would be
updated without restarting memcache.

To reproduce:
1) Open cataloguing default framework
2) Change bibliographic framework, for example: set 773$a hidden value from -6
to 0
3) Refresh cataloguing page > change and 773 will not be visible
4) Restart memcache > change will be visible

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432

Chris Cormack <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P1 - high
             Status|NEW                         |ASSIGNED
                 CC|                            |[hidden email]
           Severity|normal                      |critical

--- Comment #1 from Chris Cormack <[hidden email]> 2012-02-02 23:32:53 UTC ---
This is a bug in the way we are using memoize_memcached

I will do patches to fix it in all the places we use it.

The first one will be for C4/Biblio and will show what we are doing wrong.

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432

--- Comment #2 from Chris Cormack <[hidden email]> 2012-02-02 23:36:24 UTC ---
Now they will only be cached for 10 mins max, so will reflect the change
without needing a restart. I will do this for all instances of
memoize_memcached and attach them here.

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432

--- Comment #3 from Chris Cormack <[hidden email]> 2012-02-02 23:36:54 UTC ---
Created attachment 7426
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7426
Bug 7432 : Fix how we are setting expiry time when caching

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432

Chris Cormack <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432

--- Comment #4 from Chris Cormack <[hidden email]> 2012-02-02 23:41:17 UTC ---
Created attachment 7427
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7427
Bug 7432 : Fixing caching for SQLHelper

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432

Chris Cormack <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7427|0                           |1
        is obsolete|                            |

--- Comment #5 from Chris Cormack <[hidden email]> 2012-02-02 23:43:13 UTC ---
Created attachment 7428
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7428
Bug 7432 : Fixing caching for SQLHelper

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432

--- Comment #6 from Chris Cormack <[hidden email]> 2012-02-02 23:44:51 UTC ---
Created attachment 7429
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7429
Bug 7432 : Fixing caching for C4::Languages

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432

--- Comment #7 from Ian Walls <[hidden email]> 2012-02-03 23:48:55 UTC ---
Looks like all these patches fold the expire_time into the memcached hash,
instead of as as separate param to memoize_memcached().  That's what's expected
by the function according to CPAN, so I think this is a valid change.

Chris, your commit messages for these changes pretty empty. Could you provide a
 test plan so we can confirm this is working as expected?

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432

--- Comment #8 from Chris Cormack <[hidden email]> 2012-02-04 00:59:30 UTC ---
(In reply to comment #7)
> Looks like all these patches fold the expire_time into the memcached hash,
> instead of as as separate param to memoize_memcached().  That's what's expected
> by the function according to CPAN, so I think this is a valid change.
>
> Chris, your commit messages for these changes pretty empty. Could you provide a
>  test plan so we can confirm this is working as expected?

Seriously?

Ok, switch on caching, go to cataloguing, pick a framework, look at it. Change
the framework, check it again, it wont have have changed in cataloguing. Wait
10 minutes look again.

Currently it never ever changes unless you restart memcached.

Katrin already has the test plan, use that, except that after 10 minutes the
change will show instead of having to restart memcached.

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432

Jared Camins-Esakov <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7426|0                           |1
        is obsolete|                            |

--- Comment #9 from Jared Camins-Esakov <[hidden email]> 2012-02-12 19:09:47 UTC ---
Created attachment 7585
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7585
Bug 7432 : Fix how we are setting expiry time when caching

Signed-off-by: Jared Camins-Esakov <[hidden email]>

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432

Jared Camins-Esakov <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7428|0                           |1
        is obsolete|                            |

--- Comment #10 from Jared Camins-Esakov <[hidden email]> 2012-02-12 19:10:06 UTC ---
Created attachment 7586
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7586
Bug 7432 : Fixing caching for SQLHelper

Signed-off-by: Jared Camins-Esakov <[hidden email]>

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432

Jared Camins-Esakov <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7429|0                           |1
        is obsolete|                            |

--- Comment #11 from Jared Camins-Esakov <[hidden email]> 2012-02-12 19:10:19 UTC ---
Created attachment 7587
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7587
Bug 7432 : Fixing caching for C4::Languages

Signed-off-by: Jared Camins-Esakov <[hidden email]>

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432

Jared Camins-Esakov <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |[hidden email]

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432

Paul Poulain <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #12 from Paul Poulain <[hidden email]> 2012-02-15 09:38:04 UTC ---
2 patches set
> expire_time => 600
saying it's 10mn
One patch (http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7586) set
> expire_time => 600000
also saying it's 10mn

I suspect the 60000 is a bug, marking failed QA: pls explain or follow-up, thx
(I tried to dig into Cache::Memcached documentation, and found:

The $exptime (expiration time) defaults to "never" if unspecified.  If you want
the key to expire in memcached, pass an integer $exptime.  If value is less
than 60*60*24*30 (30 days), time is assumed to be relative from the present.
If larger, it's considered an absolute Unix time.

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432

Chris Cormack <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #13 from Chris Cormack <[hidden email]> 2012-02-15 09:41:18 UTC ---
Yes the 60000 is a bug, thats why i changed it to 600 (someone elses patch had
set it to 60000 so i fixed it while fixing the fact it was set in the wrong
place)

If you look carefully this patch is changing it from 60000 to 600.

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432

Paul Poulain <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #14 from Paul Poulain <[hidden email]> 2012-02-15 09:45:44 UTC ---
OK, /me must change his glasses...

passed QA

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7432

Paul Poulain <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_6

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/