[Bug 7127] New: Templates must be valid XHTML

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

             Bug #: 7127
           Summary: Templates must be valid XHTML
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: master
          Platform: All
        OS/Version: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5
         Component: Templates
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]
         QAContact: [hidden email]


All templates should be valid XHTML. I'm finding many new instances of
unescaped ampersands which need to be corrected.

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

--- Comment #1 from Owen Leonard <[hidden email]> 2011-11-18 19:11:55 UTC ---
Created attachment 6342
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6342
Proposed fix

Escaping ampersands.

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |PATCH-Sent
       Patch Status|---                         |Needs Signoff

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

Chris Cormack <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6342|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack <[hidden email]> 2011-12-11 00:26:43 UTC ---
Created attachment 6702
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6702
Bug 7127 - Templates must be valid XHTML

Signed-off-by: Chris Cormack <[hidden email]>

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

Chris Cormack <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
       Patch Status|Needs Signoff               |Signed Off

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

Paul Poulain <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Paul Poulain <[hidden email]> 2011-12-13 16:53:16 UTC ---
QA comment:
* how to prove the validity of XHTML ? Is there a jenkin test for that ?

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

M. de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
       Patch Status|Signed Off                  |Passed QA
          QAContact|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--- Comment #4 from M. de Rooy <[hidden email]> 2012-01-10 15:21:34 UTC ---
QA: Looks good. Updating status..

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

Paul Poulain <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
       Patch Status|Passed QA                   |Failed QA

--- Comment #5 from Paul Poulain <[hidden email]> 2012-01-13 10:49:47 UTC ---
QA comment

Chris = is there a unit test for XHTML validity ?

+ merge problem:
Applying: Bug 7127 - Templates must be valid XHTML
/home/paul/koha.dev/koha-community/.git/rebase-apply/patch:64: space before tab
in indent.
                              <a
href="/cgi-bin/koha/catalogue/search.pl?idx=hi&amp;q=[% itemloo.itemnumber
%]">[% itemloo.countanalytics %] analytics</a>
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
<stdin>:64: space before tab in indent.
                              <a
href="/cgi-bin/koha/catalogue/search.pl?idx=hi&amp;q=[% itemloo.itemnumber
%]">[% itemloo.countanalytics %] analytics</a>
warning: 1 line applied after fixing whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
Failed to merge in the changes.
Patch failed at 0001 Bug 7127 - Templates must be valid XHTML

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6702|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <[hidden email]> 2012-01-13 16:04:55 UTC ---
Created attachment 7140
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7140
Revised for current master

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
       Patch Status|Failed QA                   |Needs Signoff

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

--- Comment #7 from Owen Leonard <[hidden email]> 2012-01-26 20:12:26 UTC ---
Created attachment 7339
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7339
Bug 7127 - Follow-up - Templates must be valid XHTML

Corrections to OPAC search results and lists pages for validity
errors: duplicate ids, invalidly placed elements, unescaped
ampersands.

The change to localcovers.js adds a check for <span> in addition
to <div> so that the results template can use a <span>

The <form> tag has been removed from the inline tag entry
markup in order to correct a display error in Internet Explorer 8.
Removing it doesn't affect functionality or validity.

To test: Validate the HTML of the OPAC results page and an OPAC
list contents page (/cgi-bin/koha/opac-shelves.pl?viewshelf=XX).
Verify the functinality of adding tags on both pages with the
TagsInputOnList system preference enabled. Verify that local
cover images are display on search results and detail pages.

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|PATCH-Sent (DO NOT USE)     |P5 - low

--- Comment #8 from Owen Leonard <[hidden email]> 2012-01-26 20:14:06 UTC ---
Attachment 7339 can be applied and tested independently of attachment 7140.

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |7452

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

--- Comment #9 from Owen Leonard <[hidden email]> 2012-01-26 20:27:46 UTC ---
Attachment 7339 should also fix Bug 7452.

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

Ian Walls <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7140|0                           |1
        is obsolete|                            |

--- Comment #10 from Ian Walls <[hidden email]> 2012-02-03 12:59:15 UTC ---
Created attachment 7444
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7444
Signed off Patch

First patch successfully removes numerous & in templates in favour of &amp;.

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

Ian Walls <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |[hidden email]

--- Comment #11 from Ian Walls <[hidden email]> 2012-02-03 13:00:17 UTC ---
Second patch double |html filters on page-numbers.inc; while this may be
benign, it won't pass QA.

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

Ian Walls <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #12 from Ian Walls <[hidden email]> 2012-02-03 13:01:09 UTC ---
Marking Passed QA for signed off patch only, since it's a safe template-only
change.

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7339|0                           |1
        is obsolete|                            |

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

--- Comment #13 from Owen Leonard <[hidden email]> 2012-02-03 13:39:08 UTC ---
Created attachment 7446
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7446
Bug 7127 - Follow-up - Templates must be valid XHTML

Corrections to OPAC search results and lists pages for validity
errors: duplicate ids, invalidly placed elements, unescaped
ampersands.

The change to localcovers.js adds a check for <span> in addition
to <div> so that the results template can use a <span>

The <form> tag has been removed from the inline tag entry
markup in order to correct a display error in Internet Explorer 8.
Removing it doesn't affect functionality or validity.

To test: Validate the HTML of the OPAC results page and an OPAC
list contents page (/cgi-bin/koha/opac-shelves.pl?viewshelf=XX).
Verify the functinality of adding tags on both pages with the
TagsInputOnList system preference enabled. Verify that local
cover images are display on search results and detail pages.

Includes fixes for errors spotted by QA

Revisions

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

--- Comment #14 from Paul Poulain <[hidden email]> 2012-02-03 13:54:56 UTC ---
i'm not sure what to do with those patches. Should I push the 1st and reset
status to need signoff?

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

--- Comment #15 from Ian Walls <[hidden email]> 2012-02-03 23:39:56 UTC ---
Created attachment 7456
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7456
[SIGNED OFF] Bug 7127 - Follow-up - Templates must be valid XHTML

Corrections to OPAC search results and lists pages for validity
errors: duplicate ids, invalidly placed elements, unescaped
ampersands.

The change to localcovers.js adds a check for <span> in addition
to <div> so that the results template can use a <span>

The <form> tag has been removed from the inline tag entry
markup in order to correct a display error in Internet Explorer 8.
Removing it doesn't affect functionality or validity.

To test: Validate the HTML of the OPAC results page and an OPAC
list contents page (/cgi-bin/koha/opac-shelves.pl?viewshelf=XX).
Verify the functinality of adding tags on both pages with the
TagsInputOnList system preference enabled. Verify that local
cover images are display on search results and detail pages.

Includes fixes for errors spotted by QA

Revisions

Signed-off-by: Ian Walls <[hidden email]>

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

Ian Walls <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7446|0                           |1
        is obsolete|                            |

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

--- Comment #16 from Ian Walls <[hidden email]> 2012-02-03 23:40:59 UTC ---
Signed off and Passed QA on followup: both attached patches can now be
committed.

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

Paul Poulain <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #17 from Owen Leonard <[hidden email]> 2012-02-17 15:08:24 UTC ---
*** Bug 7452 has been marked as a duplicate of this bug. ***

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/