[Bug 7042] New: Improving cleanup_database.pl: handling quotes in a_session and interpreting sessdays parameter

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 7042] New: Improving cleanup_database.pl: handling quotes in a_session and interpreting sessdays parameter

bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7042

             Bug #: 7042
           Summary: Improving cleanup_database.pl: handling quotes in
                    a_session and interpreting sessdays parameter
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: master
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P5
         Component: Command-line Utilities
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]
         QAContact: [hidden email]


Improving the cleanup_database.pl script in two aspects:
1) In some cases CGI::Session seems to place quotes around the atime and ctime
data in the a_session field. Two regexps now take this into account.
2) If the --sessdays parameter is used, the --sessions parameter is now
implicitly enabled too.

With thanks to Ian Bays and Tom Hanstra.

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 7042] Improving cleanup_database.pl: handling quotes in a_session and interpreting sessdays parameter

bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7042

--- Comment #1 from M. de Rooy <[hidden email]> 2011-10-17 09:48:54 UTC ---
Created attachment 5919
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5919
Patch

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 7042] Improving cleanup_database.pl: handling quotes in a_session and interpreting sessdays parameter

bugzilla-daemon
In reply to this post by bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7042

M. de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5                          |PATCH-Sent
             Status|NEW                         |ASSIGNED
       Patch Status|---                         |Needs Signoff
         AssignedTo|[hidden email]          |[hidden email]

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 7042] Improving cleanup_database.pl: handling quotes in a_session and interpreting sessdays parameter

bugzilla-daemon
In reply to this post by bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7042

Ian Bays <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5919|0                           |1
        is obsolete|                            |

--- Comment #2 from Ian Bays <[hidden email]> 2011-10-20 08:20:19 UTC ---
Created attachment 6006
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6006
Sign-off patch

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 7042] Improving cleanup_database.pl: handling quotes in a_session and interpreting sessdays parameter

bugzilla-daemon
In reply to this post by bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7042

Ian Bays <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
       Patch Status|Needs Signoff               |Signed Off

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 7042] Improving cleanup_database.pl: handling quotes in a_session and interpreting sessdays parameter

bugzilla-daemon
In reply to this post by bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7042

--- Comment #3 from M. de Rooy <[hidden email]> 2011-10-20 08:22:25 UTC ---
(In reply to comment #2)
> Created attachment 6006 [details]
> Sign-off patch

Great!

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 7042] Improving cleanup_database.pl: handling quotes in a_session and interpreting sessdays parameter

bugzilla-daemon
In reply to this post by bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7042

Ian Walls <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ian.walls@bywatersolutions.
                   |                            |com
       Patch Status|Signed Off                  |Passed QA

--- Comment #4 from Ian Walls <[hidden email]> 2011-10-20 13:15:38 UTC ---
Makes commandline too more flexible (quotes are regexed with ?, so all previous
matches will continue, and new ones can be detected), and more intuitive (don't
have to specify two params for sessions).  Marking as Passed QA.

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 7042] Improving cleanup_database.pl: handling quotes in a_session and interpreting sessdays parameter

bugzilla-daemon
In reply to this post by bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7042

Chris Cormack <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
       Patch Status|Passed QA                   |Patch Pushed

--- Comment #5 from Chris Cormack <[hidden email]> 2011-10-20 15:42:45 UTC ---
Excellent work, pushed

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 7042] Improving cleanup_database.pl: handling quotes in a_session and interpreting sessdays parameter

bugzilla-daemon
In reply to this post by bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7042

M. de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/