[Bug 6875] de-nesting C4 packages

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[Bug 6875] de-nesting C4 packages


Jared Camins-Esakov <[hidden email]> changed:

           What    |Removed                     |Added
             Status|Needs Signoff               |Signed Off
                 CC|                            |[hidden email]

--- Comment #39 from Jared Camins-Esakov <[hidden email]> 2012-01-28 14:44:46 UTC ---
I tested and signed off on the following patches:
De-nesting Auth.pm
De-nesting C4::Koha.pm
Cleaning mainpage.pl
Cleaning opac-main.pl
De-nesting C4/Serials
De-nesting C4::Heading
De-nesting C4::VirtualShelves

The code in those patches is pretty clean.

Three patches would not apply:
De-nesting C4::Biblio
De-nesting C4::Items
Cleaning opac-detail.pl

One patch fails QA on account of breaking circulation:
De-nesting C4::Member

I would like to encourage the QA team to review the patches that I signed off
on so that they can be pushed to Master, rather than waiting for revised
patches for the four that I didn't sign off on. Removing unnecessary
dependencies is a result greatly to be desired.

Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.
Koha-bugs mailing list
[hidden email]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/