[Bug 5260] It would be nice if Koha's Acquisition module could order by email

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[Bug 5260] It would be nice if Koha's Acquisition module could order by email


Paul Poulain <[hidden email]> changed:

           What    |Removed                     |Added
                 CC|                            |[hidden email]
       Patch Status|Needs Signoff               |Does not apply

--- Comment #9 from Paul Poulain <[hidden email]> 2011-09-27 15:43:33 UTC ---
Edgar, your patch does not seems to be in git format
a git patch starts with :
(for example)
From 1b633c25236c62d43e938dac02f01897ba073747 Mon Sep 17 00:00:00 2001
From: Chris Cormack <[hidden email]>
Date: Tue, 10 May 2011 09:30:06 +1200
Subject: [PATCH] Bug 5260 : Patch for template changes

your revised patch #4781 starts by :
diff --git a/acqui/basketgroup.pl b/acqui/basketgroup.pl
index 08356f8..4a4a9f2 100755
--- a/acqui/basketgroup.pl
+++ b/acqui/basketgroup.pl

QA comment:
I also see that there are many commented warns or print, like
+#print "order_mail\n";
+#print "booksellerid: $booksellerid\n", "mail_orders: ", Dumper($mail_orders);

could you remove them before submitting, otherwise it will "fail QA" later


Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
Koha-bugs mailing list
[hidden email]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/