[Bug 27948] New: Add disclaimer text to article requests feature

classic Classic list List threaded Threaded
30 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] New: Add disclaimer text to article requests feature

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

            Bug ID: 27948
           Summary: Add disclaimer text to article requests feature
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]

Similar to  ILLModuleCopyrightClearance  this feature will allow for including
text about article request availability

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
  Change sponsored?|---                         |Sponsored

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

Agustín Moyano <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

--- Comment #1 from Agustín Moyano <[hidden email]> ---
Created attachment 121439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121439&action=edit
Bug 27948: Add atomic update

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

--- Comment #2 from Agustín Moyano <[hidden email]> ---
Created attachment 121440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121440&action=edit
Bug 27948: Add ArticleRequestsDisclaimerText syspref

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

--- Comment #3 from Agustín Moyano <[hidden email]> ---
Created attachment 121441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121441&action=edit
Bug 27948: Add disclaimer to article request

If ArticleRequestsDisclaimerText syspref is set, a disclaimer text will appear
fefore an article request can be made

To test:
1. apply patches
2. enable ArticleRequest syspref
3. in OPAC place an article request for a patron
CHECK => No disclaimer text should appear before placing article request
4. add a text in ArticleRequestsDisclaimerText syspref
5. repeat step 3
SUCCESS => A disclaimer text is shown before you can place an article request

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

David Nind <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

David Nind <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #121439|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <[hidden email]> ---
Created attachment 121505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121505&action=edit
Bug 27948: Add atomic update

Signed-off-by: David Nind <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

David Nind <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #121440|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <[hidden email]> ---
Created attachment 121506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121506&action=edit
Bug 27948: Add ArticleRequestsDisclaimerText syspref

Signed-off-by: David Nind <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

David Nind <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #121441|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <[hidden email]> ---
Created attachment 121507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121507&action=edit
Bug 27948: Add disclaimer to article request

If ArticleRequestsDisclaimerText syspref is set, a disclaimer text will appear
fefore an article request can be made

To test:
1. apply patches
2. enable ArticleRequest syspref
3. in OPAC place an article request for a patron
CHECK => No disclaimer text should appear before placing article request
4. add a text in ArticleRequestsDisclaimerText syspref
5. repeat step 3
SUCCESS => A disclaimer text is shown before you can place an article request

Signed-off-by: David Nind <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

David Nind <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement lets you
      release notes|                            |include text that patrons
                   |                            |need to accept before they
                   |                            |can place an article
                   |                            |request (similar to the
                   |                            |ILLModuleCopyrightClearance
                   |                            |system preference).
                   |                            |
                   |                            |Add
                   |                            |the text required to the
                   |                            |new system preference
                   |                            |ArticleRequestsDisclaimerTe
                   |                            |xt. If there is no text in
                   |                            |the system preference, then
                   |                            |no message is displayed.
                   |                            |
                   |                            |,
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This enhancement lets you   |This enhancement lets you
      release notes|include text that patrons   |include text that patrons
                   |need to accept before they  |need to accept before they
                   |can place an article        |can place an article
                   |request (similar to the     |request (similar to the
                   |ILLModuleCopyrightClearance |ILLModuleCopyrightClearance
                   |system preference).       |system preference).
                   |                           |
                   |Add                         |Add
                   |the text required to the    |the text required to the
                   |new system preference       |new system preference
                   |ArticleRequestsDisclaimerTe |ArticleRequestsDisclaimerTe
                   |xt. If there is no text in  |xt. If there is no text in
                   |the system preference, then |the system preference, then
                   |no message is displayed.   |no message is displayed.
                   |                           |
                   |,                           |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #7 from Katrin Fischer <[hidden email]> ---
Hi Agustin,
we have started moving the HTML system preferences into the news system as this
allows to have translated versions of the text. i know this was modeled after
the ILLModuleCopyrightClearance that hasn't been moved yet, but would you
consider following the new pattern here?

opacheader would be an example.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

Agustín Moyano <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

Agustín Moyano <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #121505|0                           |1
        is obsolete|                            |
 Attachment #121506|0                           |1
        is obsolete|                            |
 Attachment #121507|0                           |1
        is obsolete|                            |

--- Comment #8 from Agustín Moyano <[hidden email]> ---
Created attachment 122053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122053&action=edit
Bug 27948: Add disclaimer to article request

If ArticleRequestsDisclaimerText news is set, a disclaimer text will appear
before an article request can be made

To test:
1. apply patches
2. enable ArticleRequest syspref
3. in OPAC place an article request for a patron
CHECK => No disclaimer text should appear before placing article request
4. add a text in ArticleRequestsDisclaimerText news
5. repeat step 3
SUCCESS => A disclaimer text is shown before you can place an article request

Signed-off-by: David Nind <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

Agustín Moyano <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This enhancement lets you   |This enhancement lets you
      release notes|include text that patrons   |include text that patrons
                   |need to accept before they  |need to accept before they
                   |can place an article        |can place an article
                   |request (similar to the     |request (similar to the
                   |ILLModuleCopyrightClearance |ILLModuleCopyrightClearance
                   |system preference).       |system preference).
                   |                           |
                   |Add                         |Add
                   |the text required to the    |the text required to the
                   |new system preference       |new
                   |ArticleRequestsDisclaimerTe |ArticleRequestsDisclaimerTe
                   |xt. If there is no text in  |xt entry in the news tool.
                   |the system preference, then |
                   |no message is displayed.    |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

--- Comment #9 from Marcel de Rooy <[hidden email]> ---
Could not compile /usr/share/koha/opac/opac-request-article.pl: Bareword
"action" not allowed while "strict subs" in use at
/usr/share/koha/opac/opac-request-article.pl line 49.

How did you test that, Agustin? :)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

--- Comment #10 from Marcel de Rooy <[hidden email]> ---
Why not use a construction like:

[% PROCESS koha_news_block news => KohaNews.get({ location =>
'ArticleRequestsDisclaimerText', lang => lang, library => branchcode,
blocktitle => 0 }) %]

This is used in other places too to insert text block from news.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|[hidden email]-communit |[hidden email]
                   |y.org                       |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

Agustín Moyano <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122053|0                           |1
        is obsolete|                            |

--- Comment #11 from Agustín Moyano <[hidden email]> ---
Created attachment 122132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122132&action=edit
Bug 27948: Add disclaimer to article request

If ArticleRequestsDisclaimerText news is set, a disclaimer text will appear
before an article request can be made

To test:
1. apply patches
2. enable ArticleRequest syspref
3. in OPAC place an article request for a patron
CHECK => No disclaimer text should appear before placing article request
4. add a text in ArticleRequestsDisclaimerText news
5. repeat step 3
SUCCESS => A disclaimer text is shown before you can place an article request

Signed-off-by: David Nind <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

Agustín Moyano <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

Agustín Moyano <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122132|0                           |1
        is obsolete|                            |

--- Comment #12 from Agustín Moyano <[hidden email]> ---
Created attachment 122134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122134&action=edit
Bug 27948: Add disclaimer to article request

If ArticleRequestsDisclaimerText news is set, a disclaimer text will appear
before an article request can be made

To test:
1. apply patches
2. enable ArticleRequest syspref
3. in OPAC place an article request for a patron
CHECK => No disclaimer text should appear before placing article request
4. add a text in ArticleRequestsDisclaimerText news
5. repeat step 3
SUCCESS => A disclaimer text is shown before you can place an article request

Signed-off-by: David Nind <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

--- Comment #13 from Agustín Moyano <[hidden email]> ---
(In reply to Marcel de Rooy from comment #9)
> Could not compile /usr/share/koha/opac/opac-request-article.pl: Bareword
> "action" not allowed while "strict subs" in use at
> /usr/share/koha/opac/opac-request-article.pl line 49.
>
> How did you test that, Agustin? :)

Sorry, moved the if from the end of line to a proper if statement and forgot $

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

--- Comment #14 from Agustín Moyano <[hidden email]> ---
(In reply to Marcel de Rooy from comment #10)
> Why not use a construction like:
>
> [% PROCESS koha_news_block news => KohaNews.get({ location =>
> 'ArticleRequestsDisclaimerText', lang => lang, library => branchcode,
> blocktitle => 0 }) %]
>
> This is used in other places too to insert text block from news.

Basically that construction does not allow for you to have a default language.

If you add a disclaimer in english, but you do not have it in other languages,
users with english lang will see the disclaimer text, but other users will not.

With the construction I coded, it first checks for a disclaimer text in the
language of the template, and if not found, uses english as default.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

--- Comment #15 from Katrin Fischer <[hidden email]> ---
Hi Augustin,
I think we should not hardcode a fallback to English and it would be not
correct with the other behaviour in Koha, like the templating system.

Actually I think the fallback is usually to the first language in the list I
think which is why you can reorder them?

Maybe adding a fallback/default should be a separate bug - In general I agree
it would be nice to have one in general. Bug 24766 might be related.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27948] Add disclaimer text to article requests feature

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/