[Bug 27170] New: ILL availability should be able to display arbitrary links to related resources

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 27170] New: ILL availability should be able to display arbitrary links to related resources

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

            Bug ID: 27170
           Summary: ILL availability should be able to display arbitrary
                    links to related resources
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

Currently, ILL availability uses the API response from the plugin to form a
link if an item response contains a 'url' property. This is quite limiting. The
EDS API, for example, can return multiple potential links to a resource.

I am updating the EDS availability plugin to allow it to return an arbitrary
number of links to a resource in a new 'links' property. This bug will add
support for that property and will form links as appropriate.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27170] ILL availability should be able to display arbitrary links to related resources

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |andrew.isherwood@ptfs-europ
                   |ity.org                     |e.com

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27170] ILL availability should be able to display arbitrary links to related resources

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

--- Comment #1 from Andrew Isherwood <[hidden email]> ---
Created attachment 114256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114256&action=edit
Bug 27170: Add support for new 'links' property

This commit adds support for the new 'links' property that will allow an
availability plugin to return an array of links for a result. These
links are parsed and appended to the title field of a results record.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27170] ILL availability should be able to display arbitrary links to related resources

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #2 from Andrew Isherwood <[hidden email]> ---
Test plan:

- Apply the bug
- Enable ILL in Koha and install the FreeForm backend
- Enable plugins
- Install and configure the ILL EDS availability plugin version 1.0.7
(https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds/tags/1.0.7)
- Create an ILL request
- TEST: On the availability screen, note that no links are displayed with the
record title other than the link
- Install and configure at least version 1.1.0  of the ILL EDS availability
plugin
(https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds/releases/latest)
- Create an ILL request
- TEST: On the availability screen, note that links are now displayed with the
record title other than the link

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27170] ILL availability should be able to display arbitrary links to related resources

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

--- Comment #3 from Andrew Isherwood <[hidden email]> ---
Test plan:

- Apply the bug
- Enable ILL in Koha and install the FreeForm backend
- Enable plugins
- Install and configure the ILL EDS availability plugin version 1.0.7
(https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds/releases/tag/1.0.7)
- Create an ILL request
- TEST: On the availability screen, note that no links are displayed with the
record title other than the link
- Install and configure at least version 1.1.0  of the ILL EDS availability
plugin
(https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds/releases/latest)
- Create an ILL request
- TEST: On the availability screen, note that links are now displayed with the
record title other than the link

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27170] ILL availability should be able to display arbitrary links to related resources

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|[hidden email]-communit |
                   |y.org                       |
          Component|I18N/L10N                   |ILL

--- Comment #4 from Andrew Isherwood <[hidden email]> ---
Fixed bug component selection, I had mis-selected "I18n/L10N"

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27170] ILL availability should be able to display arbitrary links to related resources

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

Niamh Walker-Headon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27170] ILL availability should be able to display arbitrary links to related resources

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

Janet McGowan <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |om

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27170] ILL availability should be able to display arbitrary links to related resources

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114256|0                           |1
        is obsolete|                            |

--- Comment #5 from Andrew Isherwood <[hidden email]> ---
Created attachment 122112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122112&action=edit
Bug 27170: Add support for new 'links' property

This commit adds support for the new 'links' property that will allow an
availability plugin to return an array of links for a result. These
links are parsed and appended to the title field of a results record.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27170] ILL availability should be able to display arbitrary links to related resources

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

--- Comment #6 from Andrew Isherwood <[hidden email]> ---
Created attachment 122113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122113&action=edit
Bug 27170: Fix bug with undefined 'links'

If a row object doesn't have a 'links' property, calling 'length' on it
will fail. This commit fixes this.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27170] ILL availability should be able to display arbitrary links to related resources

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122112|0                           |1
        is obsolete|                            |

--- Comment #7 from Andrew Isherwood <[hidden email]> ---
Created attachment 122114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122114&action=edit
Bug 27170: Add support for new 'links' property

This commit adds support for the new 'links' property that will allow an
availability plugin to return an array of links for a result. These
links are parsed and appended to the title field of a results record.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27170] ILL availability should be able to display arbitrary links to related resources

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122113|0                           |1
        is obsolete|                            |

--- Comment #8 from Andrew Isherwood <[hidden email]> ---
Created attachment 122115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122115&action=edit
Bug 27170: Fix bug with undefined 'links'

If a row object doesn't have a 'links' property, calling 'length' on it
will fail. This commit fixes this.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27170] ILL availability should be able to display arbitrary links to related resources

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

--- Comment #9 from Andrew Isherwood <[hidden email]> ---
Created attachment 122117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122117&action=edit
Bug 27170: Fix bug fix

<sigh> This commit fixes the incorrect bug fix from the previous commit

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27170] ILL availability should be able to display arbitrary links to related resources

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122114|0                           |1
        is obsolete|                            |

--- Comment #10 from Andrew Isherwood <[hidden email]> ---
Created attachment 122167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122167&action=edit
Bug 27170: Add support for new 'links' property

This commit adds support for the new 'links' property that will allow an
availability plugin to return an array of links for a result. These
links are parsed and appended to the title field of a results record.

Signed-off-by: Holly Cooper <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27170] ILL availability should be able to display arbitrary links to related resources

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122115|0                           |1
        is obsolete|                            |

--- Comment #11 from Andrew Isherwood <[hidden email]> ---
Created attachment 122168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122168&action=edit
Bug 27170: Fix bug with undefined 'links'

If a row object doesn't have a 'links' property, calling 'length' on it
will fail. This commit fixes this.

Signed-off-by: Holly Cooper <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27170] ILL availability should be able to display arbitrary links to related resources

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122117|0                           |1
        is obsolete|                            |

--- Comment #12 from Andrew Isherwood <[hidden email]> ---
Created attachment 122169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122169&action=edit
Bug 27170: Fix bug fix

<sigh> This commit fixes the incorrect bug fix from the previous commit

Signed-off-by: Holly Cooper <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 27170] ILL availability should be able to display arbitrary links to related resources

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/