[Bug 25744] New: a11y: Replace <i> tags with <em> AND <b> tags with <strong> everywhere

classic Classic list List threaded Threaded
16 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 25744] New: a11y: Replace <i> tags with <em> AND <b> tags with <strong> everywhere

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744

            Bug ID: 25744
           Summary: a11y: Replace <i> tags with <em> AND <b> tags with
                    <strong> everywhere
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

bug 22672 is for the OPAC, this is for the rest.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672#c0
Lucas Gass:
> Since screen readers typically ignore <i> and <b> tags. Instead we should
> use <em> and <strong> tags which look the same visually but are more
> meaningful from an accessibility standpoint.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25744] a11y: Replace <i> tags with <em> AND <b> tags with <strong> everywhere

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744

Victor Grousset/tuxayo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25744] Replace <i> tags with <em> AND <b> tags with <strong> in the staff interface

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22672
            Summary|a11y: Replace <i> tags with |Replace <i> tags with <em>
                   |<em> AND <b> tags with      |AND <b> tags with <strong>
                   |<strong> everywhere         |in the staff interface

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25744] Replace <i> tags with <em> AND <b> tags with <strong> in the staff interface

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744

Lucas Gass <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25744] Replace <i> tags with <em> AND <b> tags with <strong> in the staff interface

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744

--- Comment #2 from Lucas Gass <[hidden email]> ---
Created attachment 107903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107903&action=edit
Bug 25744: Replace <i> with <em> in staff interface

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25744] Replace <i> tags with <em> AND <b> tags with <strong> in the staff interface

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744

Lucas Gass <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25744] Replace <i> tags with <em> AND <b> tags with <strong> in the staff interface

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744

--- Comment #3 from Lucas Gass <[hidden email]> ---
Created attachment 107906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107906&action=edit
Bug 25744: replace <b> with <strong> in the staff interface

This patch set attempts to replace all the <i> tags with <em> and all the <b>
tags with <strong> in the staff interface.
I attempted to get all the templates, includes, and xslt files.
To test:
1. Review the changes as best as possible, looking for mistakes.
2. grep for <i> and <b> in the modules, includes, and xslt folders. You should
get nothing/
3. If you grep '<\/i>' you should only see instances of Font Awesome.
4. If you grep '<\/b>' you should only see instances where caret is used.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25744] Replace <i> tags with <em> AND <b> tags with <strong> in the staff interface

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744

--- Comment #4 from Lucas Gass <[hidden email]> ---
This patch modifies the following files:

replaced <i> with <em> in these file:

includes/borrower_debarments.inc
includes/holds_table.inc
includes/patron-article-requests.inc
includes/permissions.inc
modules/acqui/lateorders.tt
modules/acqui/newordersuggestion.tt
modules/acqui/parcel.tt
modules/admin/aqbudgetperiods.tt
modules/admin/aqcontract.tt
modules/admin/auth_subfields_structure.tt
modules/admin/categories.tt
modules/admin/marc_subfields_structure.tt
modules/admin/preferences/cataloguing.pref
modules/admin/preferences/searching.pref
modules/catalogue/MARCdetail.tt
modules/catalogue/detail.tt
modules/catalogue/imageviewer.tt
modules/catalogue/issuehistory.tt
modules/catalogue/labeledMARCdetail.tt
modules/catalogue/moredetail.tt
modules/catalogue/stockrotation.tt
modules/cataloguing/addbooks.tt
modules/cataloguing/linkitem.tt
modules/cataloguing/moveitem.tt
modules/circ/circulation.tt
modules/circ/pendingreserves.tt
modules/clubs/club-enrollments.tt
modules/clubs/clubs-add-modify.tt
modules/clubs/clubs.tt
modules/clubs/patron-enroll.tt
modules/clubs/templates-add-modify.tt
modules/course_reserves/add_items-step1.tt
modules/course_reserves/add_items-step2.tt
modules/course_reserves/batch_add_items.tt
modules/course_reserves/course-details.tt
modules/course_reserves/course.tt
modules/members/memberentrygen.tt
modules/members/moremember.tt
modules/plugins/plugins-home.tt
modules/reserve/request.tt
modules/rotating_collections/addItems.tt
modules/rotating_collections/editCollections.tt
modules/rotating_collections/transferCollection.tt
modules/serials/routing-preview.tt
modules/serials/routing.tt
modules/serials/serials-collection.tt
modules/serials/serials-edit.tt
modules/serials/subscription-add.tt
modules/serials/subscription-detail.tt
modules/serials/viewalerts.tt
modules/suggestion/suggestion.tt
modules/tags/list.tt
modules/tools/marc_modification_templates.tt
modules/virtualshelves/shelves.tt



Replaced <b> with <strong> in these files:
includes/budgets-active-currency.inc
includes/cateditor-ui.inc
includes/checkouts-table.inc
includes/holds_table.inc
includes/waiting_holds.inc
modules/about.tt
modules/acqui/invoice-files.tt
modules/acqui/lateorders.tt
modules/acqui/neworderempty.tt
modules/acqui/orderreceive.tt
modules/admin/aqplan.tt
modules/admin/auth_tag_structure.tt
modules/admin/checkmarc.tt
modules/admin/itemtypes.tt
modules/admin/preferences/i18n_l10n.pref
modules/authorities/detail.tt
modules/authorities/searchresultlist-auth.tt
modules/basket/basket.tt
modules/catalogue/MARCdetail.tt
modules/catalogue/issuehistory.tt
modules/catalogue/labeledMARCdetail.tt
modules/cataloguing/addbooks.tt
modules/cataloguing/value_builder/unimarc_field_210c.tt
modules/circ/branchoverdues.tt
modules/circ/branchtransfers.tt
modules/circ/circulation.tt
modules/circ/pendingreserves.tt
modules/circ/reserveratios.tt
modules/circ/returns.tt
modules/circ/transferstoreceive.tt
modules/ill/log/status_change.tt
modules/labels/result.tt
modules/members/paycollect.tt
modules/onboarding/onboardingstep1.tt
modules/onboarding/onboardingstep2.tt
modules/onboarding/onboardingstep3.tt
modules/plugins/plugins-upload.tt
modules/pos/pay.tt
modules/reports/acquisitions_stats.tt
modules/reports/guided_reports_start.tt
modules/reviews/reviewswaiting.tt
modules/serials/checkexpiration.tt
modules/serials/result.tt
modules/serials/routing-preview-slip.tt
modules/suggestion/suggestion.tt
modules/tools/export.tt
modules/tools/holidays.tt
modules/tools/import_borrowers.tt
modules/tools/letter.tt
modules/tools/manage-marc-import.tt
modules/tools/picture-upload.tt
modules/tools/problem-reports.tt
modules/tools/quotes.tt
modules/tools/upload-images.tt

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25744] Replace <i> tags with <em> AND <b> tags with <strong> in the staff interface

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Medium patch

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25744] Replace <i> tags with <em> AND <b> tags with <strong> in the staff interface

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107903|0                           |1
        is obsolete|                            |
 Attachment #107906|0                           |1
        is obsolete|                            |

--- Comment #5 from Owen Leonard <[hidden email]> ---
Created attachment 109758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109758&action=edit
Bug 25744: Replace <i> with <em> in staff interface

Signed-off-by: Owen Leonard <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25744] Replace <i> tags with <em> AND <b> tags with <strong> in the staff interface

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744

--- Comment #6 from Owen Leonard <[hidden email]> ---
Created attachment 109759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109759&action=edit
Bug 25744: replace <b> with <strong> in the staff interface

This patch set attempts to replace all the <i> tags with <em> and all
the <b> tags with <strong> in the staff interface.
I attempted to get all the templates, includes, and xslt files.

To test:

1. Review the changes as best as possible, looking for mistakes.
2. grep for <i> and <b> in the modules, includes, and xslt folders. You should
get nothing/
3. If you grep '<\/i>' you should only see instances of Font Awesome.
4. If you grep '<\/b>' you should only see instances where caret is used.

Signed-off-by: Owen Leonard <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25744] Replace <i> tags with <em> AND <b> tags with <strong> in the staff interface

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744

Julian Maurice <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109758|0                           |1
        is obsolete|                            |

--- Comment #7 from Julian Maurice <[hidden email]> ---
Created attachment 109889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109889&action=edit
Bug 25744: Replace <i> with <em> in staff interface

Signed-off-by: Owen Leonard <[hidden email]>
Signed-off-by: Julian Maurice <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25744] Replace <i> tags with <em> AND <b> tags with <strong> in the staff interface

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744

Julian Maurice <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109759|0                           |1
        is obsolete|                            |

--- Comment #8 from Julian Maurice <[hidden email]> ---
Created attachment 109890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109890&action=edit
Bug 25744: replace <b> with <strong> in the staff interface

This patch set attempts to replace all the <i> tags with <em> and all
the <b> tags with <strong> in the staff interface.
I attempted to get all the templates, includes, and xslt files.

To test:

1. Review the changes as best as possible, looking for mistakes.
2. grep for <i> and <b> in the modules, includes, and xslt folders. You should
get nothing/
3. If you grep '<\/i>' you should only see instances of Font Awesome.
4. If you grep '<\/b>' you should only see instances where caret is used.

Signed-off-by: Owen Leonard <[hidden email]>
Signed-off-by: Julian Maurice <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25744] Replace <i> tags with <em> AND <b> tags with <strong> in the staff interface

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744

Julian Maurice <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25744] Replace <i> tags with <em> AND <b> tags with <strong> in the staff interface

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25744] Replace <i> tags with <em> AND <b> tags with <strong> in the staff interface

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744

--- Comment #9 from Jonathan Druart <[hidden email]> ---
Pushed to master for 20.11, thanks to everybody involved!

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/