[Bug 25641] New: Koha/XSLT/Base.t is failing on U20

classic Classic list List threaded Threaded
18 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 25641] New: Koha/XSLT/Base.t is failing on U20

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641

            Bug ID: 25641
           Summary: Koha/XSLT/Base.t is failing on U20
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Test Suite
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

kohadev-koha@a72d3d9a1f4d:/kohadevbox/koha$ prove
t/db_dependent/Koha/XSLT/Base.t      
t/db_dependent/Koha/XSLT/Base.t .. 1/33
#   Failed test 'Malformed XML warning correctly displayed'
#   at t/db_dependent/Koha/XSLT/Base.t line 87.
# found warning: XSLT::Base: :1: parser error : Opening and ending tag
mismatch: a line 0 and b
# expected to find warning: (?^u:parser error : Opening and ending tag
mismatch: a line 1 and b)

#   Failed test 'Malformed XML warning correctly displayed'
#   at t/db_dependent/Koha/XSLT/Base.t line 99.
# found warning: XSLT::Base: :1: parser error : Opening and ending tag
mismatch: a line 0 and b
# expected to find warning: (?^u:parser error : Opening and ending tag
mismatch: a line 1 and b)

#   Failed test 'Malformed XML warning correctly displayed'
#   at t/db_dependent/Koha/XSLT/Base.t line 104.
# found warning: XSLT::Base: :1: parser error : Opening and ending tag
mismatch: a line 0 and b
# expected to find warning: (?^u:parser error : Opening and ending tag
mismatch: a line 1 and b)

#   Failed test 'Malformed XML warning correctly displayed'
#   at t/db_dependent/Koha/XSLT/Base.t line 110.
# found warning: XSLT::Base: :1: parser error : Opening and ending tag
mismatch: a line 0 and b
# expected to find warning: (?^u:parser error : Opening and ending tag
mismatch: a line 1 and b)
# Looks like you failed 4 tests of 33.
t/db_dependent/Koha/XSLT/Base.t .. Dubious, test returned 4 (wstat 1024, 0x400)
Failed 4/33 subtests

Test Summary Report
-------------------
t/db_dependent/Koha/XSLT/Base.t (Wstat: 1024 Tests: 33 Failed: 4)
  Failed tests:  10, 12, 14, 16
  Non-zero exit status: 4
Files=1, Tests=33,  1 wallclock secs ( 0.03 usr  0.01 sys +  0.44 cusr  0.04
csys =  0.52 CPU)
Result: FAIL

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25641] Koha/XSLT/Base.t is failing on U20

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |25640


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25640
[Bug 25640] [OMNIBUS] Ubuntu 20.04 support
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25641] Koha/XSLT/Base.t is failing on U20

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25641] Koha/XSLT/Base.t is failing on U20

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641

--- Comment #1 from Jonathan Druart <[hidden email]> ---
Created attachment 105469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105469&action=edit
Bug 25641: Fix Koha/XSLT/Base.t failures on U20

There is a change in the version number.
On U20 we get
  Opening and ending tag mismatch: a line 0 and b
On others (D9, D10, U18) we get:
  Opening and ending tag mismatch: a line 1 and b

I did not find where it did come from, so assuming it's just a minor
change and won't have side-effects.

Test plan:
Make sure the tests pass on U20 and another OS

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25641] Koha/XSLT/Base.t is failing on U20

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25641] Koha/XSLT/Base.t is failing on U20

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641

David Cook <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25641] Koha/XSLT/Base.t is failing on U20

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641

Mason James <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Mason James <[hidden email]> ---
(In reply to Jonathan Druart from comment #1)

> Created attachment 105469 [details] [review]
> Bug 25641: Fix Koha/XSLT/Base.t failures on U20
>
> There is a change in the version number.
> On U20 we get
>   Opening and ending tag mismatch: a line 0 and b
> On others (D9, D10, U18) we get:
>   Opening and ending tag mismatch: a line 1 and b
>
> I did not find where it did come from, so assuming it's just a minor
> change and won't have side-effects.
>
> Test plan:
> Make sure the tests pass on U20 and another OS

hi, i've seen the same error on deb11 too

https://jenkins.koha-community.org/job/Koha_Master_D11/2/
https://jenkins.koha-community.org/job/Koha_Master_D11/2/testReport/junit/(root)/t_db_dependent_Koha_XSLT_Base_t/Malformed_XML_warning_correctly_displayed__2075_/


not ok 10 - Malformed XML warning correctly displayed
ok 11 - Engine returns error on malformed xml
not ok 12 - Malformed XML warning correctly displayed
ok 13 - Engine respects do_not_return_source==1
not ok 14 - Malformed XML warning correctly displayed
ok 15 - Second engine respects it too
not ok 16 - Malformed XML warning correctly displayed

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25641] Koha/XSLT/Base.t is failing on U20

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641

Lucas Gass <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25641] Koha/XSLT/Base.t is failing on U20

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641

Victor Grousset/tuxayo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25641] Koha/XSLT/Base.t is failing on U20

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641

Victor Grousset/tuxayo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105469|0                           |1
        is obsolete|                            |

--- Comment #3 from Victor Grousset/tuxayo <[hidden email]> ---
Created attachment 105606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105606&action=edit
Bug 25641: Fix Koha/XSLT/Base.t failures on U20

There is a change in the version number.
On U20 we get
  Opening and ending tag mismatch: a line 0 and b
On others (D9, D10, U18) we get:
  Opening and ending tag mismatch: a line 1 and b

I did not find where it did come from, so assuming it's just a minor
change and won't have side-effects.

Test plan:
Make sure the tests pass on U20 and another OS

Signed-off-by: Victor Grousset/tuxayo <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25641] Koha/XSLT/Base.t is failing on U20

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641

Victor Grousset/tuxayo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #4 from Victor Grousset/tuxayo <[hidden email]> ---
It works! (U20, D10, D11)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25641] Koha/XSLT/Base.t is failing on U20

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #5 from Jonathan Druart <[hidden email]> ---
Skipping QA, I want this one pushed.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25641] Koha/XSLT/Base.t is failing on U20

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.11.00
        released in|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25641] Koha/XSLT/Base.t is failing on U20

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641

--- Comment #6 from Jonathan Druart <[hidden email]> ---
Pushed to master for 20.11, thanks to everybody involved!

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25641] Koha/XSLT/Base.t is failing on U20

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from Marcel de Rooy <[hidden email]> ---
Is U20 counting lines in a file from 0 now ?
Maybe we should just use \d+ ? The line number is not really relevant..

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25641] Koha/XSLT/Base.t is failing on U20

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641

--- Comment #8 from Jonathan Druart <[hidden email]> ---
That's how I fixed it at the beginning. But then it sounded more accurate to
test 0|1.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25641] Koha/XSLT/Base.t is failing on U20

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641

Lucas Gass <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.11.00                    |20.11.00, 20.05.01
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #9 from Lucas Gass <[hidden email]> ---
backported to 20.05.x for 20.05.01

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25641] Koha/XSLT/Base.t is failing on U20

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #10 from Aleisha Amohia <[hidden email]> ---
t/db_dependent/Koha/XSLT/Base.t is not in 19.11.x, not backporting

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/