[Bug 25624] New: Update patrons category script should allow finding null and not null and wildcards

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 25624] New: Update patrons category script should allow finding null and not null and wildcards

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624

            Bug ID: 25624
           Summary: Update patrons category script should allow finding
                    null and not null and wildcards
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

The script does not allow to find empty fields or use wildcards

It would be helpful to find patrons where a field has been set, or a field not
matching, or similar fields

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25624] Update patrons category script should allow finding null and not null and wildcards

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25624] Update patrons category script should allow finding null and not null and wildcards

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624

--- Comment #1 from Nick Clemens <[hidden email]> ---
Created attachment 105439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105439&action=edit
Bug 25624: Add not equal, like, not like, and support for nulls to
update_patron_category

To test:
1 - Run the script with no parameters and verify the help explains the
parameters
2 - Try running with various fields, matching and not matching
3 - Test null values
4 - Test like values with wildcards
5 - Test like with the word null to find fields containing the word rather than
being unset

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25624] Update patrons category script should allow finding null and not null and wildcards

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624

Andrew Fuerste-Henry <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25624] Update patrons category script should allow finding null and not null and wildcards

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624

Andrew Fuerste-Henry <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105439|0                           |1
        is obsolete|                            |

--- Comment #2 from Andrew Fuerste-Henry <[hidden email]> ---
Created attachment 105605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105605&action=edit
Bug 25624: Add not equal, like, not like, and support for nulls to
update_patron_category

To test:
1 - Run the script with no parameters and verify the help explains the
parameters
2 - Try running with various fields, matching and not matching
3 - Test null values
4 - Test like values with wildcards
5 - Test like with the word null to find fields containing the word rather than
being unset

Signed-off-by: Rhonda Kuiper <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25624] Update patrons category script should allow finding null and not null and wildcards

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|[hidden email]-communit |[hidden email]
                   |y.org                       |
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25624] Update patrons category script should allow finding null and not null and wildcards

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624

--- Comment #3 from Alex Arnaud <[hidden email]> ---
Comment on attachment 105605
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105605
Bug 25624: Add not equal, like, not like, and support for nulls to
update_patron_category

Review of attachment 105605:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25624&attachment=105605)
-----------------------------------------------------------------

Can you add pod items for likefield and notlikefield options ?

::: misc/cronjobs/update_patrons_category.pl
@@ +135,5 @@
> +Use this flag to specify a column in the borrowers table and update only patrons whose value in that column does not equal the value supplied (repeatable)
> +
> +e.g.
> +--notfield email=NULL
> +will update all patrons with no value for email

all patrons with null email field ?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25624] Update patrons category script should allow finding null and not null and wildcards

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624

--- Comment #4 from Alex Arnaud <[hidden email]> ---
No a blocker but a concern:

not* options work with empty and non-empty values but not with null values.

perl misc/cronjobs/update_patrons_category.pl -f S -t B -dn email=foo -v

=> matches all patrons with email different from "foo" or email eq ''. But not
the null ones. Is it the wanted behavior ?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25624] Update patrons category script should allow finding null and not null and wildcards

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624

--- Comment #5 from Alex Arnaud <[hidden email]> ---
(In reply to Alex Arnaud from comment #3)
> > +will update all patrons with no value for email
>
> all patrons with null email field ?

I mean: all patron with email different from null

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25624] Update patrons category script should allow finding null and not null and wildcards

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624

--- Comment #6 from Martin Renvoize <[hidden email]> ---
Comment on attachment 105605
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105605
Bug 25624: Add not equal, like, not like, and support for nulls to
update_patron_category

Review of attachment 105605:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25624&attachment=105605)
-----------------------------------------------------------------

::: misc/cronjobs/update_patrons_category.pl
@@ +57,5 @@
>     -ra=date --regafter      update if registration date is after a given date
>     -d --dbfield name=value  where <name> is a column in the borrowers table, patrons will be updated if the field is equal to given <value>
> +   -dn --notfield name=value  where <name> is a column in the borrowers table, patrons will be updated if the field is equal to given <value>
> +   -dl --likefield name=value  where <name> is a column in the borrowers table, patrons will be updated if the field is equal to given <value>
> +   -dnl --notlikefield name=value  where <name> is a column in the borrowers table, patrons will be updated if the field is equal to given <value>

All three descriptions here match.. can you clarify the descriptions, please..
replacing 'equal' with the relevant comparison?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25624] Update patrons category script should allow finding null and not null and wildcards

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |martin.renvoize@ptfs-europe
                   |                            |.com

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/