[Bug 25513] New: acquisitions_orders.t is failing randomly

classic Classic list List threaded Threaded
47 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] New: acquisitions_orders.t is failing randomly

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

            Bug ID: 25513
           Summary: acquisitions_orders.t is failing randomly
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

Master_D8 #869

14:12:37 koha_1       |     #   Failed test 'SWAGGER3.3.2'
14:12:37 koha_1       |     #   at t/db_dependent/api/v1/acquisitions_orders.t
line 129.
14:12:37 koha_1       |     #     Structures begin differing at:
14:12:37 koha_1       |     #          $got->{ecost_tax_excluded} =
'9963405519357589504'
14:12:37 koha_1       |     #     $expected->{ecost_tax_excluded} =
'9.96340551935759e+18'
14:12:37 koha_1       |     # Looks like you failed 1 test of 6.
14:12:37 koha_1       |
14:12:37 koha_1       | #   Failed test 'get() tests'
14:12:37 koha_1       | #   at t/db_dependent/api/v1/acquisitions_orders.t line
141.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18731


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731
[Bug 18731] Add routes for acquisition orders
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_20_05_candidate

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

--- Comment #1 from Jonathan Druart <[hidden email]> ---
Master_U18 #788

14:48:26 koha_1       |     #   Failed test 'SWAGGER3.3.2'
14:48:26 koha_1       |     #   at t/db_dependent/api/v1/acquisitions_orders.t
line 129.
14:48:26 koha_1       |     #     Structures begin differing at:
14:48:26 koha_1       |     #          $got->{unit_price} =
'10177559957753600000'
14:48:26 koha_1       |     #     $expected->{unit_price} =
'1.01775599577536e+19'
14:48:26 koha_1       |     # Looks like you failed 1 test of 6.
14:48:26 koha_1       |
14:48:26 koha_1       | #   Failed test 'get() tests'
14:48:26 koha_1       | #   at t/db_dependent/api/v1/acquisitions_orders.t line
141.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

--- Comment #2 from Jonathan Druart <[hidden email]> ---
Those two runs were on Docker_2

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

--- Comment #3 from Jonathan Druart <[hidden email]> ---
Master_U18 #772

01:45:29 koha_1       |     #   Failed test 'SWAGGER3.3.2'
01:45:29 koha_1       |     #   at t/db_dependent/api/v1/acquisitions_orders.t
line 129.
01:45:29 koha_1       |     #     Structures begin differing at:
01:45:29 koha_1       |     #          $got->{unit_price_tax_included} =
'15313858494394601472'
01:45:29 koha_1       |     #     $expected->{unit_price_tax_included} =
'1.53138584943946e+19'
01:45:29 koha_1       |     # Looks like you failed 1 test of 6.
01:45:29 koha_1       |
01:45:29 koha_1       | #   Failed test 'get() tests'
01:45:29 koha_1       | #   at t/db_dependent/api/v1/acquisitions_orders.t

Also on Docker_2

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |25551


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551
[Bug 25551] [OMNIBUS] Some tests are failing randomly
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

didier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |om

--- Comment #4 from didier <[hidden email]> ---
Hi,

Could be link to 'ecost_tax_excluded' being a decimal 28,6 in mysql and swagger
type a double?

It wouldn't be the first time a buggy double to string function didn't
roundtrip for some values.

It seems '$expected->{' is coming from /usr/share/perl5/Test/More.pm, but it
doesn't print the full number.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

--- Comment #5 from Jonathan Druart <[hidden email]> ---
It comes from a wrong formatting, and I think it depends on some locale
settings (for instance it seems to only fail on Docker_2).

The thing people should try is to set 9963405519357589504 for
ecost_tax_excluded (for instance).
And see if it fails.

I cannot make it fail locally.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

--- Comment #6 from Jonathan Druart <[hidden email]> ---
Created attachment 105170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105170&action=edit
Bug 25513: DO NOT PUSH - try recreating the failure

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

--- Comment #7 from Jonathan Druart <[hidden email]> ---
You could try this patch.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

--- Comment #8 from didier <[hidden email]> ---
Hi
There's a thinko in the patch should be:
-            value => { orderstatus => 'new' }
+            value => { orderstatus => 'new', ecost_tax_excluded =>
9963405519357589504, unitprice => 10177559957753600000  }

Not
-            value => { orderstatus => 'new' }
+            value => { orderstatus => 'new', value => { ecost_tax_excluded =>
9963405519357589504, unitprice => 10177559957753600000 } }

And it fails for me
ok 1 - list() tests
# Subtest: get() tests
    1..6
[Thu May 21 10:08:23 2020] [debug] GET "/api/v1/acquisitions/orders/48"
[Thu May 21 10:08:23 2020] [debug] Routing to controller "Koha::REST::V1::Auth"
and action "under"
[Thu May 21 10:08:23 2020] [debug] Routing to controller
"Koha::REST::V1::Acquisitions::Orders" and action "get"
[Thu May 21 10:08:23 2020] [debug] 200 OK (0.039639s, 25.228/s)
    ok 1 - GET
//fgMbl_VX3EQexGiV17S9yOb3KOVToMz0qyMP_TOrYUeMkzAppWplcQ5izgERU:thePassword123@/api/v1/acquisitions/orders/48
    ok 2 - SWAGGER3.2.2
    not ok 3 - SWAGGER3.3.2

    #   Failed test 'SWAGGER3.3.2'
    #   at ./t/db_dependent/api/v1/acquisitions_orders.t line 129.
    #     Structures begin differing at:
    #          $got->{ecost_tax_excluded} = '9963405519357589504'
    #     $expected->{ecost_tax_excluded} = '9.96340551935759e+18'
[Thu May 21 10:08:23 2020] [debug] GET "/api/v1/acquisitions/orders/48"
[Thu May 21 10:08:23 2020] [debug] Routing to controller "Koha::REST::V1::Auth"
and action "under"
[Thu May 21 10:08:23 2020] [debug] Routing to controller
"Koha::REST::V1::Acquisitions::Orders" and action "get"
[Thu May 21 10:08:23 2020] [debug] 404 Not Found (0.034099s, 29.326/s)
    ok 4 - GET
//fgMbl_VX3EQexGiV17S9yOb3KOVToMz0qyMP_TOrYUeMkzAppWplcQ5izgERU:thePassword123@/api/v1/acquisitions/orders/48
    ok 5 - 404 Not Found
    ok 6 - exact match for JSON Pointer "/error"
    # Looks like you failed 1 test of 6.
not ok 2 - get() tests

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

--- Comment #9 from Jonathan Druart <[hidden email]> ---
Indeed!
But still not fail for me (I tried yesterday and wrote the patch this
morning...)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

--- Comment #10 from Jonathan Druart <[hidden email]> ---
Didier, ping me on IRC when you are available :)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105170|0                           |1
        is obsolete|                            |

--- Comment #11 from Jonathan Druart <[hidden email]> ---
Created attachment 105175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105175&action=edit
Bug 25513: DO NOT PUSH - try recreating the failure

This is failing in stretch

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105175|0                           |1
        is obsolete|                            |

--- Comment #12 from Jonathan Druart <[hidden email]> ---
Created attachment 105177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105177&action=edit
Bug 25513: DO NOT PUSH - try recreating the failure

This is failing in stretch:
Stretch with mysql 5.5
Stretch with 10.1.44-MariaDB-1~bionic (docker-compose.mariadb_d9.yml)

Not on Buster with 10.1.44-MariaDB-1~bionic (docker-compose.mariadb_d9.yml)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

--- Comment #13 from Jonathan Druart <[hidden email]> ---
However, using Postman I see the same output (exponent format) with both
stretch and buster:
  "unit_price": 1.01775599577536e+19,
  "ecost_tax_excluded": 9.96340551935759e+18,

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

--- Comment #14 from Jonathan Druart <[hidden email]> ---
buster has JSON=4.02
stretch has JSON=2.90

% more xxx.pl
use Modern::Perl;
use Mojo::JSON qw(decode_json encode_json);
my $bytes = encode_json {foo => 9963405519357589504, bar =>
10177559957753600000};
say $bytes;

buster:
% perl xxx.pl
{"bar":10177559957753600000,"foo":9963405519357589504}

stretch:
% perl xxx.pl
{"bar":10177559957753600000,"foo":9963405519357589504}

I am missing something obvious...

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

--- Comment #16 from Jonathan Druart <[hidden email]> ---
(In reply to didier from comment #15)
> Could be something like?
> https://dba.stackexchange.com/questions/172216/why-would-mysqls-roundn-dd-1-
> sometimes-show-no-digits-after-the-decimal-place

Yes, that seems related.
Stretch has 4.041-2 and Buster has 4.050-2

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

--- Comment #17 from Jonathan Druart <[hidden email]> ---
(In reply to Jonathan Druart from comment #14)

> buster has JSON=4.02
> stretch has JSON=2.90
>
> % more xxx.pl
> use Modern::Perl;
> use Mojo::JSON qw(decode_json encode_json);
> my $bytes = encode_json {foo => 9963405519357589504, bar =>
> 10177559957753600000};
> say $bytes;
>
> buster:
> % perl xxx.pl
> {"bar":10177559957753600000,"foo":9963405519357589504}
>
> stretch:
> % perl xxx.pl
> {"bar":10177559957753600000,"foo":9963405519357589504}
>
> I am missing something obvious...

Note that this was meaningless, we wanted to test:

use Mojo::JSON qw(decode_json encode_json);
my $bytes = encode_json {foo => 9963405519357589504.0000, bar =>
10177559957753600000.0000};
say $bytes;

Both return
{"bar":1.01775599577536e+19,"foo":9.96340551935759e+18}

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

--- Comment #18 from Jonathan Druart <[hidden email]> ---
Created attachment 105265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105265&action=edit
Bug 25513: Fix random failure from acquisitions_orders.t

No idea if this is correct, but the tests pass without that condition

See bug 17932

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17932


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932
[Bug 17932] Koha::Object should provide a TO_JSON method
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]    |[hidden email]-c
                   |                            |ommunity.org

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

--- Comment #19 from Jonathan Druart <[hidden email]> ---
Additional notes:
1. This may break Jessie, so we should have a patch for stables that will "fix"
the tests by adding specific value to the order we create
2. There is a "format" parameter in the API spec, but we don't use it
https://swagger.io/docs/specification/data-models/data-types/
Maybe we should.

Another fix would be to extend the test in that area (TO_JSON) and add
_float_column_type. We could then use Math::BigFloat:
  use Math::BigFloat;
  my $x = Math::BigFloat->new(10177559957753600000);
  my $y = Math::BigFloat->new(1.01775599577536e+19);
  say $x;say $y;
will display twice 10177559957753600000

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #20 from Tomás Cohen Arazi <[hidden email]> ---
(In reply to Jonathan Druart from comment #19)

> Additional notes:
> 1. This may break Jessie, so we should have a patch for stables that will
> "fix" the tests by adding specific value to the order we create
> 2. There is a "format" parameter in the API spec, but we don't use it
> https://swagger.io/docs/specification/data-models/data-types/
> Maybe we should.
>
> Another fix would be to extend the test in that area (TO_JSON) and add
> _float_column_type. We could then use Math::BigFloat:
>   use Math::BigFloat;
>   my $x = Math::BigFloat->new(10177559957753600000);
>   my $y = Math::BigFloat->new(1.01775599577536e+19);
>   say $x;say $y;
> will display twice 10177559957753600000

I agree we should be identifying floats and using:

"type:" "number",
"format": "float"

I would like to mention that the like you provided is for OAS3 and we are using
OAS2
https://swagger.io/specification/v2/

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

Victor Grousset/tuxayo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105265|0                           |1
        is obsolete|                            |

--- Comment #21 from Victor Grousset/tuxayo <[hidden email]> ---
Created attachment 105317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105317&action=edit
Bug 25513: Fix random failure from acquisitions_orders.t

No idea if this is correct, but the tests pass without that condition

See bug 17932

Signed-off-by: Victor Grousset/tuxayo <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

Victor Grousset/tuxayo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |[hidden email]

--- Comment #22 from Victor Grousset/tuxayo <[hidden email]> ---
Tested on koha-testing-docker on Ubuntu 18.04

By running the test in a loop (on master) I could get 2 failures in less that
20 runs.
But after that it took 150 runs to get a failure.

Thanks to the patch "Bug 25513: DO NOT PUSH - try recreating the failure" , now
it fails every time.
And the 2nd patch (fix) works! :D

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25513] acquisitions_orders.t is failing randomly

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

--- Comment #23 from Victor Grousset/tuxayo <[hidden email]> ---
On master + only the fix: the tests passed 1350 times and counting. Looks
pretty solid :)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12