[Bug 25444] New: Before and course reserve values are not correctly shown

classic Classic list List threaded Threaded
43 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] New: Before and course reserve values are not correctly shown

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

            Bug ID: 25444
           Summary: Before and course reserve values are not correctly
                    shown
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Course reserves
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
        Depends on: 23727

While the setting and resetting of item values now works much better than
before (see 23727) the values displayed in the course reserves item table are
not correct.

It's supposed to show you if something was changed, what it was changed from
and what to. But what you see there doesn't match reality or what will happen
when the course is set inactive/deleted.

To test:
- Create a course reserve
- Add course reserve items
  - either change item values directly when adding
    or
  - use the edit functionality provided
- Take note of the display - does it match changes made?
- Disable course and check your items - does it match what was shown?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727
[Bug 23727] Editing course reserve items is broken
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <[hidden email]> ---
Can you detail what you expect?

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

--- Comment #2 from Jonathan Druart <[hidden email]> ---
It shows:

"Children's Area (General Stacks)"

"Children's Area" is the value of the course, and "General Stacks" the original
value of the item (and so the value that has been set back).

Are we expecting the reverse?
"General Stacks (Children's Area)"

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--- Comment #3 from Katrin Fischer <[hidden email]> ---
Retesting with some more details:

1) Item used, original values:

Item type: Books        
Holding library: Fairview
Home library: Fairview
Location: General Stacks        
Collection: Reference
Barcode: 39999000000399 (from sample data)      

2) Added to an active course reserve, using "Add reserves":

Item type: Maps (changed)
Holding library: Fairview
Home library: Riverside (changed)
Location: General Stacks        
Collection: Fiction (changed)

3) Display on course reserves table in staff:

Maps (Books)    
Fiction (Reference)    
Unchanged (General Stacks)      
Riverside (Riverside) = WRONG!
Unchanged (Fairview)

4) Using "Edit" option from course reserves:

Additionally changing:
Location: On Display (was General stacks)
Holding library: Midway (was Fairview)

5) Display on course reserves table in staff:

Maps (Books)    
Fiction (Reference)    
On Display () = WRONG! Expected: On display (General stacks)
Riverside (Riverside) = Still wrong...  
Midway () = WRONG! Expected: Midway (Fairview)

6) Remove item from course reserves using "remove" button:

Item type: Books        
Holding library: EMPTY = WRONG!
Home library: Fairview
Location: EMPTY = WRONG!
Collection: Reference
Barcode: 39999000000399        

We still seem to somehow lose data here :( Updating severity.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |critical

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown and data is lost

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Before and course reserve   |Before and course reserve
                   |values are not correctly    |values are not correctly
                   |shown                       |shown and data is lost

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown and data is lost

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

--- Comment #4 from Jonathan Druart <[hidden email]> ---
(In reply to Katrin Fischer from comment #3)

> Retesting with some more details:
>
> 1) Item used, original values:
>
> Item type: Books
> Holding library: Fairview
> Home library: Fairview
> Location: General Stacks
> Collection: Reference
> Barcode: 39999000000399 (from sample data)
>
> 2) Added to an active course reserve, using "Add reserves":
>
> Item type: Maps (changed)
> Holding library: Fairview
> Home library: Riverside (changed)
> Location: General Stacks
> Collection: Fiction (changed)
>
> 3) Display on course reserves table in staff:
>
> Maps (Books)
> Fiction (Reference)
> Unchanged (General Stacks)
> Riverside (Riverside) = WRONG!
> Unchanged (Fairview)

Will be fixed by the follow-up I have just attached to bug 22630:
    Bug 22630: Display correct "in storage" value


> 4) Using "Edit" option from course reserves:
>
> Additionally changing:
> Location: On Display (was General stacks)
> Holding library: Midway (was Fairview)
>
> 5) Display on course reserves table in staff:
>
> Maps (Books)
> Fiction (Reference)
> On Display () = WRONG! Expected: On display (General stacks)
> Riverside (Riverside) = Still wrong...
> Midway () = WRONG! Expected: Midway (Fairview)


At this point we have, in DB:
        holdingbranch: MPL
holdingbranch_enabled: 1
holdingbranch_storage: NULL
             location: DISPLAY
     location_enabled: 1
     location_storage: NULL

My understanding is that the *_storage values are not retrieved when a course
is edited.
Reading the code it seems that it happens in _SwapAllFields, only called by
EnableOrDisableCourseItem.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown and data is lost

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_20_05_candidate

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown and data is lost

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

--- Comment #5 from Katrin Fischer <[hidden email]> ---
Sorry, I am not sure I understand your second point. At the moment we
experience data loss - neither the new nor the old branch comes back... For the
mechanics - I am not sure how this is supposed to work db wise.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown and data is lost

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

--- Comment #6 from Kyle M Hall <[hidden email]> ---
Created attachment 105361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105361&action=edit
Bug 25444: Set the storage fields when adding new fields to an existing course
item, revert fields when removing from existing course item

If a new field is enabled on an existing course reserve, the storage
field is not given a value, so when the item goes off reserve, the
item field will always be updated to NULL.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown and data is lost

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

--- Comment #7 from Kyle M Hall <[hidden email]> ---
Katrin, can you test this patch? I think it fixes the data loss issue you are
having. I think it's causing failing unit tests so I just want to see if this
works for you before I dig in to those!

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown and data is lost

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown and data is lost

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown and data is lost

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105361|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall <[hidden email]> ---
Created attachment 105362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105362&action=edit
Bug 25444: Set the storage fields when adding new fields to an existing course
item, revert fields when removing from existing course item

If a new field is enabled on an existing course reserve, the storage
field is not given a value, so when the item goes off reserve, the
item field will always be updated to NULL.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown and data is lost

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105362|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall <[hidden email]> ---
Created attachment 105363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105363&action=edit
Bug 25444: Set the storage fields when adding new fields to an existing course
item, revert fields when removing from existing course item

If a new field is enabled on an existing course reserve, the storage
field is not given a value, so when the item goes off reserve, the
item field will always be updated to NULL.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown and data is lost

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

--- Comment #10 from Kyle M Hall <[hidden email]> ---
Created attachment 105364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105364&action=edit
Bug 25444: Add unit tests

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown and data is lost

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown and data is lost

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105363|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown and data is lost

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105364|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown and data is lost

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

--- Comment #11 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 105370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105370&action=edit
Bug 25444: Add unit tests

Signed-off-by: Tomas Cohen Arazi <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Before and course reserve values are not correctly shown and data is lost

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

--- Comment #12 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 105371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105371&action=edit
Bug 25444: Backup/restore course items fields correctly

This patch makes the code set the *_storage fields when adding new
fields to an existing course item. And reverts those fields correctly
when removing the item from the course.

If a new field is enabled on an existing course reserve, the storage
field is not given a value, so when the item goes off reserve, the
item field will always be updated to NULL.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/CourseReserves/CourseItems.t
=> FAIL: Tests fail, data is not reverted correctly
3. Apply this patch and repeat 2
=> SUCCESS: Tests pass! Data is correctly reverted
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Course reserve settings are not saved on edit

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Before and course reserve   |Course reserve settings are
                   |values are not correctly    |not saved on edit
                   |shown and data is lost      |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Course reserve settings are not saved on edit

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

--- Comment #13 from Jonathan Druart <[hidden email]> ---
Created attachment 105378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105378&action=edit
Bug 25444: Simplify the code using a loop

In order to prevent typos or further regressions it is better (I think)
to have this code into a loop

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Course reserve settings are not saved on edit

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #14 from Jonathan Druart <[hidden email]> ---
(In reply to Katrin Fischer from comment #3)

> Retesting with some more details:
>
> 1) Item used, original values:
>
> Item type: Books
> Holding library: Fairview
> Home library: Fairview
> Location: General Stacks
> Collection: Reference
> Barcode: 39999000000399 (from sample data)
>
> 2) Added to an active course reserve, using "Add reserves":
>
> Item type: Maps (changed)
> Holding library: Fairview
> Home library: Riverside (changed)
> Location: General Stacks
> Collection: Fiction (changed)
>
> 3) Display on course reserves table in staff:

=> https://snipboard.io/e59AiY.jpg

Maps (Books)
Fiction (Reference)
Unchanged => WRONG Should be Unchanged (General Stacks)
Riverside (Fairview)
Unchanged (Fairview)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Course reserve settings are not saved on edit

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

--- Comment #15 from Jonathan Druart <[hidden email]> ---
The template is displaying permanent_location, is that correct?
In C4::CourseReserves we always play with items.location.
I have, in DB:
        homebranch: RPL
     holdingbranch: FPL
          location: GEN
permanent_location: NULL

I guess that's why I don't see the "location".
What is the expected behaviour here?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Course reserve settings are not saved on edit

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

--- Comment #16 from Katrin Fischer <[hidden email]> ---

> Maps (Books)
> Fiction (Reference)
> Unchanged => WRONG Should be Unchanged (General Stacks)
> Riverside (Fairview)
> Unchanged (Fairview)

I thought you said we would be dealing with this here:

>Will be fixed by the follow-up I have just attached to bug 22630:
>    Bug 22630: Display correct "in storage" value

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Course reserve settings are not saved on edit

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

--- Comment #17 from Katrin Fischer <[hidden email]> ---
(In reply to Katrin Fischer from comment #16)

> > Maps (Books)
> > Fiction (Reference)
> > Unchanged => WRONG Should be Unchanged (General Stacks)
> > Riverside (Fairview)
> > Unchanged (Fairview)
>
> I thought you said we would be dealing with this here:
>
> >Will be fixed by the follow-up I have just attached to bug 22630:
> >    Bug 22630: Display correct "in storage" value
(In reply to Jonathan Druart from comment #15)

> The template is displaying permanent_location, is that correct?
> In C4::CourseReserves we always play with items.location.
> I have, in DB:
>         homebranch: RPL
>      holdingbranch: FPL
>           location: GEN
> permanent_location: NULL
>
> I guess that's why I don't see the "location".
> What is the expected behaviour here?

It's a good question. I am not sure about the mechanics - if permanent_location
should be automatically pre-populated or will onyl be if you use the CART
feature.

I checked or oldest database and permanent_location is almost always empty. I
think we should better use location here or have a fallback to it if
permanent_location is empty.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Course reserve settings are not saved on edit

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

--- Comment #18 from Kyle M Hall <[hidden email]> ---
(In reply to Jonathan Druart from comment #15)

> The template is displaying permanent_location, is that correct?
> In C4::CourseReserves we always play with items.location.
> I have, in DB:
>         homebranch: RPL
>      holdingbranch: FPL
>           location: GEN
> permanent_location: NULL
>
> I guess that's why I don't see the "location".
> What is the expected behaviour here?

That was a change made on bug 21446, which doesn't really justify the change.
In my original code, everything operates on the 'location' column. The code has
never touch permanent location. I would suggest reverting the behavior of
21446.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25444] Course reserve settings are not saved on edit

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

--- Comment #19 from Kyle M Hall <[hidden email]> ---
Created attachment 105379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105379&action=edit
Bug 25444: More minor improvements to simplified loop

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12