[Bug 25408] New: CanBookBeReserved should check "opacitemholds" policy

classic Classic list List threaded Threaded
25 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] New: CanBookBeReserved should check "opacitemholds" policy

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

            Bug ID: 25408
           Summary: CanBookBeReserved should check "opacitemholds" policy
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

how to reproduce :
Set an issuing rule with opacitemholds set to "Force"
Make a search and select multiple records
Place a hold on those records (using multi-hold records)
Verify hold is placed on the record (next item available) where it shouldn't!

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved should check "opacitemholds" policy

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

--- Comment #1 from Arthur Suzuki <[hidden email]> ---
Created attachment 104488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104488&action=edit
Bug 25408: Add "opacitemholds" checks in CanBookBeReserved

test plan:
1) set issuingrule with opacitemholds set to "Force"
2) try to add a new hold using multi-hold
3) hold is placed on the record where it shouldn't
4) apply patch
5) retry to place same hold
6) success: hold cannot be placed since record-level hold is not available)

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

Arthur Suzuki <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104488|0                           |1
        is obsolete|                            |

--- Comment #2 from Arthur Suzuki <[hidden email]> ---
Created attachment 104496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104496&action=edit
Bug 25408: Add "opacitemholds" checks in CanBookBeReserved

test plan:
1) set issuingrule with opacitemholds set to "Force"
2) try to add a new hold using multi-hold
3) hold is placed on the record where it shouldn't
4) apply patch
5) retry to place same hold
6) success: hold cannot be placed since record-level hold is not available)

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

Arthur Suzuki <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

Arthur Suzuki <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=21563

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

Arthur Suzuki <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16547

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <[hidden email]> ---
Please add tests to cover this change.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

Victor Grousset/tuxayo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Victor Grousset/tuxayo <[hidden email]> ---
Aside from the QA issue:

> 1) set issuingrule with opacitemholds set to "Force"
> 2) try to add a new hold using multi-hold
> 3) hold is placed on the record where it shouldn't

Can't reproduce. To detail:
- went to circ rules
- there is only one general rule, for all sites, all item types, all categories
- set "OPAC item level holds" for "Force"
- went to the OPAC
- used the search
- ticked two result
- "Place hold"
- placed a hold without touching anything. (on record had 1 item, the other 2)
- went back to the staff interface to each record's hold page
- both hold are listen as "Only item"

That's not expected right?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

--- Comment #5 from Arthur Suzuki <[hidden email]> ---
Well, seems this bug also impact holds placed with WebServices.
CanItemBeReserved also miss this check...
patch definitely need rework.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

Arthur Suzuki <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|CanBookBeReserved should    |CanBookBeReserved &
                   |check "opacitemholds"       |CanItemBeReserved should
                   |policy                      |check "opacitemholds"
                   |                            |policy

--- Comment #6 from Arthur Suzuki <[hidden email]> ---
Well, seems this bug also impact holds placed with WebServices.
CanItemBeReserved also miss this check...
patch definitely need rework.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

--- Comment #7 from Arthur Suzuki <[hidden email]> ---
Created attachment 105988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105988&action=edit
Bug 25408: Added unit tests for opacitemholds policy

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

--- Comment #8 from Arthur Suzuki <[hidden email]> ---
Created attachment 105989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105989&action=edit
Bug 25408: Add "opacitemholds" checks in CanBookBeReserved & CanItemBeReserved

test plan:
1) apply tests patch
2) run tests
3) verify not green
4) apply patch
5) run tests (again)
6) success: green :)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

Arthur Suzuki <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

Arthur Suzuki <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104496|0                           |1
        is obsolete|                            |
 Attachment #105989|0                           |1
        is obsolete|                            |

--- Comment #9 from Arthur Suzuki <[hidden email]> ---
Created attachment 105990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105990&action=edit
Bug 25408: Add "opacitemholds" checks in CanBookBeReserved & CanItemBeReserved

test plan:
1) apply tests patch
2) run tests
3) verify not green
4) apply patch
5) run tests (again)
6) success: green :)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

Arthur Suzuki <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20985


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
[Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf
holds allowed' policy
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

Victor Grousset/tuxayo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105988|0                           |1
        is obsolete|                            |

--- Comment #10 from Victor Grousset/tuxayo <[hidden email]> ---
Created attachment 106413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106413&action=edit
Bug 25408: Added unit tests for opacitemholds policy

Signed-off-by: Victor Grousset/tuxayo <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

Victor Grousset/tuxayo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105990|0                           |1
        is obsolete|                            |

--- Comment #11 from Victor Grousset/tuxayo <[hidden email]> ---
Created attachment 106414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106414&action=edit
Bug 25408: Add "opacitemholds" checks in CanBookBeReserved & CanItemBeReserved

test plan:
1) apply tests patch
2) run tests
3) verify not green
4) apply patch
5) run tests (again)
6) success: green :)

Signed-off-by: Victor Grousset/tuxayo <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

--- Comment #12 from Victor Grousset/tuxayo <[hidden email]> ---
It works!

Are the additional warnings caused by the patch?

# Only test patch applied

kohadev-koha@ea2bce8f4ac7:/kohadevbox/koha$ prove t/db_dependent/Reserves.t
t/db_dependent/Reserves.t .. 14/62 Use of uninitialized value in string eq at
/kohadevbox/koha/C4/Reserves.pm line 558.
Use of uninitialized value in string eq at /kohadevbox/koha/C4/Reserves.pm line
558.
t/db_dependent/Reserves.t .. 59/62
        #   Failed test 'record-level holds should not be possible with
opacitemholds set to "Force"'
        #   at t/db_dependent/Reserves.t line 1013.
        #          got: 'OK'
        #     expected: 'RecordHoldNotAllowed'

        #   Failed test 'item-level holds should not be possible with
opacitemholds set to "No"'
        #   at t/db_dependent/Reserves.t line 1049.
        #          got: 'OK'
        #     expected: 'notReservable'
        # Looks like you failed 2 tests of 6.

    #   Failed test 'test opacitemholds rules'
    #   at t/db_dependent/Reserves.t line 1079.
    # Looks like you failed 1 test of 3.
t/db_dependent/Reserves.t .. 61/62
#   Failed test 'reserves.item_level_hold'
#   at t/db_dependent/Reserves.t line 1080.
t/db_dependent/Reserves.t .. 62/62 # Looks like you failed 1 test of 62.
t/db_dependent/Reserves.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/62 subtests

Test Summary Report
-------------------
t/db_dependent/Reserves.t (Wstat: 256 Tests: 62 Failed: 1)
  Failed test:  61
  Non-zero exit status: 1
Files=1, Tests=62,  7 wallclock secs ( 0.04 usr  0.01 sys +  5.90 cusr  0.83
csys =  6.78 CPU)
Result: FAIL

# Applied the implementation

kohadev-koha@ea2bce8f4ac7:/kohadevbox/koha$ prove t/db_dependent/Reserves.t
t/db_dependent/Reserves.t .. 20/62 Use of uninitialized value in string eq at
/kohadevbox/koha/C4/Reserves.pm line 577.
Use of uninitialized value in string eq at /kohadevbox/koha/C4/Reserves.pm line
577.
Use of uninitialized value in string eq at /kohadevbox/koha/C4/Reserves.pm line
329.
Use of uninitialized value $opacitemholds in string eq at
/kohadevbox/koha/C4/Reserves.pm line 425.
Use of uninitialized value in string eq at /kohadevbox/koha/C4/Reserves.pm line
329.
Use of uninitialized value in string eq at /kohadevbox/koha/C4/Reserves.pm line
329.
Use of uninitialized value $opacitemholds in string eq at
/kohadevbox/koha/C4/Reserves.pm line 425.
t/db_dependent/Reserves.t .. ok    
All tests successful.
Files=1, Tests=62,  8 wallclock secs ( 0.05 usr  0.01 sys +  5.97 cusr  0.71
csys =  6.74 CPU)
Result: PASS
kohadev-koha@ea2bce8f4ac7:/kohadevbox/koha$

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

--- Comment #13 from Arthur Suzuki <[hidden email]> ---
Created attachment 106521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106521&action=edit
Bug 25408: QA followup

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

Arthur Suzuki <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #14 from Arthur Suzuki <[hidden email]> ---
Hi Tuxayo,
Hope you are doing well, you seem to be doing fine!
I've made a small qa patch to solve the warn :)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

Victor Grousset/tuxayo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106413|0                           |1
        is obsolete|                            |

--- Comment #15 from Victor Grousset/tuxayo <[hidden email]> ---
Created attachment 106535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106535&action=edit
Bug 25408: Added unit tests for opacitemholds policy

Signed-off-by: Victor Grousset/tuxayo <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

Victor Grousset/tuxayo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106414|0                           |1
        is obsolete|                            |

--- Comment #16 from Victor Grousset/tuxayo <[hidden email]> ---
Created attachment 106536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106536&action=edit
Bug 25408: Add "opacitemholds" checks in CanBookBeReserved & CanItemBeReserved

test plan:
1) apply tests patch
2) run tests
3) verify not green
4) apply patch
5) run tests (again)
6) success: green :)

Signed-off-by: Victor Grousset/tuxayo <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

Victor Grousset/tuxayo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106521|0                           |1
        is obsolete|                            |

--- Comment #17 from Victor Grousset/tuxayo <[hidden email]> ---
Created attachment 106537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106537&action=edit
Bug 25408: QA followup

Signed-off-by: Victor Grousset/tuxayo <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

--- Comment #18 from Victor Grousset/tuxayo <[hidden email]> ---
(In reply to Arthur Suzuki from comment #14)
> I've made a small qa patch to solve the warn :)

It works and no additional warnings :)


(In reply to Arthur Suzuki from comment #14)
> Hi Tuxayo,
> Hope you are doing well, you seem to be doing fine!

Doing okay, best wishes for you :)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/