[Bug 25322] New: Adding a guarantor with no relationship defaults to father

classic Classic list List threaded Threaded
49 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] New: Adding a guarantor with no relationship defaults to father

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

            Bug ID: 25322
           Summary: Adding a guarantor with no relationship defaults to
                    father
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]

If you create a patron guarantor on members/memberentry.pl, but fail to enter a
relationship, the relationship defaults to father. If no relationship is
specified, then it ought not to be populated.

To reproduce:

1) Create a new user or modify an existing one.
2) Under Guarantor Information, click on "Search to add" button
3) Perform your search, and select user to act as a guarantor
4) Do not use the dropdown menu to select a relationship.
5) Save the record

The guarantor just added will be listed as the guarantees father.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

Andrew Fuerste-Henry <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Andrew Fuerste-Henry <[hidden email]> ---
It looks like it doesn't default to "father" specifically. It defaults to
whatever the first value in the syspref borrowerRelationship is. In the default
data, that's "father|mother." When I change it to "|father|mother," so the
first possible value is nothing, then it saves with no relationship.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

--- Comment #2 from David Roberts <[hidden email]> ---
(In reply to Andrew Fuerste-Henry from comment #1)
> It looks like it doesn't default to "father" specifically. It defaults to
> whatever the first value in the syspref borrowerRelationship is. In the
> default data, that's "father|mother." When I change it to "|father|mother,"
> so the first possible value is nothing, then it saves with no relationship.

That makes sense - I didn't notice that. However, on my system this is exactly
as delivered from the install, so I think that most people will probably find
that father is first. Either way, I think it is still incorrect behaviour.
Perhaps a sensible workaround might be to make the field required, so that you
can't leave it blank? I can't immediately think of a scenario where you
wouldn't want to specify what the relationship is.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

--- Comment #3 from Andrew Fuerste-Henry <[hidden email]> ---
I'd be hesitant to make any field hardcoded to be required, but can see why one
would want the option. And right now there's no way to make it required as
BorrowerMandatoryField only covers things in the borrowers table and guarantor
relationship has moved into the borrower_relationships table.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

--- Comment #4 from Katrin Fischer <[hidden email]> ---
If you make it mandatory or leave it - in both situations we will need an empty
value added to the pull down, so that it's a conscious choice. I think we
should add an empty value for now and a new bug for making it optionally
mandatory?

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

--- Comment #5 from David Roberts <[hidden email]> ---
(In reply to Katrin Fischer from comment #4)
> If you make it mandatory or leave it - in both situations we will need an
> empty value added to the pull down, so that it's a conscious choice. I think
> we should add an empty value for now and a new bug for making it optionally
> mandatory?

That sounds sensible - I'd be happy with that solution. At the moment, it looks
like there is a blank option, but it doesn't appear to be functional.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major

--- Comment #6 from Katrin Fischer <[hidden email]> ---
That's odd - after testing I see what you mean. There is an empty option in the
pull downs, but if you leave it empty, it still picks the first. Upping
severity a bit as this changes data unexpectedly (not quite data loss... but
similar)

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

Peter Vashchuk <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from Peter Vashchuk <[hidden email]> ---
Yes, there is <select> with 2 defined options: father and mother.
When I added empty <option> and tried to save the form I got 500 error "Invalid
relationship passed, '' is not defined.", because:

File: /Koha/Patron/Relationship.pm
53: Koha::Exceptions::Patron::Relationship::InvalidRelationship->throw(
54:   no_relationship => 1 )
55:   unless defined $self->relationship;
56:
57: Koha::Exceptions::Patron::Relationship::InvalidRelationship->throw(
58:   relationship => $self->relationship )
59:   unless any { $_ eq $self->relationship } @valid_relationships;

Which means there is no possibility to store empty relationship, as well any
relationship should be in @valid_relationships.

My proposal is to anyway append empty <option selected></option>, and then
either:
- if mandatory: perform form validation and force user to choose one of the
defined options,
- if relationship is not mandatory, then the code above (line 53-55) should be
changed to allow storing empty relationship (but I am not sure about business
logic)

I can implement any of these, but I need your expertise to decide which is the
correct one.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

Peter Vashchuk <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

--- Comment #8 from Katrin Fischer <[hidden email]> ---
I just tested this in 18.11 to be able to see how it was before the recent
changes. In 18.11 it's also not possible to set the relationship to an empty
value - I guess in this case we should make it mandatory?

Would be great to have Kyle's opinion on this maybe.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org

--- Comment #9 from Jonathan Druart <[hidden email]> ---
Why not simply select the first option of the select?

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

--- Comment #10 from David Roberts <[hidden email]> ---
(In reply to Jonathan Druart from comment #9)
> Why not simply select the first option of the select?

Because you don't *have* to select it - if you don't want a relationship and
select it then that's great - it'll do what you want. But if you don't want
want a relationship and don't select it because it already looks like the field
is already empty, it populates it with data incorrectly.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

--- Comment #11 from Jonathan Druart <[hidden email]> ---
If you have "|father|mother" in the pref (instead of the default
"father|mother"), then you can select the empty option, save, and it is kept
with "".
This behaviour answers your need.

The problematic situation is when "empty" is not in the pref list. In that case
we should select the first entry "father" and force the user to select a value.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

--- Comment #12 from Katrin Fischer <[hidden email]> ---
(In reply to Jonathan Druart from comment #9)
> Why not simply select the first option of the select?

And because it's error prone if you don't make people select something and just
assume something - especially in this case as everyone will turn out as a 'dad'

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

--- Comment #13 from Katrin Fischer <[hidden email]> ---
(In reply to Jonathan Druart from comment #11)
> If you have "|father|mother" in the pref (instead of the default
> "father|mother"), then you can select the empty option, save, and it is kept
> with "".
> This behaviour answers your need.
>
> The problematic situation is when "empty" is not in the pref list. In that
> case we should select the first entry "father" and force the user to select
> a value.

I don't think that's correct beahviour. Because we ship Koha with father|mother
and we already have an empty value displaying. The problem is that when you use
the empty value, father gets added to your record (the first entry). That's
clearly unexpected behaviour (select empty, get something else saved).

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

--- Comment #14 from Andrew Nugged <[hidden email]> ---
(In reply to Katrin Fischer from comment #13)
> I don't think that's correct beahviour. Because we ship Koha with
> father|mother and we already have an empty value displaying. The problem is
> that when you use the empty value, father gets added to your record (the
> first entry). That's clearly unexpected behaviour (select empty, get
> something else saved).

I support you and support what Peter proposed:

to append empty <option selected=selected></option>, but in code/DB to have
only two options, so validate:

and because of this to force the user to do conscious choice, not allowing
empty value to pass-through. Can it be the solution?

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

--- Comment #15 from Katrin Fischer <[hidden email]> ---
Do you mean to make the field mandatory with the empty selected not allowing
you to save? Then yes :)

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

Peter Vashchuk <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

--- Comment #16 from Peter Vashchuk <[hidden email]> ---
Created attachment 105419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105419&action=edit
Bug 25322: fix for don't default "relationship" dropdown to father

When you create a patron's guarantor on cgi-bin/koha/members/memberentry.pl but
don't select the relationship from a dropdown, the relationship defaults to
first default value, which in this case is father that may or may not be
correct as that is not a conscious choice from the user.
The solution is to make the "Relationship" field mandatory, starting with an
empty option but not allowing the user to save empty, so choice will be
conscious.

To reproduce:
    1) Create a new patron who is assumed to have a guarantor or modify the
existing one.
    2) Under "Guarantor Information" click on "Search to add" button. After
performing the search, select a user to act as guarantor. Don't use the
dropdown menu to select a relationship. Save your changes.
    3) Observe that relationship is set as "father".
    4) Apply the patch.
    5) Repeat steps 1 and 2.
    6) Observe that it doesn't allow you to save the form until you pick a
relationship type.

Mentored-by: Andrew Nugged <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

ByWater Sandboxes <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105419|0                           |1
        is obsolete|                            |

--- Comment #17 from ByWater Sandboxes <[hidden email]> ---
Created attachment 105420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105420&action=edit
Bug 25322: fix for don't default "relationship" dropdown to father

When you create a patron's guarantor on cgi-bin/koha/members/memberentry.pl but
don't select the relationship from a dropdown, the relationship defaults to
first default value, which in this case is father that may or may not be
correct as that is not a conscious choice from the user.
The solution is to make the "Relationship" field mandatory, starting with an
empty option but not allowing the user to save empty, so choice will be
conscious.

To reproduce:
    1) Create a new patron who is assumed to have a guarantor or modify the
existing one.
    2) Under "Guarantor Information" click on "Search to add" button. After
performing the search, select a user to act as guarantor. Don't use the
dropdown menu to select a relationship. Save your changes.
    3) Observe that relationship is set as "father".
    4) Apply the patch.
    5) Repeat steps 1 and 2.
    6) Observe that it doesn't allow you to save the form until you pick a
relationship type.

Mentored-by: Andrew Nugged <[hidden email]>

Signed-off-by: Holly Cooper <[hidden email]>

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

Holly <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

--- Comment #18 from Jonathan Druart <[hidden email]> ---
Did not we want to allow "no relationship"?

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

--- Comment #19 from Katrin Fischer <[hidden email]> ---
(In reply to Jonathan Druart from comment #18)
> Did not we want to allow "no relationship"?

It's not possible now, maybe we should discuss this as a future feature
separately.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

--- Comment #20 from David Roberts <[hidden email]> ---
(In reply to Jonathan Druart from comment #18)
> Did not we want to allow "no relationship"?

I can't really think of a use case for this. Anybody acting as guarantor must
have some sort of relationship with the guarantee, even if it is a non-familial
relationship. Couldn't users in any case create an auth value that covers "no
relationship" as an option?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|[hidden email]-communit |[hidden email]
                   |y.org                       |
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

--- Comment #21 from Jonathan Druart <[hidden email]> ---
QA, please test with "|father|mother" in the syspref.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

--- Comment #22 from Alex Arnaud <[hidden email]> ---
Agree with Andrew and Jonathan.

"|father|mother" in borrowerRelationship syspref allows to save unspecified
relationship.

As the main issue described here is "If no relationship is specified, then it
ought not to be populate", i have to say that i don't find any bug.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

--- Comment #23 from Alex Arnaud <[hidden email]> ---
However, it may not be very clear for users to set the syspref with an empty
value.

I would agree with a patch allowing empty value with the same in the syspref

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25322] Adding a guarantor with no relationship defaults to father

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

--- Comment #24 from Alex Arnaud <[hidden email]> ---
(In reply to Alex Arnaud from comment #23)
> I would agree with a patch allowing empty value with the same in the syspref

Without** the same in the syspref

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12