[Bug 25167] New: Fix to a fix wrong inventory results

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 25167] New: Fix to a fix wrong inventory results

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167

            Bug ID: 25167
           Summary: Fix to a fix wrong inventory results
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

Hi,

Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 solves the
case when notforloan filter is not used, but it breaks the case when a filter
is used.

Regards
Didier

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25167] Fix to a fix wrong inventory results

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25167] Fix to a fix wrong inventory results

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |12913

--- Comment #1 from Katrin Fischer <[hidden email]> ---
Hi didier, when adding a new bug and you know where the problem comes from or
which bug it's related to, you can use the "depends on" and "see also" to add a
link. This will also make sure people on the other bug get an email :)
Also the Importance preselects to enhancement - important to switch for bugs!


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913
[Bug 12913] Fix wrong inventory results
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25167] Fix not for loan filter in inventory tool

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Fix to a fix wrong          |Fix not for loan filter in
                   |inventory results           |inventory tool

--- Comment #2 from Katrin Fischer <[hidden email]> ---
Can you detail how the bheaviour is broken?

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25167] Fix not for loan filter in inventory tool

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167

--- Comment #3 from didier <[hidden email]> ---
Created attachment 105374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105374&action=edit
Bug 25167: Fix to a fix wrong inventory results

Test plan :
- Check you have in default framework an item subfield mapped with
items.notforloan and with an authorized value catergory,
  for example 'NOTFORLOAN'
- Create a new value in this category, for example '9'
- Create a biblio with default framework
- Create an item with barcode='000AAA1', callnumber='A-1' and notforloan=0
- Create an item with barcode='000AAA2', callnumber='A-2' and notforloan=9
- Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2'
- Go to inventory tool : /cgi-bin/koha/tools/inventory.pl
- Choose file in 'Barcode file'
- Enter item callnumber between 'A-0' and 'A-9'
- Check 'Compare barcodes list to results'
- Submit=> without patch, you get no warnings
- Redo the same inventory but with checking items.notforloan 'For loan'
  (using the browser back page is ok)
- submit => still no warning, Bug 000AAA2 must be listed it's not 'For loan'
- Apply patch, repeat, with tems.notforloan 'For loan' checked you get the
  right warning

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25167] Fix not for loan filter in inventory tool

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167

didier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |25608
             Status|NEW                         |Needs Signoff
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |om


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608
[Bug 25608] Regression: Bug 23463 broke inventory
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25167] Fix not for loan filter in inventory tool

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167

--- Comment #4 from Katrin Fischer <[hidden email]> ---
I am looking at the code, but not understanding it well enough to see if this
is the right fix. I wonder why we need no extra treatment for the other
available checkbox options (withdrawn, lost and damaged).

Leaving this for someone more familiar with inventory code in the QA team.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25167] Fix not for loan filter in inventory tool

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167

--- Comment #5 from didier <[hidden email]> ---
Hi,

Other available checkbox options (withdrawn, lost and damaged) weren't in the
list in the original functionality.

This patch only restore the previous behaviour, at least I hope so.

On the other hand not testing withdrawn, lost and so on doesn't seem to make
sense.

Regards
Didier

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/