[Bug 25133] New: Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

classic Classic list List threaded Threaded
47 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] New: Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

            Bug ID: 25133
           Summary: Specify Due date changes from PM to AM if library has
                    their TimeFormat set to 12hr
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]

Prior to 19.05.08, when due date was specified in the checkout, the time in the
box would show in 24hr format (e.g. 15:59) while the due date in the patron's
checkouts would show in 12hr format (e.g. 3:59 PM)
When using the specified due date in the same transaction,
- check an item out and the box would remain with 15:59 while the due date
would display 3:59 PM
- check a second item out and the box would continue to display 15:59 and the
due date 3:59 PM

After 19.05.08, the format in the specify a due date box shows in 24hr format
and the due date in 12hr format (in patron checkouts) as before.

However, on the second transaction, the box converts to 3:59 AM and that time
will be 3:59 AM on the patron's checkout.


This process only occurs if the library is using the TimeFormat at 12 hours in
the system preferences and not 24 hours in the TIme format.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Azucena Aguayo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Azucena Aguayo <[hidden email]> ---
12 hour format is easier for our staff to read.

We would appreciate if this bug could be fixed to restore the functionality we
had prior to the 19.05.08 update.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|19.05                       |master
                 CC|                            |martin.renvoize@ptfs-europe
                   |                            |.com,
                   |                            |[hidden email]

--- Comment #2 from Nick Clemens <[hidden email]> ---
Confirmed on master

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_20_05_candidate

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

--- Comment #3 from Jonathan Druart <[hidden email]> ---
Created attachment 103137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103137&action=edit
Bug 25133: Fix time part of due date for 12hr

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org
             Status|Needs Signoff               |In Discussion

--- Comment #4 from Jonathan Druart <[hidden email]> ---
Restoring the previous behaviour would be a regression in my opinion.
I think this patch is the correct way to fix it (ie. always display 12hr
format)

Nick, can you give it a try before I request a signoff please?

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

--- Comment #5 from Nick Clemens <[hidden email]> ---
(In reply to Jonathan Druart from comment #4)
> Restoring the previous behaviour would be a regression in my opinion.
> I think this patch is the correct way to fix it (ie. always display 12hr
> format)
>
> Nick, can you give it a try before I request a signoff please?

In testing, all of my times are now AM

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

--- Comment #6 from Jonathan Druart <[hidden email]> ---
(In reply to Nick Clemens from comment #5)
> (In reply to Jonathan Druart from comment #4)
> > Restoring the previous behaviour would be a regression in my opinion.
> > I think this patch is the correct way to fix it (ie. always display 12hr
> > format)
> >
> > Nick, can you give it a try before I request a signoff please?
>
> In testing, all of my times are now AM

Hum, looks like it's a bug in master actually.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

--- Comment #7 from Jonathan Druart <[hidden email]> ---
(In reply to Jonathan Druart from comment #6)

> (In reply to Nick Clemens from comment #5)
> > (In reply to Jonathan Druart from comment #4)
> > > Restoring the previous behaviour would be a regression in my opinion.
> > > I think this patch is the correct way to fix it (ie. always display 12hr
> > > format)
> > >
> > > Nick, can you give it a try before I request a signoff please?
> >
> > In testing, all of my times are now AM
>
> Hum, looks like it's a bug in master actually.

Forget that, wrong git branch!

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

--- Comment #8 from Jonathan Druart <[hidden email]> ---
Created attachment 103236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103236&action=edit
Bug 25133: Handle 12hr format for dt_from_string

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16780

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #103137|0                           |1
        is obsolete|                            |
 Attachment #103236|0                           |1
        is obsolete|                            |

--- Comment #9 from Nick Clemens <[hidden email]> ---
Created attachment 103366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103366&action=edit
Bug 25133: Fix time part of due date for 12hr

Signed-off-by: Nick Clemens <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

--- Comment #10 from Nick Clemens <[hidden email]> ---
Created attachment 103367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103367&action=edit
Bug 25133: Handle 12hr format for dt_from_string

Signed-off-by: Nick Clemens <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

--- Comment #11 from Nick Clemens <[hidden email]> ---
Created attachment 103368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103368&action=edit
Bug 25133: (follow-up) Remove Names as they do no affect display

In testing I couldn't make any changes to the names have an effect
and everythign worked as expected without these lines

Signed-off-by: Nick Clemens <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

ByWater Sandboxes <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #103366|0                           |1
        is obsolete|                            |

--- Comment #12 from ByWater Sandboxes <[hidden email]> ---
Created attachment 103369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103369&action=edit
Bug 25133: Fix time part of due date for 12hr

Signed-off-by: Nick Clemens <[hidden email]>

Signed-off-by: Kelly McElligott <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

ByWater Sandboxes <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #103367|0                           |1
        is obsolete|                            |

--- Comment #13 from ByWater Sandboxes <[hidden email]> ---
Created attachment 103370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103370&action=edit
Bug 25133: Handle 12hr format for dt_from_string

Signed-off-by: Nick Clemens <[hidden email]>

Signed-off-by: Kelly McElligott <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

ByWater Sandboxes <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #103368|0                           |1
        is obsolete|                            |

--- Comment #14 from ByWater Sandboxes <[hidden email]> ---
Created attachment 103371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103371&action=edit
Bug 25133: (follow-up) Remove Names as they do no affect display

In testing I couldn't make any changes to the names have an effect
and everythign worked as expected without these lines

Signed-off-by: Nick Clemens <[hidden email]>

Signed-off-by: Kelly McElligott <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

--- Comment #15 from Jonathan Druart <[hidden email]> ---
Nick, Kelly, could you detail what you have tried?

This patch will affect all date inputs so we need quite intensive testing.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

--- Comment #16 from Katrin Fischer <[hidden email]> ---
This works but wondering - is it expected that we only allow to add tags with
emojis from the detail page, but not from the result list?

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

--- Comment #17 from Katrin Fischer <[hidden email]> ---
(In reply to Katrin Fischer from comment #16)
> This works but wondering - is it expected that we only allow to add tags
> with emojis from the detail page, but not from the result list?

Oviously wrong bug.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

--- Comment #18 from Katrin Fischer <[hidden email]> ---
I know this is a bad bug... but why is there no test plan in the commits and no
proper descriptions? :(

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]-c
                   |ity.org                     |ommunity.org

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #103369|0                           |1
        is obsolete|                            |

--- Comment #19 from Katrin Fischer <[hidden email]> ---
Created attachment 104228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104228&action=edit
Bug 25133: Fix time part of due date for 12hr

With Timeformat system preference set to 12 hours format:

Prior to 19.05.08, when due date was specified at checkout,
the time in the box would show in 24hr format (e.g. 15:59)
while the due date in the patron's checkouts would show
in 12hr format (e.g. 3:59 PM).

After 19.05.08, the format in the specify a due date box
shows in 24hr format and the due date in 12hr format
(in patron checkouts) as before.

But when checking out multiple items using the specify due
date option for the session, the time changes from PM to
AM.

To test:
- Check out an item with specified due date 15:50 PM
- Check out a second item in same transaction
- Verify date changed to AM
- Apply patch
- Repeat
- Verify this time the date is kept as set

Signed-off-by: Nick Clemens <[hidden email]>

Signed-off-by: Kelly McElligott <[hidden email]>

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #103370|0                           |1
        is obsolete|                            |

--- Comment #20 from Katrin Fischer <[hidden email]> ---
Created attachment 104229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104229&action=edit
Bug 25133: Handle 12hr format for dt_from_string

Signed-off-by: Nick Clemens <[hidden email]>

Signed-off-by: Kelly McElligott <[hidden email]>

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #103371|0                           |1
        is obsolete|                            |

--- Comment #21 from Katrin Fischer <[hidden email]> ---
Created attachment 104230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104230&action=edit
Bug 25133: (follow-up) Remove Names as they do no affect display

In testing I couldn't make any changes to the names have an effect
and everythign worked as expected without these lines

Signed-off-by: Nick Clemens <[hidden email]>

Signed-off-by: Kelly McElligott <[hidden email]>

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12