[Bug 24842] New: Automatic serials missing list feeding does not work when the numbering sequence includes regexp specific characters

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 24842] New: Automatic serials missing list feeding does not work when the numbering sequence includes regexp specific characters

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24842

            Bug ID: 24842
           Summary: Automatic serials missing list feeding does not work
                    when the numbering sequence includes regexp specific
                    characters
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Serials
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

We can encounter this issue, when we choose to automatically feed the serials
missing list of a subscription (Manual history is uncheck in the subcription
planning form).
When setting or removing the missing status to a serial issue in the staff
interface, the process in the code of adding the issue numering sequence or
removing it from  the missinglist is based on some regular expression.
It's not uncommon that librarians use characters like parenthesis in this
sequence, for exemple to add year detail :
No 236 (2019)
We can even fall upon + or * characters.
The consequence is that they are interpreted by the regexp as capturing
characters rather then litterals and this causes the process to fail. The
result is the creation of multiple doubles in the missing list.

This patch aims to solve the problem

Test plan :

To go faster, choose an existing subscription, click on "Edit/Edit as
new(duplicate)"
Uncheck Manual history and go to next page
Choose whatever simple config for this new subscription
Exemple :
Frequency : 1/month
Subscription length : 12
Subscription start date : 01/01/2020
Subscription end date : nothing
Numbering pattern : Volume, number
Last value
    volume :2019
    number : 1

Click on "Hide advanced pattern" then "Modify pattern"
In the "Numbering formula pattern" zone, add parenthesis around {X}:
   Vol({X}), No {Y}
or an other critical character like + :
   Vol ({X}), No {Y} + suppl.
Fullfill the "Pattern name" : MyTest
Save as new pattern
Test prediction pattern
Save subscription

1) Receive one or two issues on this subscription
2) For the next expected one, set to any missing status rather than arrived one
3) Go to check the missing list in the summary tab of subscription :
   you can see that the issue had not been added to the list.

Install the patch

1) go back to Receive page and set the expected issue as missing.
2) go back to check the missing list : now the issue number is in the list
3) go back to Receive page and set the last missing issue as arrived.
4) go back to missing list : the issue had been removed.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24842] Automatic serials missing list feeding does not work when the numbering sequence includes regexp specific characters

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24842

Koha Team University Lyon 3 <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Koha Team University Lyon 3 <[hidden email]> ---
Created attachment 100462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100462&action=edit
Bug 24842 Regexp issue create doubles in the serial missing list

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24842] Automatic serials missing list feeding does not work when the numbering sequence includes regexp specific characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24842

Koha Team University Lyon 3 <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Priority|P5 - low                    |P2

--- Comment #2 from Koha Team University Lyon 3 <[hidden email]> ---
I have to add that this bug is already present in 18.11 and maybe in previuous
ones

Olivier Crouzet

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24842] Automatic serials missing list feeding does not work when the numbering sequence includes regexp specific characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24842

--- Comment #3 from Koha Team University Lyon 3 <[hidden email]> ---
Sorry, an error in my test plan

NEW TEST PLAN :

Test plan :

To go faster, choose an existing subscription, click on "Edit/Edit as
new(duplicate)"
Uncheck Manual history and go to next page
Choose whatever simple config for this new subscription
Exemple :
Frequency : 1/month
Subscription length : 12
Subscription start date : 01/01/2020
Subscription end date : nothing
Numbering pattern : Volume, number
Last value
    volume :2019
    number : 1

Click on "Hide advanced pattern" then "Modify pattern"
In the "Numbering formula pattern" zone, add parenthesis around {X}:
   Vol({X}), No {Y}
or an other critical character like + :
   Vol ({X}), No {Y} + suppl.
Fullfill the "Pattern name" : MyTest
Save as new pattern
Test prediction pattern
Save subscription

1) Receive one or two issues on this subscription
2) For the next expected one, set to any missing status rather than arrived one
3) Modify the missing status to another missing status.
3) Go to check the missing list in the summary tab of subscription :
   the issue had been added to the list. You could think, it's ok but the
reason is that the list was empt.
4) If you go back to set the same issue to another type of missing status, you
will discover that it had been added a second time to the list.
4) if you set the missing status to "arrived", you will see that the sequences
had not been removed from the missing list.

Install the patch

1) go back to Receive page and set the expected issue as missing.
2) go back to check the missing list : now the issue number is in the list
3) go back to Receive page and set the last missing issue as arrived.
4) go back to missing list : the issue had been removed

Olivier

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24842] Automatic serials missing list feeding does not work when the numbering sequence includes regexp specific characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24842

Koha Team University Lyon 3 <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100462|0                           |1
        is obsolete|                            |

--- Comment #4 from Koha Team University Lyon 3 <[hidden email]> ---
Created attachment 100635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100635&action=edit
Bug 24842 Regexp issue create doubles in the serial missing list

the "delete issue" aspect (sub DelIssue) of the process was still uncorrectly
handled. I synchronized it with the rest.
... and redo my test plan again (...)

FINAL TEST PLAN (I hope so !) :
-------------------------------
To go faster, choose an existing subscription, click on "Edit/Edit as
new(duplicate)"
Uncheck Manual history and go to next page
Choose whatever simple config for this new subscription
Exemple :
Frequency : 1/month
Subscription length : 12
Subscription start date : 01/01/2020
Subscription end date : nothing
Numbering pattern : Volume, number
Last value
    volume :2019
    number : 1

Click on "Hide advanced pattern" then "Modify pattern"
In the "Numbering formula pattern" zone, add parenthesis around {X}:
   Vol({X}), No {Y}
or an other critical character like + :
   Vol ({X}), No {Y} + suppl.
Fullfill the "Pattern name" : MyTest
Save as new pattern
Test prediction pattern
Save subscription

1) Receive one or two issues on this subscription
2) For the next expected one, set to any missing status rather than arrived one
3) Go to check the missing list in the summary tab of subscription :
   the issue had been added to the list.
4) If you go back to set the same issue to another type of missing status, you
will discover that it had been added a second time to the list.
5) if you set the missing status to "arrived", you will see that the sequences
had not been removed from the missing list.

Install the patch
clear manually the missing list from added issues.
redo 1 to 5 steps
You 'll see that issues are correctly added (and only one time) when tey have
to and correctly repoved.

If you delete an issue with missing status, you'll see that it's deleted from
the list as well


Olivier Crouzet

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24842] Automatic serials missing list feeding does not work when the numbering sequence includes regexp specific characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24842

Fridolin SOMERS <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |m
 Attachment #100635|0                           |1
           is patch|                            |
 Attachment #100635|application/mbox            |text/plain
          mime type|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24842] Automatic serials missing list feeding does not work when the numbering sequence includes regexp specific characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24842

--- Comment #5 from Claudie Trégouët <[hidden email]> ---
Created attachment 102702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102702&action=edit
Bug 24842 regexp issue create serial missing list doubles

Signed-off-by: Claudie Trégouët <[hidden email]>

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24842] Automatic serials missing list feeding does not work when the numbering sequence includes regexp specific characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24842

Claudie Trégouët <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |[hidden email]
                   |                            |om

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24842] Automatic serials missing list feeding does not work when the numbering sequence includes regexp specific characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24842

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #6 from Katrin Fischer <[hidden email]> ---
I think this might be fixed by bug 24903 that I just passed QA - could you
check and see if it helps your cause? It moves the logic into a new internal
method, which looks like a good approach to me.

First tests are looking good.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24842] Automatic serials missing list feeding does not work when the numbering sequence includes regexp specific characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24842

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24842] Automatic serials missing list feeding does not work when the numbering sequence includes regexp specific characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24842

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24903

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24842] Automatic serials missing list feeding does not work when the numbering sequence includes regexp specific characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24842

--- Comment #7 from Koha Team University Lyon 3 <[hidden email]> ---
(In reply to Katrin Fischer from comment #6)
> I think this might be fixed by bug 24903 that I just passed QA - could you
> check and see if it helps your cause? It moves the logic into a new internal
> method, which looks like a good approach to me.
>
> First tests are looking good.

Hey Katrin,

At a first glance, it could help but it deals only with parenthesis case. I
already fell upon sequences that were including  + and * characters (my
colleagues are very creative) and I don't despair of finding out some $ one
day.
I saw the comment "maybe extend in future" so I hope we are already in the
future...

Olivier Crouzet

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/