[Bug 24772] New: Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts Course Reserve Values

classic Classic list List threaded Threaded
44 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] New: Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts Course Reserve Values

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

            Bug ID: 24772
           Summary: Deactivating Course Reserves reverts Item's Shelving
                    Location, then deleting the same course reverts Course
                    Reserve Values
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Course reserves
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

Deactivating a from Course Reserves reverts Item's Shelving Location correctly,
then deleting the same course reverts the Course Reserve Items to old shelving
location values.

To Recreate:

1. Add items to a Course - make sure they all have shelving locations prior to
being added to the course.

2. When adding items change their shelving location to something else.

a. See that Shelving Location has changed; permanent location in parentheses
4. Deactivated course
a. See that Shelving Location has changed back to its original location
5. Deleted course
a. See that Shelving Location has changed back to what was picked during adding
it to the Course.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts Course Reserve Values

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

Hannah Olsen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

--- Comment #1 from Hannah Olsen <[hidden email]> ---
At my library we use Course Reserves regularly to manage our displays so that
we can change the shelving location and have it change back automatically. We
found the bug while trying to figure out why things that had been on display
weren't moving back to their original shelving locations.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23727

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

--- Comment #2 from Katrin Fischer <[hidden email]> ---
I think this might be duplicate to bug 23727

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

--- Comment #3 from Hannah Olsen <[hidden email]> ---
(In reply to Katrin Fischer from comment #2)
> I think this might be duplicate to bug 23727

We saw that one, but that bug involves trying to edit items within the course
reserve and have those changes reflected in the reserve without removing the
item and re-adding it. The behavior here is related to deactivating and
deleting courses and what happens to the values that were changed in the
reserves module.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

--- Comment #4 from Hannah Olsen <[hidden email]> ---
(In reply to Hannah Olsen from comment #3)
> (In reply to Katrin Fischer from comment #2)
> > I think this might be duplicate to bug 23727
>
> We saw that one, but that bug involves trying to edit items within the
> course reserve and have those changes reflected in the reserve without
> removing the item and re-adding it. The behavior here is related to
> deactivating and deleting courses and what happens to the values that were
> changed in the reserves module.

Reviewing that bug again and some of the later info, maybe it is related to the
same problematic table?

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
           Severity|minor                       |major
         Depends on|                            |23727

--- Comment #5 from Katrin Fischer <[hidden email]> ---
Hi Kelly, I have retestet this, but I think even with the recent work on course
reserves there is still a bug here. Maybe you can confirm?

To Recreate:

1. Add items to a Course - make sure they all have shelving locations prior to
being added to the course.

2. When adding items change their shelving location to something else.

a. See that Shelving Location has changed; permanent location in parentheses
4. Deactivated course
a. See that Shelving Location has changed back to its original location
5. Deleted course

Old problem:
a. See that Shelving Location has changed back to what was picked during adding
it to the Course.

New problem:
a. has changed for me, instead of showing the 'course reserves' location, the
location is emtpy now.

I am updating severity, as this is a data loss bug and the workflow appears
pretty standard - first disable, then delete...


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727
[Bug 23727] Editing course reserve items is broken
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|19.05                       |master

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts/empties Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Deactivating Course         |Deactivating Course
                   |Reserves reverts Item's     |Reserves reverts Item's
                   |Shelving Location, then     |Shelving Location, then
                   |deleting the same course    |deleting the same course
                   |reverts Course Reserve      |reverts/empties Course
                   |Values                      |Reserve Values

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts/empties Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |blocker

--- Comment #6 from Katrin Fischer <[hidden email]> ---
Updating severity again - I tried with other changed values and it will kill
them all:

- change values for reserve item
- disable course reserve
- delete course reserve

collection, location and holding branch were lost and are now longer set.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts/empties Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts/empties Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

--- Comment #7 from Kyle M Hall <[hidden email]> ---
Created attachment 103953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103953&action=edit
Bug 24772: Don't revert course item fields when deleting a course item unless
it is enabled

Deactivating a from Course Reserves reverts Item's Shelving Location
correctly, then deleting the same course reverts the Course Reserve
Items to old shelving location values.

Test Plan:
1) Add items to a Course - make sure they all have shelving locations
prior to being added to the course.
2) When adding items change their shelving location to something else.
   See that Shelving Location has changed; permanent location in
parentheses
3) Deactivated course
   See that Shelving Location has changed back to its original location
4) Deleted course
   See that Shelving Location has changed back to what was picked during
adding it to the Course.
5) Apply this patch, restart all the things!
6) Repeat steps 1-4, note the shelvig location is not lost!

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts/empties Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

Victor Grousset/tuxayo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #8 from Victor Grousset/tuxayo <[hidden email]> ---
> 4) Deleted course
>   See that Shelving Location has changed back to what was picked during
> adding it to the Course.

In my case it got changed to nothing. Is it expected?
Should the test plan be amended?

> 6) Repeat steps 1-4, note the shelvig location is not lost!

Indeed it works :D

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts/empties Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

--- Comment #9 from Hannah Olsen <[hidden email]> ---

> > 4) Deleted course
> >   See that Shelving Location has changed back to what was picked during
> > adding it to the Course.
>
> In my case it got changed to nothing. Is it expected?
> Should the test plan be amended?
>
> > 6) Repeat steps 1-4, note the shelvig location is not lost!
>
> Indeed it works :D

Does it keep it as the original location (previous to the Course) or does it
change it back to what was picked during adding to Course?

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts/empties Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

--- Comment #10 from Victor Grousset/tuxayo <[hidden email]> ---
original location

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts/empties Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

--- Comment #11 from Katrin Fischer <[hidden email]> ---
If the location was empty before the item was added to the course, it should be
empty after the deleting the course too.

If the location was set before, it should have the same value again in the end.

This applies to all item values that were changed while it was in the course
reserve, you need to end up with the same item values as before.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts/empties Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

--- Comment #12 from Victor Grousset/tuxayo <[hidden email]> ---
test note: Do not re-enable the course, it won't reproduce the bug.
> 3) Deactivated course
>    See that Shelving Location has changed back to its original location
> 4) Deleted course
>    See that Shelving Location has changed back to what was picked during
> adding it to the Course.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts/empties Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

--- Comment #13 from Victor Grousset/tuxayo <[hidden email]> ---
Katrin:
> If the location was empty before the item was added to the course,
> it should be  empty after the deleting the course too.

Retried: the patch works well in this case too.

Unexpected behavior of comment 8 still happens.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts/empties Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #14 from Katrin Fischer <[hidden email]> ---
If a location that was set before, is not returned (that's comment#8?) then we
should set this to Failed QA to alert Kyle.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts/empties Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

--- Comment #15 from Victor Grousset/tuxayo <[hidden email]> ---
Sorry for the confusion. It was an unexpected behavior in the test plan.

That step is in reproducing the bug. A problem still occurs, but not the one
described.
Sometimes when that happen that doesn't prevent me from signing off when it's
clear that the patch works. And sometimes I wait and ask for confirmation. It
depend of how big the difference from was I got and the test plan is.
It's a bit confusing, I haven't settled yet for a more clear strategy.

In this case thanks to the patch, I couldn't reproduce
- the issue from the test plan
- or the one I actually got when testing without patch.

So it seems ok. Should I sign off? Another factor is that I didn't see a hurry
on this patch related to the feature freeze. So I could be picky about
unexpected stuff ^^

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts/empties Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

--- Comment #16 from Katrin Fischer <[hidden email]> ---
I had different finding than Kelly when testing this (comment 0 vs. comment 5),
I think if you agree that the results are now as you would expect, you could
sign off with a comment.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts/empties Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

Victor Grousset/tuxayo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #103953|0                           |1
        is obsolete|                            |

--- Comment #17 from Victor Grousset/tuxayo <[hidden email]> ---
Created attachment 104085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104085&action=edit
Bug 24772: Don't revert course item fields when deleting a course item unless
it is enabled

Deactivating a from Course Reserves reverts Item's Shelving Location
correctly, then deleting the same course reverts the Course Reserve
Items to old shelving location values.

Test Plan:
1) Add items to a Course - make sure they all have shelving locations
prior to being added to the course.
2) When adding items change their shelving location to something else.
   See that Shelving Location has changed; permanent location in
parentheses
3) Deactivated course
   See that Shelving Location has changed back to its original location
4) Deleted course
   See that Shelving Location has changed back to what was picked during
adding it to the Course.
5) Apply this patch, restart all the things!
6) Repeat steps 1-4, note the shelvig location is not lost!

Signed-off-by: Victor Grousset/tuxayo <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts/empties Course Reserve Values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

Victor Grousset/tuxayo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #18 from Victor Grousset/tuxayo <[hidden email]> ---
IIUC what I got in comment 8 is the same thing as what Katrin describes in
comment 5.

> a. has changed for me, instead of showing the 'course reserves' location, the location is emtpy now.



> I think if you agree that the results are now as you would expect, you could sign off with a comment.

Thanks for the green light! :)

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating course reserves before deleting the same course empties course reserve values in the items

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Deactivating Course         |Deactivating course
                   |Reserves reverts Item's     |reserves before deleting
                   |Shelving Location, then     |the same course empties
                   |deleting the same course    |course reserve values in
                   |reverts/empties Course      |the items
                   |Reserve Values              |
             Status|Signed Off                  |Failed QA
         QA Contact|[hidden email]-communit |[hidden email]
                   |y.org                       |

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating course reserves before deleting the same course empties course reserve values in the items

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating course reserves before deleting the same course empties course reserve values in the items

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

--- Comment #19 from Katrin Fischer <[hidden email]> ---
Hm, I've amended Kyle's test plan slightly. In my experience it did not revert
to the course reserve value but was emptied. It might have got lost in the
comments here as the problem presented differently before.

I think we should push the fix, but I'd really love to see tests here - we
should make sure this doesn't get a chance to come back unnoticed.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating course reserves before deleting the same course empties course reserve values in the items

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating course reserves before deleting the same course empties course reserve values in the items

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104085|0                           |1
        is obsolete|                            |

--- Comment #20 from Katrin Fischer <[hidden email]> ---
Created attachment 104098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104098&action=edit
Bug 24772: Don't revert course item fields when deleting a course item unless
it is enabled

Deactivating a from Course Reserves reverts Item's Shelving Location
correctly, then deleting the same course reverts the Course Reserve
Items to old shelving location values.

Test Plan:
1) Add items to a Course - make sure they all have shelving locations
prior to being added to the course.
2) When adding items change their shelving location to something else.
   See that Shelving Location has changed; permanent location in
parentheses
3) Deactivated course
   See that Shelving Location has changed back to its original location
4) Deleted course
   See that Shelving Loction is now empty/wrong
5) Apply this patch, restart all the things!
6) Repeat steps 1-4, note the shelvig location is not lost!

Signed-off-by: Victor Grousset/tuxayo <[hidden email]>

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24772] Deactivating course reserves before deleting the same course empties course reserve values in the items

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772

ByWater Sandboxes <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104098|0                           |1
        is obsolete|                            |

--- Comment #21 from ByWater Sandboxes <[hidden email]> ---
Created attachment 104106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104106&action=edit
Bug 24772: Don't revert course item fields when deleting a course item unless
it is enabled

Deactivating a from Course Reserves reverts Item's Shelving Location
correctly, then deleting the same course reverts the Course Reserve
Items to old shelving location values.

Test Plan:
1) Add items to a Course - make sure they all have shelving locations
prior to being added to the course.
2) When adding items change their shelving location to something else.
   See that Shelving Location has changed; permanent location in
parentheses
3) Deactivated course
   See that Shelving Location has changed back to its original location
4) Deleted course
   See that Shelving Location has changed back to what was picked during
adding it to the Course.
5) Apply this patch, restart all the things!
6) Repeat steps 1-4, note the shelvig location is not lost!

Signed-off-by: Victor Grousset/tuxayo <[hidden email]>

Signed-off-by: Hannah Olsen <[hidden email]>

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12