[Bug 24718] New: Introduce hour-based holds

classic Classic list List threaded Threaded
63 messages Options
123
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] New: Introduce hour-based holds

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

            Bug ID: 24718
           Summary: Introduce hour-based holds
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

Some libraries would like to be able to specify the hours which an item will be
reserved for (think: 'booking'), for example with 2-hour loans.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |
  Change sponsored?|---                         |Sponsored
             Status|NEW                         |ASSIGNED

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #1 from Aleisha Amohia <[hidden email]> ---
Created attachment 99540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99540&action=edit
Bug 24718: Introducing HourBasedHolds system preference

Sponsored-by: Waikato Institute of Technology

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #2 from Aleisha Amohia <[hidden email]> ---
Created attachment 99541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99541&action=edit
Bug 24718: Get reservedate and expirationdate to use datetime

Sponsored-by: Waikato Institute of Technology

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #3 from Aleisha Amohia <[hidden email]> ---
Created attachment 99542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99542&action=edit
Bug 24718: Get templates working with HourBasedHolds

Sponsored-by: Waikato Institute of Technology

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #4 from Aleisha Amohia <[hidden email]> ---
Created attachment 99543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99543&action=edit
Bug 24718: Get OPAC working with datetimepicker and HourBasedHolds

Sponsored-by: Waikato Institute of Technology

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #5 from Aleisha Amohia <[hidden email]> ---
Created attachment 99544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99544&action=edit
Bug 24718: Adding notice to be sent when cancelling holds

Sponsored-by: Waikato Institute of Technology

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #6 from Aleisha Amohia <[hidden email]> ---
Created attachment 99545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99545&action=edit
Bug 24718: Send notice when cancelling a hold from intranet

Sponsored-by: Waikato Institute of Technology

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from Katrin Fischer <[hidden email]> ---
Hi Aleisha, just reading the commit subjects I wonder if the notice for
cancelling holds could be a separate feature?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #8 from Aleisha Amohia <[hidden email]> ---
(In reply to Katrin Fischer from comment #7)
> Hi Aleisha, just reading the commit subjects I wonder if the notice for
> cancelling holds could be a separate feature?

Not really, the sending of notices was part of the feature we wrote for this
library and depends on a syspref that this feature introduces. This will be
explain in the test plan I'm currently writing

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #9 from Katrin Fischer <[hidden email]> ---
Ok thx - I was thinking of something like bug 20453.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #10 from Aleisha Amohia <[hidden email]> ---
Hmm I see. I guess could obselete the final two patches here and put them on
Bug 24053 so that the notice is always sent, without depending on a syspref

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20453

--- Comment #11 from Katrin Fischer <[hidden email]> ---
If it goes the direction of the other bug, I think not having it necessarily
depend on hourly loans would be nice. Maybe we could also do it later. I am
adding a see also for now and will let you think it over to what works best
here (don't know much about the feature written yet!) :)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99544|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99545|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #12 from Aleisha Amohia <[hidden email]> ---
The library wanted the ability to specify hours when reserving items for
patrons, and be able to cancel those reserves - a process of 'booking'
something for a few hours, with the ability to reject (cancel) the booking. The
patron would then be notified if the reserve was rejected/cancelled by the
library (this part is handled in Bug 20453). The cancel_expired_holds.pl
cronjob can be run hourly to work with this feature.

The library only needed the hour-based holds functionality on the staff side as
their patrons can't placed holds via the OPAC (RequestOnOpac disabled) but I
have put the functionality on the OPAC side for the option.

Test plan for Bug 24718: hour-based holds

You will need two borrowers (Borrower A and B) and a record with items (Biblio
A)

1) Update database, restart memcached
2) Enable the following sysprefs: RequestOnOpac, AllowHoldDateInFuture,
OPACAllowHoldDateInFuture, HourBasedHolds
3) Log into the OPAC as Borrower A
4) Find Biblio A
5) Click 'Place a reserve'
6) Click 'Show more options'
7) Try entering dates in the 'starts on' field and 'not needed after' field.
Notice you can also enter a time. Leave the start date empty and choose a
specific end date/time. Confirm the hold
8) Confirm the hold is saved with the reserve date set to today/now and the
expiry date is saved as specified. Notice the time selection is shown.
9) Log into the staff interface
10) Find Biblio A and place a hold for Borrower B
11) Try entering dates in the 'starts on' field and 'expires on' field. Notice
you can also enter a time. Specify a future start date. Confirm the hold
12) Confirm your selected date and time shows in the confirmed hold. View all
of the pages that show holds and confirm they all show the date and time
correctly.

Sponsored-by: Waikato Institute of Technology

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #13 from Aleisha Amohia <[hidden email]> ---
Tests coming

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20453


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453
[Bug 20453] Send notification when hold is cancelled by librarian
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #14 from Aleisha Amohia <[hidden email]> ---
Created attachment 99548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99548&action=edit
Bug 24718: Ensuring tests pass

Confirm these tests pass before and after applying patches

t/db_dependent/Holds.t
t/db_dependent/Circulation.t
t/db_dependent/Circulation/issue.t
t/db_dependent/Holds/HoldFulfillmentPolicy.t
t/db_dependent/Holds/LocalHoldsPriority.t
t/db_dependent/Holds/HoldItemtypeLimit.t
t/db_dependent/Holds/RevertWaitingStatus.t
t/db_dependent/HoldsQueue.t
t/db_dependent/Reserves/CancelExpiredReserves.t

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #15 from Aleisha Amohia <[hidden email]> ---
(In reply to Aleisha Amohia from comment #12)

> The library wanted the ability to specify hours when reserving items for
> patrons, and be able to cancel those reserves - a process of 'booking'
> something for a few hours, with the ability to reject (cancel) the booking.
> The patron would then be notified if the reserve was rejected/cancelled by
> the library (this part is handled in Bug 20453). The cancel_expired_holds.pl
> cronjob can be run hourly to work with this feature.
>
> The library only needed the hour-based holds functionality on the staff side
> as their patrons can't placed holds via the OPAC (RequestOnOpac disabled)
> but I have put the functionality on the OPAC side for the option.
>
> Test plan for Bug 24718: hour-based holds
>
> You will need two borrowers (Borrower A and B) and a record with items
> (Biblio A)
>
> 1) Update database, restart memcached

Remember to update dbix files!

> 2) Enable the following sysprefs: RequestOnOpac, AllowHoldDateInFuture,
> OPACAllowHoldDateInFuture, HourBasedHolds
> 3) Log into the OPAC as Borrower A
> 4) Find Biblio A
> 5) Click 'Place a reserve'
> 6) Click 'Show more options'
> 7) Try entering dates in the 'starts on' field and 'not needed after' field.
> Notice you can also enter a time. Leave the start date empty and choose a
> specific end date/time. Confirm the hold
> 8) Confirm the hold is saved with the reserve date set to today/now and the
> expiry date is saved as specified. Notice the time selection is shown.
> 9) Log into the staff interface
> 10) Find Biblio A and place a hold for Borrower B
> 11) Try entering dates in the 'starts on' field and 'expires on' field.
> Notice you can also enter a time. Specify a future start date. Confirm the
> hold
> 12) Confirm your selected date and time shows in the confirmed hold. View
> all of the pages that show holds and confirm they all show the date and time
> correctly.
>
> Sponsored-by: Waikato Institute of Technology

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Needs Signoff               |Failed QA

--- Comment #16 from David Nind <[hidden email]> ---
Hi Aleisha.

Everything seems to work as expected according to the test plan.

There is one failed test though (after the patch is applied):

root@40629b80bd10:koha(bz24718)$ prove t/db_dependent/Holds.t
t/db_dependent/Holds.t .. 1/61
#   Failed test 'holds_placed_today should return a valid borrowernumber'
#   at t/db_dependent/Holds.t line 104.
#          got: '247'
#     expected: '246'
t/db_dependent/Holds.t .. 61/61 # Looks like you failed 1 test of 61.
t/db_dependent/Holds.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/61 subtests

Test Summary Report
-------------------
t/db_dependent/Holds.t (Wstat: 256 Tests: 61 Failed: 1)
  Failed test:  8
  Non-zero exit status: 1
Files=1, Tests=61,  7 wallclock secs ( 0.04 usr  0.00 sys +  5.63 cusr  0.52
csys =  6.19 CPU)
Result: FAIL

In addition, there is also an error happening after the patches are applied
when you go the patrons details page and the holds tab:

> DataTables warning: table id=holds-table - Ajax error. For more information
> about this error, please see http://datatables.net/tn/7

I've reported this error before on bug 24769 - it only seems to happen for me
when testing ILS-DI bugs, but is now happening for this bug as well.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #17 from Aleisha Amohia <[hidden email]> ---
Created attachment 103521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103521&action=edit
Bug 24718: (follow-up) Removing old code

This solves the JS error

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #18 from Aleisha Amohia <[hidden email]> ---
Created attachment 103522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103522&action=edit
Bug 24718: (follow-up) Updated schema file

For sandboxes

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99540|0                           |1
        is obsolete|                            |

--- Comment #19 from David Nind <[hidden email]> ---
Created attachment 103549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103549&action=edit
Bug 24718: Introducing HourBasedHolds system preference

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99541|0                           |1
        is obsolete|                            |

--- Comment #20 from David Nind <[hidden email]> ---
Created attachment 103550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103550&action=edit
Bug 24718: Get reservedate and expirationdate to use datetime

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99542|0                           |1
        is obsolete|                            |

--- Comment #21 from David Nind <[hidden email]> ---
Created attachment 103551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103551&action=edit
Bug 24718: Get templates working with HourBasedHolds

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24718] Introduce hour-based holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99543|0                           |1
        is obsolete|                            |

--- Comment #22 from David Nind <[hidden email]> ---
Created attachment 103552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103552&action=edit
Bug 24718: Get OPAC working with datetimepicker and HourBasedHolds

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
123