[Bug 24190] New: Add additional Acquisition logging

classic Classic list List threaded Threaded
27 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] New: Add additional Acquisition logging

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

            Bug ID: 24190
           Summary: Add additional Acquisition logging
 Change sponsored?: ---
           Product: Koha
           Version: 18.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

A start was made on adding logging for Acquisitions in bug 23971. This bug will
extend this as detailed below (note, some of the information detailed here will
be derived via reporting and not explicitly logged):

1. Order line cancellations
Details including who made the cancellation and when the cancellation was made


2. Order line creations
Details including who created the order line, when it was created, the fund,
and amount


3. Invoice adjustment additions
Details including who added the adjustment, when it was added, the fund, and
amount


4. Invoice adjustment amendments
Details including who amended the adjustment, when it was amended, the fund,
and amount


5. Invoice adjustment deletions
Details including who deleted the adjustment, when it was deleted, the fund,
and amount


6. Order line receipts against an invoice
Details including who received the order line, when it was received, the fund,
and amount


7. Budget Adjustments
This would show amounts added or removed from a budget (excluding spent), who,
when, and amount
(In Koha the actual amount is edited rather than typing in the amount to
change)

8. Fund adjustments
This is essentially a bank statement. It would show additions and subtractions
to a fund (excluding spent), who, when, amount, previous total, new total

9. Order release date (1)
This would show individual order lines from an EDI message, when they were
sent, who sent it, fund, and amount

10. Order release date (2)
This would show individual order lines from a basket, when it was closed, who
closed it, fund, and amount

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |andrew.isherwood@ptfs-europ
                   |ity.org                     |e.com
  Change sponsored?|---                         |Sponsored
             Status|NEW                         |ASSIGNED

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23971


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971
[Bug 23971] Add logging for basket related actions
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Marjorie Barry-Vila <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila@collect
                   |                            |o.ca

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

--- Comment #1 from Andrew Isherwood <[hidden email]> ---
Created attachment 96364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96364&action=edit
Bug 24190 - Add acquisition logging

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96364|0                           |1
        is obsolete|                            |

--- Comment #2 from Andrew Isherwood <[hidden email]> ---
Created attachment 96369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96369&action=edit
Bug 24190 - Add acquisition logging

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

--- Comment #3 from Andrew Isherwood <[hidden email]> ---
Associated reports:

1. Order line cancellations
SELECT
    o.ordernumber AS 'Order number',
    ba.basketname AS 'Basket',
    f.budget_name AS 'Fund',
    CONCAT(b.firstname, ' ', b.surname) AS 'Cancelled by',
    a.timestamp AS 'Cancelled timestamp'
FROM
    action_logs a
INNER JOIN borrowers b ON a.user = b.borrowernumber
INNER JOIN aqorders o ON a.object = o.ordernumber
INNER JOIN aqbasket ba ON o.basketno = ba.basketno
LEFT JOIN aqbudgets f ON o.budget_id = f.budget_id
WHERE
    a.module='ACQUISITIONS' AND
    a.action = 'CANCEL_ORDER' AND
    date(a.timestamp) BETWEEN <<Starting timestamp|date>> AND <<Ending
timestamp|date>>

2. Order line creations
SELECT
    o.ordernumber AS 'Order number',
    ba.basketname AS 'Basket',
    f.budget_name AS 'Fund',
    CONCAT(b.firstname, ' ', b.surname) AS 'Created by',
    a.timestamp AS 'Created timestamp'
FROM
    action_logs a
INNER JOIN borrowers b ON a.user = b.borrowernumber
INNER JOIN aqorders o ON a.object = o.ordernumber
INNER JOIN aqbasket ba ON o.basketno = ba.basketno
LEFT JOIN aqbudgets f ON o.budget_id = f.budget_id
WHERE
    a.module='ACQUISITIONS' AND
    a.action = 'CREATE_ORDER' AND
    date(a.timestamp) BETWEEN <<Starting timestamp|date>> AND <<Ending
timestamp|date>>

3. Invoice adjustment additions
SELECT
    f.budget_name AS 'Fund',
    i.invoicenumber,
    FORMAT(SUBSTRING(a.info, 1, 10), 2) AS 'Amount',
    ia.note AS 'Note',
    CASE WHEN SUBSTRING(a.info, 101, 10) = 0 THEN 'No' ELSE 'Yes' END AS
'Encumber open',
    av.lib AS 'Reason',
    CONCAT(b.firstname, ' ', b.surname) AS 'Created by',
    a.timestamp AS 'Created timestamp'
FROM
    action_logs a
INNER JOIN borrowers b ON a.user = b.borrowernumber
INNER JOIN aqinvoice_adjustments ia ON a.object = ia.adjustment_id
INNER JOIN aqinvoices i ON i.invoiceid = ia.invoiceid
LEFT JOIN aqbudgets f ON SUBSTRING(a.info, 91, 10) = f.budget_id
LEFT JOIN authorised_values av ON av.category = 'ADJ_REASON' AND
av.authorised_value = TRIM(LEADING ' ' FROM SUBSTRING(a.info, 11, 80))
WHERE
    a.module='ACQUISITIONS' AND
    a.action = 'CREATE_INVOICE_ADJUSTMENT' AND
    date(a.timestamp) BETWEEN <<Starting timestamp|date>> AND <<Ending
timestamp|date>>

4. Invoice adjustment amendments
SELECT
    i.invoicenumber AS 'Invoice number',
    f_before.budget_name AS 'Fund before',
    f_after.budget_name AS 'Fund after',
    FORMAT(SUBSTRING(a.info, 131, 10), 2) AS 'Amount before',
    FORMAT(SUBSTRING(a.info, 1, 10), 2) AS 'Amount after',
    ia.note AS 'Note',
    CASE WHEN SUBSTRING(a.info, 121, 10) = 0 THEN 'No' ELSE 'Yes' END AS
'Encumber open before',
    CASE WHEN SUBSTRING(a.info, 101, 10) = 0 THEN 'No' ELSE 'Yes' END AS
'Encumber open after',
    av_before.lib AS 'Reason before',
    av_after.lib AS 'Reason after',
    CONCAT(b.firstname, ' ', b.surname) AS 'Created by',
    a.timestamp AS 'Created timestamp'
FROM
    action_logs a
INNER JOIN borrowers b ON a.user = b.borrowernumber
INNER JOIN aqinvoice_adjustments ia ON a.object = ia.adjustment_id
INNER JOIN aqinvoices i ON i.invoiceid = ia.invoiceid
LEFT JOIN aqbudgets f_before ON SUBSTRING(a.info, 111, 10) = f_before.budget_id
LEFT JOIN aqbudgets f_after ON SUBSTRING(a.info, 91, 10) = f_after.budget_id
LEFT JOIN authorised_values av_before ON av_before.category = 'ADJ_REASON' AND
av_before.authorised_value = TRIM(LEADING ' ' FROM SUBSTRING(a.info, 141, 80))
LEFT JOIN authorised_values av_after ON av_after.category = 'ADJ_REASON' AND
av_after.authorised_value = TRIM(LEADING ' ' FROM SUBSTRING(a.info, 11, 80))
WHERE
    a.module='ACQUISITIONS' AND
    a.action = 'UPDATE_INVOICE_ADJUSTMENT' AND
    date(a.timestamp) BETWEEN <<Starting timestamp|date>> AND <<Ending
timestamp|date>>

5. Invoice adjustment deletions
SELECT
    i.invoicenumber AS 'Invoice number',
    f.budget_name AS 'Fund',
    FORMAT(SUBSTRING(a.info, 31, 10), 2) AS 'Amount',
    CASE WHEN SUBSTRING(a.info, 21, 10) = 0 THEN 'No' ELSE 'Yes' END AS
'Encumber open',
    av.lib AS 'Reason',
    CONCAT(b.firstname, ' ', b.surname) AS 'Deleted by',
    a.timestamp AS 'Deleted timestamp',
    SUBSTRING(a.info, 31, 10)
FROM
    action_logs a
INNER JOIN borrowers b ON a.user = b.borrowernumber
INNER JOIN aqinvoices i ON i.invoiceid = SUBSTRING(a.info, 1, 10)
LEFT JOIN aqbudgets f ON SUBSTRING(a.info, 11, 10) = f.budget_id
LEFT JOIN authorised_values av ON av.category = 'ADJ_REASON' AND
av.authorised_value = TRIM(LEADING ' ' FROM SUBSTRING(a.info, 41, 80))
WHERE
    a.module='ACQUISITIONS' AND
    a.action = 'DELETE_INVOICE_ADJUSTMENT' AND
    date(a.timestamp) BETWEEN <<Starting timestamp|date>> AND <<Ending
timestamp|date>>

6. Order line receipts against an invoice
SELECT
        o.ordernumber AS 'Order number',
    FORMAT(SUBSTRING(a.info, 1, 10), 0) AS 'Quantity received',
    f.budget_name AS 'Fund',
    FORMAT(SUBSTRING(a.info, 21, 10), 2) AS 'Tax rate',
    FORMAT(SUBSTRING(a.info, 31, 10), 2) AS 'Replacement price',
    FORMAT(SUBSTRING(a.info, 41, 10), 2) AS 'Actual cost',
    CONCAT(b.firstname, ' ', b.surname) AS 'Received by',
    a.timestamp AS 'Received timestamp'
FROM
    action_logs a
INNER JOIN borrowers b ON a.user = b.borrowernumber
INNER JOIN aqorders o ON a.object = o.ordernumber
LEFT JOIN aqbudgets f ON SUBSTRING(a.info, 11, 10) = f.budget_id
WHERE
    a.module='ACQUISITIONS' AND
    a.action = 'RECEIVE_ORDER' AND
    date(a.timestamp) BETWEEN <<Starting timestamp|date>> AND <<Ending
timestamp|date>>

7. Budget Adjustments
SELECT
    SUBSTR(a.info, 31, 10) AS 'Budget start before',
        SUBSTR(a.info, 1, 10) AS 'Budget start after',
    SUBSTR(a.info, 41, 10) AS 'Budget end before',
        SUBSTR(a.info, 11, 10) AS 'Budget end after',
    FORMAT(SUBSTR(a.info, 51, 10), 2) AS 'Total amount before',
    FORMAT(SUBSTR(a.info, 21, 10), 2) AS 'Total amount after',
    FORMAT(SUBSTR(a.info, 61, 10), 2) AS 'Difference',
    CONCAT(b.firstname, ' ', b.surname) AS 'Modified by',
    a.timestamp AS 'Modified timestamp'
FROM
    action_logs a
INNER JOIN borrowers b ON a.user = b.borrowernumber
WHERE
    a.module='ACQUISITIONS' AND
    a.action = 'MODIFY_BUDGET' AND
    date(a.timestamp) BETWEEN <<Starting timestamp|date>> AND <<Ending
timestamp|date>>

8. Fund adjustments
SELECT
    a.object AS 'Fund ID',
    FORMAT(SUBSTR(a.info, 31, 10), 2) AS 'Amount before',
    FORMAT(SUBSTR(a.info, 1, 10) ,2 ) AS 'Amount after',
        FORMAT(SUBSTR(a.info, 41, 10), 2) AS 'Warn at % before',
        FORMAT(SUBSTR(a.info, 11, 10), 2) AS 'Warn at % after',
    FORMAT(SUBSTR(a.info, 51, 10), 2) AS 'Warn at amount before',
    FORMAT(SUBSTR(a.info, 21, 10), 2) AS 'Warn at amount after',
    FORMAT(SUBSTR(a.info, 61, 10), 2) AS 'Difference',
    CONCAT(b.firstname, ' ', b.surname) AS 'Modified by',
    a.timestamp AS 'Modified timestamp'
FROM
    action_logs a
INNER JOIN borrowers b ON a.user = b.borrowernumber
WHERE
    a.module='ACQUISITIONS' AND
    a.action = 'MODIFY_FUND' AND
    date(a.timestamp) BETWEEN <<Starting timestamp|date>> AND <<Ending
timestamp|date>>

9. Order release date (1)
SELECT
    ba.basketname AS "Basket name",
    bs.name AS "Vendor name",
    bi.title AS 'Title',
    bi.author AS 'Author',
    o.quantity AS 'Quantity',
    FORMAT(o.listprice, 2) AS 'Vendor price',
    FORMAT(o.rrp, 2) AS 'Retail price',
    FORMAT(o.ecost, 2) AS 'Budgeted cost',
    FORMAT(o.unitprice, 2) AS 'Actual cost',
    bu.budget_name AS 'Fund',
    CONCAT(b.firstname, ' ', b.surname) AS 'Basket closed by',
    a.timestamp AS 'Basket closed timestamp'
FROM
    action_logs a
INNER JOIN borrowers b ON a.user = b.borrowernumber
INNER JOIN aqbasket ba ON a.object = ba.basketno
INNER JOIN aqorders o ON o.basketno = ba.basketno
INNER JOIN aqbooksellers bs ON ba.booksellerid = bs.id
LEFT JOIN aqbudgets bu ON bu.budget_id = o.budget_id
LEFT JOIN biblio bi ON bi.biblionumber = o.biblionumber
WHERE
    a.module='ACQUISITIONS' AND
    a.action = 'CLOSE_BASKET' AND
    date(a.timestamp) BETWEEN <<Starting timestamp|date>> AND <<Ending
timestamp|date>> AND
    a.object = <<Basket ID>>

10. Order release date (2)
SELECT
    o.ordernumber AS 'Order number',
    b.basketname AS 'Basket',
    bu.budget_name AS 'Fund',
    bi.title AS 'Title',
    bi.author AS 'Author',
    CONCAT(bo.firstname, ' ', bo.surname) AS 'Sent by',
    e.transfer_date AS 'Sent date'
FROM
    edifact_messages e
LEFT JOIN aqbasket b ON e.basketno = b.basketno
LEFT JOIN aqorders o ON o.basketno = b.basketno
LEFT JOIN action_logs a ON e.basketno = a.object
LEFT JOIN biblio bi ON o.biblionumber = bi.biblionumber
LEFT JOIN borrowers bo ON a.user = bo.borrowernumber
INNER JOIN aqbudgets bu ON o.budget_id = bu.budget_id
WHERE
    e.message_type='ORDER' AND
    e.status = 'Sent' AND
    a.module = 'ACQUISITIONS' AND
    a.action = 'APPROVE_BASKET' AND
    date(e.transfer_date) BETWEEN <<Starting timestamp|date>> AND <<Ending
timestamp|date>> AND
    e.basketno = <<Basket ID>>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

--- Comment #4 from Andrew Isherwood <[hidden email]> ---
1. Order line cancellations:
----------------------------
SELECT
    o.ordernumber AS 'Order number',
    bi.title AS 'Title',
    bi.author AS 'Author',
    ba.basketname AS 'Basket',
    f.budget_name AS 'Fund',
    CONCAT(b.firstname, ' ', b.surname) AS 'Cancelled by',
    a.timestamp AS 'Cancelled timestamp'
FROM
    action_logs a
INNER JOIN borrowers b ON a.user = b.borrowernumber
INNER JOIN aqorders o ON a.object = o.ordernumber
INNER JOIN aqbasket ba ON o.basketno = ba.basketno
LEFT JOIN aqbudgets f ON o.budget_id = f.budget_id
LEFT JOIN biblio bi ON o.biblionumber = bi.biblionumber
WHERE
    a.module='ACQUISITIONS' AND
    a.action = 'CANCEL_ORDER' AND
    date(a.timestamp) BETWEEN <<Starting timestamp|date>> AND <<Ending
timestamp|date>>

Order line creations:
---------------------
SELECT
    o.ordernumber AS 'Order number',
    ba.basketname AS 'Basket',
    bi.title AS 'Title',
    bi.author AS 'Author',
    f.budget_name AS 'Fund',
    CONCAT(b.firstname, ' ', b.surname) AS 'Created by',
    a.timestamp AS 'Created timestamp'
FROM
    action_logs a
INNER JOIN borrowers b ON a.user = b.borrowernumber
INNER JOIN aqorders o ON a.object = o.ordernumber
INNER JOIN aqbasket ba ON o.basketno = ba.basketno
LEFT JOIN aqbudgets f ON o.budget_id = f.budget_id
LEFT JOIN biblio bi ON o.biblionumber = bi.biblionumber
WHERE
    a.module='ACQUISITIONS' AND
    a.action = 'CREATE_ORDER' AND
    date(a.timestamp) BETWEEN <<Starting timestamp|date>> AND <<Ending
timestamp|date>>

3. Invoice adjustment additions:
--------------------------------
SELECT
    f.budget_name AS 'Fund',
    i.invoicenumber,
    FORMAT(SUBSTRING(a.info, 1, 10), 2) AS 'Amount',
    ia.note AS 'Note',
    CASE WHEN SUBSTRING(a.info, 101, 10) = 0 THEN 'No' ELSE 'Yes' END AS
'Encumber open',
    av.lib AS 'Reason',
    CONCAT(b.firstname, ' ', b.surname) AS 'Created by',
    a.timestamp AS 'Created timestamp'
FROM
    action_logs a
INNER JOIN borrowers b ON a.user = b.borrowernumber
INNER JOIN aqinvoice_adjustments ia ON a.object = ia.adjustment_id
INNER JOIN aqinvoices i ON i.invoiceid = ia.invoiceid
LEFT JOIN aqbudgets f ON SUBSTRING(a.info, 91, 10) = f.budget_id
LEFT JOIN authorised_values av ON av.category = 'ADJ_REASON' AND
av.authorised_value = TRIM(LEADING ' ' FROM SUBSTRING(a.info, 11, 80))
WHERE
    a.module='ACQUISITIONS' AND
    a.action = 'CREATE_INVOICE_ADJUSTMENT' AND
    date(a.timestamp) BETWEEN <<Starting timestamp|date>> AND <<Ending
timestamp|date>>

4. Invoice adjustment amendments:
---------------------------------
SELECT
    i.invoicenumber AS 'Invoice number',
    f_before.budget_name AS 'Fund before',
    f_after.budget_name AS 'Fund after',
    FORMAT(SUBSTRING(a.info, 131, 10), 2) AS 'Amount before',
    FORMAT(SUBSTRING(a.info, 1, 10), 2) AS 'Amount after',
    ia.note AS 'Note',
    CASE WHEN SUBSTRING(a.info, 121, 10) = 0 THEN 'No' ELSE 'Yes' END AS
'Encumber open before',
    CASE WHEN SUBSTRING(a.info, 101, 10) = 0 THEN 'No' ELSE 'Yes' END AS
'Encumber open after',
    av_before.lib AS 'Reason before',
    av_after.lib AS 'Reason after',
    CONCAT(b.firstname, ' ', b.surname) AS 'Created by',
    a.timestamp AS 'Created timestamp'
FROM
    action_logs a
INNER JOIN borrowers b ON a.user = b.borrowernumber
INNER JOIN aqinvoice_adjustments ia ON a.object = ia.adjustment_id
INNER JOIN aqinvoices i ON i.invoiceid = ia.invoiceid
LEFT JOIN aqbudgets f_before ON SUBSTRING(a.info, 111, 10) = f_before.budget_id
LEFT JOIN aqbudgets f_after ON SUBSTRING(a.info, 91, 10) = f_after.budget_id
LEFT JOIN authorised_values av_before ON av_before.category = 'ADJ_REASON' AND
av_before.authorised_value = TRIM(LEADING ' ' FROM SUBSTRING(a.info, 141, 80))
LEFT JOIN authorised_values av_after ON av_after.category = 'ADJ_REASON' AND
av_after.authorised_value = TRIM(LEADING ' ' FROM SUBSTRING(a.info, 11, 80))
WHERE
    a.module='ACQUISITIONS' AND
    a.action = 'UPDATE_INVOICE_ADJUSTMENT' AND
    date(a.timestamp) BETWEEN <<Starting timestamp|date>> AND <<Ending
timestamp|date>>

5. Invoice adjustment deletions:
--------------------------------
SELECT
    i.invoicenumber AS 'Invoice number',
    f.budget_name AS 'Fund',
    FORMAT(SUBSTRING(a.info, 31, 10), 2) AS 'Amount',
    CASE WHEN SUBSTRING(a.info, 21, 10) = 0 THEN 'No' ELSE 'Yes' END AS
'Encumber open',
    av.lib AS 'Reason',
    CONCAT(b.firstname, ' ', b.surname) AS 'Deleted by',
    a.timestamp AS 'Deleted timestamp',
    SUBSTRING(a.info, 31, 10)
FROM
    action_logs a
INNER JOIN borrowers b ON a.user = b.borrowernumber
INNER JOIN aqinvoices i ON i.invoiceid = SUBSTRING(a.info, 1, 10)
LEFT JOIN aqbudgets f ON SUBSTRING(a.info, 11, 10) = f.budget_id
LEFT JOIN authorised_values av ON av.category = 'ADJ_REASON' AND
av.authorised_value = TRIM(LEADING ' ' FROM SUBSTRING(a.info, 41, 80))
WHERE
    a.module='ACQUISITIONS' AND
    a.action = 'DELETE_INVOICE_ADJUSTMENT' AND
    date(a.timestamp) BETWEEN <<Starting timestamp|date>> AND <<Ending
timestamp|date>>

6. Order line receipts against an invoice:
-----------------------------------------
SELECT
        o.ordernumber AS 'Order number',
    FORMAT(SUBSTRING(a.info, 1, 10), 0) AS 'Quantity received',
    f.budget_name AS 'Fund',
    FORMAT(SUBSTRING(a.info, 21, 10), 2) AS 'Tax rate',
    FORMAT(SUBSTRING(a.info, 31, 10), 2) AS 'Replacement price',
    FORMAT(SUBSTRING(a.info, 41, 10), 2) AS 'Actual cost',
    CONCAT(b.firstname, ' ', b.surname) AS 'Received by',
    a.timestamp AS 'Received timestamp'
FROM
    action_logs a
INNER JOIN borrowers b ON a.user = b.borrowernumber
INNER JOIN aqorders o ON a.object = o.ordernumber
LEFT JOIN aqbudgets f ON SUBSTRING(a.info, 11, 10) = f.budget_id
WHERE
    a.module='ACQUISITIONS' AND
    a.action = 'RECEIVE_ORDER' AND
    date(a.timestamp) BETWEEN <<Starting timestamp|date>> AND <<Ending
timestamp|date>>

7. Budget Adjustments:
----------------------
SELECT
    SUBSTR(a.info, 31, 10) AS 'Budget start before',
        SUBSTR(a.info, 1, 10) AS 'Budget start after',
    SUBSTR(a.info, 41, 10) AS 'Budget end before',
        SUBSTR(a.info, 11, 10) AS 'Budget end after',
    FORMAT(SUBSTR(a.info, 51, 10), 2) AS 'Total amount before',
    FORMAT(SUBSTR(a.info, 21, 10), 2) AS 'Total amount after',
    FORMAT(SUBSTR(a.info, 61, 10), 2) AS 'Difference',
    CONCAT(b.firstname, ' ', b.surname) AS 'Modified by',
    a.timestamp AS 'Modified timestamp'
FROM
    action_logs a
INNER JOIN borrowers b ON a.user = b.borrowernumber
WHERE
    a.module='ACQUISITIONS' AND
    a.action = 'MODIFY_BUDGET' AND
    date(a.timestamp) BETWEEN <<Starting timestamp|date>> AND <<Ending
timestamp|date>>

8. Fund adjustments:
--------------------
SELECT
    a.object AS 'Fund ID',
    FORMAT(SUBSTR(a.info, 31, 10), 2) AS 'Amount before',
    FORMAT(SUBSTR(a.info, 1, 10) ,2 ) AS 'Amount after',
        FORMAT(SUBSTR(a.info, 41, 10), 2) AS 'Warn at % before',
        FORMAT(SUBSTR(a.info, 11, 10), 2) AS 'Warn at % after',
    FORMAT(SUBSTR(a.info, 51, 10), 2) AS 'Warn at amount before',
    FORMAT(SUBSTR(a.info, 21, 10), 2) AS 'Warn at amount after',
    FORMAT(SUBSTR(a.info, 61, 10), 2) AS 'Difference',
    CONCAT(b.firstname, ' ', b.surname) AS 'Modified by',
    a.timestamp AS 'Modified timestamp'
FROM
    action_logs a
INNER JOIN borrowers b ON a.user = b.borrowernumber
WHERE
    a.module='ACQUISITIONS' AND
    a.action = 'MODIFY_FUND' AND
    date(a.timestamp) BETWEEN <<Starting timestamp|date>> AND <<Ending
timestamp|date>>

9. Order release date (1):
--------------------------
SELECT
    ba.basketname AS "Basket name",
    bs.name AS "Vendor name",
    bi.title AS 'Title',
    bi.author AS 'Author',
    o.quantity AS 'Quantity',
    FORMAT(o.listprice, 2) AS 'Vendor price',
    FORMAT(o.rrp, 2) AS 'Retail price',
    FORMAT(o.ecost, 2) AS 'Budgeted cost',
    FORMAT(o.unitprice, 2) AS 'Actual cost',
    bu.budget_name AS 'Fund',
    CONCAT(b.firstname, ' ', b.surname) AS 'Basket closed by',
    a.timestamp AS 'Basket closed timestamp'
FROM
    action_logs a
INNER JOIN borrowers b ON a.user = b.borrowernumber
INNER JOIN aqbasket ba ON a.object = ba.basketno
INNER JOIN aqorders o ON o.basketno = ba.basketno
INNER JOIN aqbooksellers bs ON ba.booksellerid = bs.id
LEFT JOIN aqbudgets bu ON bu.budget_id = o.budget_id
LEFT JOIN biblio bi ON bi.biblionumber = o.biblionumber
WHERE
    a.module='ACQUISITIONS' AND
    a.action = 'CLOSE_BASKET' AND
    date(a.timestamp) BETWEEN <<Starting timestamp|date>> AND <<Ending
timestamp|date>> AND
    a.object = <<Basket ID>>

10. Order release date (2):
---------------------------
SELECT
    o.ordernumber AS 'Order number',
    b.basketname AS 'Basket',
    bu.budget_name AS 'Fund',
    bi.title AS 'Title',
    bi.author AS 'Author',
    CONCAT(bo.firstname, ' ', bo.surname) AS 'Sent by',
    e.transfer_date AS 'Sent date'
FROM
    edifact_messages e
LEFT JOIN aqbasket b ON e.basketno = b.basketno
LEFT JOIN aqorders o ON o.basketno = b.basketno
LEFT JOIN action_logs a ON e.basketno = a.object
LEFT JOIN biblio bi ON o.biblionumber = bi.biblionumber
LEFT JOIN borrowers bo ON a.user = bo.borrowernumber
INNER JOIN aqbudgets bu ON o.budget_id = bu.budget_id
WHERE
    e.message_type='ORDER' AND
    e.status = 'Sent' AND
    a.module = 'ACQUISITIONS' AND
    a.action = 'APPROVE_BASKET' AND
    date(e.transfer_date) BETWEEN <<Starting timestamp|date>> AND <<Ending
timestamp|date>> AND
    e.basketno = <<Basket ID>>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #5 from Andrew Isherwood <[hidden email]> ---
Test plan:

Setup:
1. Apply patch and run database update if necessary

Order line cancellations:
1. Go to "Aquisitions", find an open basket with at least one order
2. Cancel the order and confirm the cancellation
3. From the staff main page, go to "Reports > Create from SQL"
4. Name the report "Order line cancellations"
5. In the SQL box, enter the report labelled "Order line cancellations" in
comment #4 above
6. Save the report, the run it, choosing a start and end date
7. TEST => Observe that the order cancellation you just carried out is listed

Order line creations:
1. Go to "Aquisitions", find or create an open basket
2. Create a new order in the basket
3. From the staff main page, go to "Reports > Create from SQL"
4. Name the report "Order line creations"
5. In the SQL box, enter the report labelled "Order line creations" in comment
#4 above
6. Save the report, the run it, choosing a start and end date
7. TEST => Observe that the order creation you just carried out is listed

Invoice adjustment additions:
1. Go to "Aquisitions", find or create an invoice
2. Click "Add an adjustment"
3. Fill in the details of the adjustment, then click "Update adjustments"
4. From the staff main page, go to "Reports > Create from SQL"
5. Name the report "Invoice adjustment additions"
6. In the SQL box, enter the report labelled "Invoice adjustment additions" in
comment #4 above
7. Save the report, the run it, choosing a start and end date
8. TEST => Observe that the adjustment creation you just carried out is listed

Invoice adjustment amendments:
1. Go to "Aquisitions", find the invoice from the previous steps
2. Find the adjustment you added and modify it
3. Click "Update adjustments"
4. From the staff main page, go to "Reports > Create from SQL"
5. Name the report "Invoice adjustment amendments"
6. In the SQL box, enter the report labelled "Invoice adjustment amendments" in
comment #4 above
7. Save the report, the run it, choosing a start and end date
8. TEST => Observe that the adjustment amendment you just carried out is listed

Invoice adjustment deletions:
1. Go to "Aquisitions", find the invoice from the previous steps
2. Find the adjustment you added and delete it
3. From the staff main page, go to "Reports > Create from SQL"
4. Name the report "Invoice adjustment deletions"
5. In the SQL box, enter the report labelled "Invoice adjustment deletions" in
comment #4 above
6. Save the report, the run it, choosing a start and end date
7. TEST => Observe that the adjustment deletion you just carried out is listed

Order line receipts against an invoice:
1. Go to "Aquisitions", find an open invoice with unreceived items
2. Go to the "Receipt summary" page
3. Click "Receive" for an item
4. Fill in the data as appropriate, then click "Save"
5. From the staff main page, go to "Reports > Create from SQL"
6. Name the report "Order line receipts against an invoice"
7. In the SQL box, enter the report labelled "Order line receipts against an
invoice" in comment #4 above
8. Save the report, the run it, choosing a start and end date
9. TEST => Observe that the receipt you just carried out is listed

Budget adjustments:
1. Go to "Aquisitions", find a budget
2. Click "Actions" > "Edit"
3. Modify some properties of the budget
4. Click "Save"
5. From the staff main page, go to "Reports > Create from SQL"
6. Name the report "Budget adjustments"
7. In the SQL box, enter the report labelled "Budget adjustments" in comment #4
above
8. Save the report, the run it, choosing a start and end date
9. TEST => Observe that the adjustment you just carried out is listed,
including details of the "before" and "after" values

Fund adjustments:
1. Go to "Aquisitions", find a fund
2. Click "Actions" > "Edit"
3. Modify some properties of the fund
4. Click "Submit"
5. From the staff main page, go to "Reports > Create from SQL"
6. Name the report "Fund adjustments"
7. In the SQL box, enter the report labelled "Fund adjustments" in comment #4
above
8. Save the report, the run it, choosing a start and end date
9. TEST => Observe that the adjustment you just carried out is listed,
including details of the "before" and "after" values

Order release date (1):
1. Go to "Aquisitions", find an open basket
2. Close the basket, noting it's ID
3. From the staff main page, go to "Reports > Create from SQL"
4. Name the report "Order release date (1)"
5. In the SQL box, enter the report labelled "Order release date (1)" in
comment #4 above
6. Save the report, the run it, choosing a start and end date and basket ID
7. TEST => Observe that the details of the closed basket are listed

Order release date (2):
1. Release a basket via an EDI message, resulting in a row in edifact_messages
table
3. From the staff main page, go to "Reports > Create from SQL"
4. Name the report "Order release date (2)"
5. In the SQL box, enter the report labelled "Order release date (2)" in
comment #4 above
6. Save the report, the run it, choosing a start and end date and basket ID
7. TEST => Observe that the details of the released orders are listed

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96369|0                           |1
        is obsolete|                            |

--- Comment #6 from Andrew Isherwood <[hidden email]> ---
Created attachment 100243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100243&action=edit
Bug 24190 - Add acquisition logging

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.11                       |master
                 CC|                            |martin.renvoize@ptfs-europe
                   |                            |.com

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|master                      |18.11

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.11                       |master

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100243|0                           |1
        is obsolete|                            |

--- Comment #7 from Andrew Isherwood <[hidden email]> ---
Created attachment 105082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105082&action=edit
Bug 24190 - Add acquisition logging

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

--- Comment #8 from Andrew Isherwood <[hidden email]> ---
Created attachment 105083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105083&action=edit
Bug 24190: (follow-up) Cancel order del item bug

If an order is cancelled but the associated bib / items are unable to be
removed, we go into error handling. We still need to log the
cancellation though. So this fix moves the logging to just after the
cancellation, so it will be logged regardless of the outcome with
associated things.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

--- Comment #9 from Martin Renvoize <[hidden email]> ---
Created attachment 106096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106096&action=edit
Bug 24190: Add acquisition logging

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105083|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <[hidden email]> ---
Created attachment 106097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106097&action=edit
Bug 24190: (follow-up) Cancel order del item bug

If an order is cancelled but the associated bib / items are unable to be
removed, we go into error handling. We still need to log the
cancellation though. So this fix moves the logging to just after the
cancellation, so it will be logged regardless of the outcome with
associated things.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105082|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106096|0                           |1
        is obsolete|                            |

--- Comment #11 from Martin Renvoize <[hidden email]> ---
Created attachment 106098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106098&action=edit
Bug 24190: Add acquisition logging

Signed-off-by: Maura Stephens <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106097|0                           |1
        is obsolete|                            |

--- Comment #12 from Martin Renvoize <[hidden email]> ---
Created attachment 106099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106099&action=edit
Bug 24190: (follow-up) Cancel order del item bug

If an order is cancelled but the associated bib / items are unable to be
removed, we go into error handling. We still need to log the
cancellation though. So this fix moves the logging to just after the
cancellation, so it will be logged regardless of the outcome with
associated things.

Signed-off-by: Maura Stephens <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #13 from Martin Renvoize <[hidden email]> ---
Tested and signed off on PTFS-E sandboxes by Maura Stephens

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |25916


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25916
[Bug 25916] Create function and UI to modify budgets and funds.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org

--- Comment #14 from Jonathan Druart <[hidden email]> ---
Some comments:

1. You really should avoid indentation spaces outside of the block you are
editing. It makes rebase a nightmare for you and for those who will have to
rebase on top of it.

2. Why are you using the "%010d" format?
Why are not you dumping (using Data::Dumper) the whole $budget?
I have not tested but
+                sprintf("%010d", $del_adj->invoiceid) .
+                sprintf("%010d", $del_adj->budget_id) .

That will produce a concat of 00000000010000000001 (for invoiceid=1 and
budget_id=1
Is it really what we expect?

And why 10? rrp_tax_excluded is decimal(28,6) for instance


3. +                eval { output_pref({ dt => dt_from_string(
$input->param('budget_period_startdate') ), dateformat => 'iso', dateonly => 1
} ); } .
I don't think we should store formatted dates.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

--- Comment #15 from Jonathan Druart <[hidden email]> ---
4. You should also consider adding tests

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13325

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #16 from Katrin Fischer <[hidden email]> ---
I just noticed that there is a dependent bug, that needs to be tested first,
but worth noting, that this does no longer apply on top:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 24190: Add acquisition logging
error: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 24190: Add acquisition logging
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-24190-Add-acquisition-logging-mCG2UX.patch

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24190] Add additional Acquisition logging

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

--- Comment #17 from Katrin Fischer <[hidden email]> ---
Please also check the comments!

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/