[Bug 24159] New: Short loan collection issues on a day marked as closed

classic Classic list List threaded Threaded
84 messages Options
123
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] New: Short loan collection issues on a day marked as closed

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

            Bug ID: 24159
           Summary: Short loan collection issues on a day marked as closed
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]

Scenario:
 * The library has a 4wk loan item type and a 1hr loan item type.
 * The library would like 1hr loan item types to be issued and returned on a
day marked as closed in the circ calendar, but only allow 4wk loan types to be
returned on an open day.

Currently, if a 1hr loan is issued on a closed day, the due date is pushed back
to the next open day, overriding the duration of the loan.

If the usedaysmode syspref is set to "Circulation rules only" due dates for 1hr
loan items are calculated at 1hr later as defined in the circ rules, however
4wk loan due dates can potentially be set to closed days.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
                 CC|                            |[hidden email]
                   |                            |om

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #1 from Jonathan Druart <[hidden email]> ---
Created attachment 99758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99758&action=edit
Bug 24159: Move useDaysMode pref to circulation rules

Moving the useDaysMode system preference to a circulation rule will add
much more flexibility in the calculation of the due date.

The initial request was to make hourly loan returned on closed when
(when checked out on the same close day).
To do so we do not want to take into account the calendar.
However the calendar need to be taken into account for other loan item types.

Other scenarios are possible, for instance depending on the branch.

This patchset will add a new "Days mode" column (next to "Loan period")
to the circulation rules page, with the different values of the
"useDaysMode" system preference + a "default" value, to default to the
system preference value.

Test plan:
- Define a long loan item type (like 10 days) that will use the calendar
(or default to the pref value, if the pref is not set to "ignore the
calendar")
- and a hourly loan (like 2 hours) that will ignore the calendar
- Create items with those item types
- Mark today as a closed day
- Check the items out
=> The hourly loan is due the same day
=> The other loan is due on an open day

QA note:
There is the need to force the "days_mode" option when Koha::Calendar is
initiated for the due date calculation. To make sure devs will not
forget it, the methods that need have it defined will throw an
exception.

Sponsored-by: Institute of Technology Carlow

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #2 from Jonathan Druart <[hidden email]> ---
Created attachment 99759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99759&action=edit
Bug 24159: Throw an exception if days_mode option is not given when needed

Sponsored-by: Institute of Technology Carlow

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #3 from Jonathan Druart <[hidden email]> ---
Created attachment 99760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99760&action=edit
Bug 24159: Add UI changes

Sponsored-by: Institute of Technology Carlow

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #4 from Jonathan Druart <[hidden email]> ---
Created attachment 99761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99761&action=edit
Bug 24159: Adjust tests

Sponsored-by: Institute of Technology Carlow

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #5 from Jonathan Druart <[hidden email]> ---
Created attachment 99762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99762&action=edit
Bug 24159: Add new tests for get_useDaysMode_effective_value

Sponsored-by: Institute of Technology Carlow

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99758|0                           |1
        is obsolete|                            |
  Attachment #99759|0                           |1
        is obsolete|                            |
  Attachment #99760|0                           |1
        is obsolete|                            |
  Attachment #99761|0                           |1
        is obsolete|                            |
  Attachment #99762|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <[hidden email]> ---
Created attachment 100608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100608&action=edit
Bug 24159: Move useDaysMode pref to circulation rules

Moving the useDaysMode system preference to a circulation rule will add
much more flexibility in the calculation of the due date.

The initial request was to make hourly loan returned on closed when
(when checked out on the same close day).
To do so we do not want to take into account the calendar.
However the calendar need to be taken into account for other loan item types.

Other scenarios are possible, for instance depending on the branch.

This patchset will add a new "Days mode" column (next to "Loan period")
to the circulation rules page, with the different values of the
"useDaysMode" system preference + a "default" value, to default to the
system preference value.

Test plan:
- Define a long loan item type (like 10 days) that will use the calendar
(or default to the pref value, if the pref is not set to "ignore the
calendar")
- and a hourly loan (like 2 hours) that will ignore the calendar
- Create items with those item types
- Mark today as a closed day
- Check the items out
=> The hourly loan is due the same day
=> The other loan is due on an open day

QA note:
There is the need to force the "days_mode" option when Koha::Calendar is
initiated for the due date calculation. To make sure devs will not
forget it, the methods that need have it defined will throw an
exception.

Sponsored-by: Institute of Technology Carlow

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #7 from Jonathan Druart <[hidden email]> ---
Created attachment 100609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100609&action=edit
Bug 24159: Throw an exception if days_mode option is not given when needed

Sponsored-by: Institute of Technology Carlow

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #8 from Jonathan Druart <[hidden email]> ---
Created attachment 100610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100610&action=edit
Bug 24159: Add UI changes

Sponsored-by: Institute of Technology Carlow

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #9 from Jonathan Druart <[hidden email]> ---
Created attachment 100611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100611&action=edit
Bug 24159: Adjust tests

Sponsored-by: Institute of Technology Carlow

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #10 from Jonathan Druart <[hidden email]> ---
Created attachment 100612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100612&action=edit
Bug 24159: Add new tests for get_useDaysMode_effective_value

Sponsored-by: Institute of Technology Carlow

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #11 from Jonathan Druart <[hidden email]> ---
Created attachment 100613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100613&action=edit
Bug 24159: Set days_mode according to circ rules in 3 other places

There are 3 other occurrences where the new circ rule can be used:
 * C4::Circulation::checkHighHolds
 * Koha::Hold->set_waiting
 * misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl

Test plan:
* checkHighHolds
Enable decreaseLoanHighHolds and fill decreaseLoanHighHoldsDuration
Setup things to hit a "high demand" alert with a shortened due date
Check an item out
=> The due date must be recalculated depending on the circ rule useDaysMode.

* set_waiting
Set ExcludeHolidaysFromMaxPickUpDelay to "1" (note that there is currently
a bug in the description of the syspref, see bug 22381 comment 19)
Mark a hold waiting
The expiration date should have been set depending on the value of the
circ rule.

* TalkingTech cronjob
Cannot test this

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #12 from Jonathan Druart <[hidden email]> ---
Created attachment 100614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100614&action=edit
Bug 24159: Use days_mode circ rule to calculate the dropbox date

Calculate the drop box date depending on the circ rule. Note that only
the branchcode is taken into account here. Is that correct?

Test plan:
Use the drop box date feature and confirm that it takes into account the
calendar, depending on the circ rule.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #13 from Jonathan Druart <[hidden email]> ---
Created attachment 100615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100615&action=edit
Bug 24159: Fix one occurrence in updatedatabase.pl

Here we just want to get the value from the syspref, the circ rule does
not exist yet.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Short loan collection       |Short loan collection
                   |issues on a day marked as   |issues on a day marked as
                   |closed                      |closed (move useDaysMode to
                   |                            |circ rules)
             Blocks|                            |15523


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523
[Bug 15523] Move a number of sysprefs to circulation rules (Omnibus)
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

Paul Thornton <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #14 from Paul Thornton <[hidden email]> ---
Created attachment 101053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101053&action=edit
Test

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #15 from Paul Thornton <[hidden email]> ---
Created attachment 101054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101054&action=edit
Test

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #16 from Paul Thornton <[hidden email]> ---
Hello Jonathan
I'm coordinating testing with Simon Perry, and he raised the following issue:

"I’ve hit problems with this bug. I created a test bibliographic record with
two items records attached (one as an hourly loan and one as a long loan – see
attachment for details), set yesterday as a closed day in the calendar and
issued both items to a patron. I hadn’t changed the UseDaysMode syspref, so I
wanted to check the items in, change the syspref and then reissue. I’ve found
that I can’t check either item in and am getting a string of error messages
when I try to check in (attached). Note that I deleted the closed day entry in
the calendar for yesterday to see if it would make a difference to checkin – it
didn’t work.
Do you want to investigate or create a new sandbox so that I can retest?"

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

Paul Thornton <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #17 from Jonathan Druart <[hidden email]> ---
Hi Paul,

Can you confirm you were testing with all the patches applied?

Mark reported me this error by email, but that should have been fixed by the
patches I attached here on March 12th.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #18 from Paul Thornton <[hidden email]> ---
Hello Jonathan
I touched base with Simon and he says the best thing would be if PTFS can
re-send the link to the sandbox for this bug and he can retest. Can you
organise that please?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #19 from Simon Perry <[hidden email]> ---
Created attachment 101556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101556&action=edit
Test 24/3/20

Attached is testing completed today. I tested all 4 options available in the
useDaysMode syspref. Only for the Ignore and Use calendar to push due date to
next pen matching weekday.... syspref settings did the checkout due date/hour
remain on the days of checkout. This wouldn't work for our live system settings
as noted.
Regards, Simon

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #20 from Jonathan Druart <[hidden email]> ---
Hello Simon,

This development moves the system preference to the circulation rules, for more
granularity.

On the circulation rules you should see a new column "Days mode" with 5
different options.

In your case, I think what you need is:
Set the syspref to "Push the due date to next open day"
Define a circulation rule for Hourly loan and select "Ignore the Calendar" in
the "Days mode" column.

Note that there is a small cosmetic bug on the circulation table, the header of
the table says "Unit" instead of "Days mode". The footer is correct but there
is a shift in the header.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #21 from Jonathan Druart <[hidden email]> ---
Created attachment 101649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101649&action=edit
Bug 24159: Fix shift in the header

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #22 from Simon Perry <[hidden email]> ---
Created attachment 101698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101698&action=edit
Test 25/3/20

Hi Jonathan, thanks for clarification. I just retested with today set as closed
day in Calendar, Days mode in hourly circulation rule set to 'Calendar' (the
dropdown menu for the Days Mode only says 'Calendar' not 'Ignore the Calendar'
btw) and useDaysMode syspref set to 'Use the Calendar to push the due date to
next due day.' When I checked out an hourly loan item, the due date was moved
on to tomorrow, not retained as today's. Please see screenshot attachment for
details. Do you want me to test with other options set for useDaysMode etc.?
Simon

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #23 from Jonathan Druart <[hidden email]> ---
Simon, I think I understand where the confusion comes from.

The values in the circulation rules have the following meaning:

Days:     Ignore the calendar
Calendar: Use the calendar to skip days the library is closed
Datedue:  Use the calendar to push the due date to the next open day
Dayweek:  Use the calendar to push the due date to the next open matching
weekday for weekly loan periods, or the next open day otherwise

They are the "internal values" of the syspref.
It's not ideal but we cannot use the long descriptions in the dropdown list in
the circ rules table, that will be too wide.

It seems that it is not enough but to avoid the confusion there is a tooltip
that is displayed (over the cursor on the cell):
https://snipboard.io/We6flu.jpg it cannot be seen on the screenshot, but the
cursor is on "Days".

If you have anything else to suggest to make it less confusing, let me know!

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #24 from Simon Perry <[hidden email]> ---
Thanks for clarification Jonathan, from your comments it looks like I should be
selecting the 'Days' (ignore calendar) for the hourly loan. Am I right in
assuming that the DaysMode column in the Circulation rules table will override
what is set in the useDaysMode syspref? And therefore if the Days Mode column
in the Circ. rules table is set to 'Default' it will use whatever value is set
for the useDaysMode syspref?

Tooltip is useful and I guess the other thing is to ensure it is well
documented in the Koha circulation help. I'll retest and feedback results.
Regards, Simon

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159

--- Comment #25 from Jonathan Druart <[hidden email]> ---
(In reply to Simon Perry from comment #24)
> Thanks for clarification Jonathan, from your comments it looks like I should
> be selecting the 'Days' (ignore calendar) for the hourly loan. Am I right in
> assuming that the DaysMode column in the Circulation rules table will
> override what is set in the useDaysMode syspref? And therefore if the Days
> Mode column in the Circ. rules table is set to 'Default' it will use
> whatever value is set for the useDaysMode syspref?

Yes, that's exactly how it is supposed to work!

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
123