[Bug 23310] New: Noisy Koha::Biblio

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 23310] New: Noisy Koha::Biblio

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23310

            Bug ID: 23310
           Summary: Noisy Koha::Biblio
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

Sometimes 254$a and 254$b are not both defined. This creates noise in
Koha/Biblio.pm around line 579ish. This is repeatable by running the gambit of
tests and reading the plack-error log file.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23310] Noisy Koha::Biblio

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23310

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23310] Noisy Koha::Biblio

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23310

--- Comment #1 from M. Tompsett <[hidden email]> ---
Created attachment 91495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91495&action=edit
Bug 23310: Reduce noise in Koha::Biblio

The use of uninitialized value flooding plack-error
can get rather distracting and annoying.
By using "// q{}" after each of the subfield() calls
this eliminates the problem

TEST PLAN
- run tests before, noise in plack-error log
- apply patch
- restart_all
- run tests again, no Koha/Biblio noise after the restart
- run qa test tools

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23310] Noisy Koha::Biblio

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23310

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23310] Noisy Koha::Biblio

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23310

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91495|0                           |1
        is obsolete|                            |

--- Comment #2 from M. Tompsett <[hidden email]> ---
Created attachment 91496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91496&action=edit
Bug 23310: Reduce noise in Koha::Biblio

The use of uninitialized value flooding plack-error
can get rather distracting and annoying.
By using "// q{}" after each of the subfield() calls
this eliminates the problem

TEST PLAN
---------
vertical break where you stop your cut-and-paste.
This test should be repeatable with cut-and-paste
easily.

echo | sudo tee /var/log/koha/kohadev/plack-error.log
restart_all
kshell

prove t/db_dependent/Koha/Biblio.t
cat /var/log/koha/kohadev/plack-error.log

--- noise in plack-error log

exit
git bz apply 23310
echo | sudo tee /var/log/koha/kohadev/plack-error.log
restart_all
kshell

prove t/db_dependent/Koha/Biblio.t
cat /var/log/koha/kohadev/plack-error.log

--- no noise in plack-error log

kshell

qa -v 2 -c 1

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23310] Noisy Koha::Biblio

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23310

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91496|0                           |1
        is obsolete|                            |

--- Comment #3 from M. Tompsett <[hidden email]> ---
Created attachment 91497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91497&action=edit
Bug 23310: Reduce noise in Koha::Biblio

The use of uninitialized value flooding plack-error
can get rather distracting and annoying.
By using "// q{}" after each of the subfield() calls
this eliminates the problem

TEST PLAN
---------
vertical break where you stop your cut-and-paste.
This test should be repeatable with cut-and-paste
easily.

restart_all
kshell

prove t/db_dependent/Koha/Biblio.t
-- may strangely be quiet.

prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Biblio.t
-- should be noisy.

prove t/db_dependent/Koha/Biblio.t
-- will always be noisy now.

exit
git bz apply 23310

restart_all
kshell

prove t/db_dependent/Koha/Biblio.t
-- will be quiet.

prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Biblio.t
-- will be quiet.

prove t/db_dependent/Koha/Biblio.t
-- will be quiet.

qa -v 2 -c 1

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23310] Noisy Koha::Biblio

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23310

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #4 from M. Tompsett <[hidden email]> ---
Thanks to kidclamp for a more optimal fix.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23310] Noisy Koha::Biblio

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23310

David Nind <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23310] Noisy Koha::Biblio

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23310

David Nind <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91497|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <[hidden email]> ---
Created attachment 91544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91544&action=edit
Bug 23310: Reduce noise in Koha::Biblio

The use of uninitialized value flooding plack-error
can get rather distracting and annoying.
By using "// q{}" after each of the subfield() calls
this eliminates the problem

TEST PLAN
---------
vertical break where you stop your cut-and-paste.
This test should be repeatable with cut-and-paste
easily.

restart_all
kshell

prove t/db_dependent/Koha/Biblio.t
-- may strangely be quiet.

prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Biblio.t
-- should be noisy.

prove t/db_dependent/Koha/Biblio.t
-- will always be noisy now.

exit
git bz apply 23310

restart_all
kshell

prove t/db_dependent/Koha/Biblio.t
-- will be quiet.

prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Biblio.t
-- will be quiet.

prove t/db_dependent/Koha/Biblio.t
-- will be quiet.

qa -v 2 -c 1

Signed-off-by: David Nind <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23310] Noisy Koha::Biblio

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23310

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91544|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <[hidden email]> ---
Created attachment 91549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91549&action=edit
Bug 23310: Reduce noise in Koha::Biblio

The use of uninitialized value flooding plack-error
can get rather distracting and annoying.
By using "// q{}" after each of the subfield() calls
this eliminates the problem

TEST PLAN
---------
vertical break where you stop your cut-and-paste.
This test should be repeatable with cut-and-paste
easily.

restart_all
kshell

prove t/db_dependent/Koha/Biblio.t
-- may strangely be quiet.

prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Biblio.t
-- should be noisy.

prove t/db_dependent/Koha/Biblio.t
-- will always be noisy now.

exit
git bz apply 23310

restart_all
kshell

prove t/db_dependent/Koha/Biblio.t
-- will be quiet.

prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Biblio.t
-- will be quiet.

prove t/db_dependent/Koha/Biblio.t
-- will be quiet.

qa -v 2 -c 1

Signed-off-by: David Nind <[hidden email]>
Signed-off-by: Martin Renvoize <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23310] Noisy Koha::Biblio

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23310

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize@ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Failed QA

--- Comment #7 from Martin Renvoize <[hidden email]> ---
Nice little fix and I'm adding an SO line to PQA on this bit.. however overall
it's a FQA as I'd really like to see a simple regression test added please ;)

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23310] Noisy Koha::Biblio

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23310

David Nind <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #8 from David Nind <[hidden email]> ---
Just for the record here are the results of testing.

Before applying patch
~~~~~~~~~~~~~~~~~~~~~

root@8ef967b22df7:koha(bz23310)$ prove t/db_dependent/Koha/Biblio.t
t/db_dependent/Koha/Biblio.t .. 5/6 Use of uninitialized value in concatenation
(.) or string at /kohadevbox/koha/Koha/Biblio.pm line 582.
Use of uninitialized value in concatenation (.) or string at
/kohadevbox/koha/Koha/Biblio.pm line 582.
Use of uninitialized value in concatenation (.) or string at
/kohadevbox/koha/Koha/Biblio.pm line 582.
t/db_dependent/Koha/Biblio.t .. ok
All tests successful.
Files=1, Tests=6,  2 wallclock secs ( 0.02 usr  0.01 sys +  1.75 cusr  0.16
csys =  1.94 CPU)
Result: PASS

root@8ef967b22df7:koha(bz23310)$ prove t/db_dependent/Koha/Biblios.t
t/db_dependent/Koha/Biblio.t
t/db_dependent/Koha/Biblios.t .. ok
t/db_dependent/Koha/Biblio.t ... 4/6 Use of uninitialized value in
concatenation (.) or string at /kohadevbox/koha/Koha/Biblio.pm line 582.
Use of uninitialized value in concatenation (.) or string at
/kohadevbox/koha/Koha/Biblio.pm line 582.
Use of uninitialized value in concatenation (.) or string at
/kohadevbox/koha/Koha/Biblio.pm line 582.
t/db_dependent/Koha/Biblio.t ... ok
All tests successful.
Files=2, Tests=11,  5 wallclock secs ( 0.03 usr  0.01 sys +  4.43 cusr  0.57
csys =  5.04 CPU)
Result: PASS

root@8ef967b22df7:koha(bz23310)$ prove t/db_dependent/Koha/Biblio.t
t/db_dependent/Koha/Biblio.t .. 4/6 Use of uninitialized value in concatenation
(.) or string at /kohadevbox/koha/Koha/Biblio.pm line 582.
Use of uninitialized value in concatenation (.) or string at
/kohadevbox/koha/Koha/Biblio.pm line 582.
Use of uninitialized value in concatenation (.) or string at
/kohadevbox/koha/Koha/Biblio.pm line 582.
t/db_dependent/Koha/Biblio.t .. ok
All tests successful.
Files=1, Tests=6,  2 wallclock secs ( 0.02 usr  0.00 sys +  1.71 cusr  0.18
csys =  1.91 CPU)
Result: PASS

After applying patch
~~~~~~~~~~~~~~~~~~~~

root@8ef967b22df7:koha(bz23310)$ prove t/db_dependent/Koha/Biblio.t
t/db_dependent/Koha/Biblio.t .. ok
All tests successful.
Files=1, Tests=6,  2 wallclock secs ( 0.03 usr  0.00 sys +  1.67 cusr  0.22
csys =  1.92 CPU)
Result: PASS

root@8ef967b22df7:koha(bz23310)$ prove t/db_dependent/Koha/Biblios.t
t/db_dependent/Koha/Biblio.t
t/db_dependent/Koha/Biblios.t .. ok
t/db_dependent/Koha/Biblio.t ... ok
All tests successful.
Files=2, Tests=11,  5 wallclock secs ( 0.03 usr  0.01 sys +  4.29 cusr  0.49
csys =  4.82 CPU)
Result: PASS

root@8ef967b22df7:koha(bz23310)$ prove t/db_dependent/Koha/Biblio.t
t/db_dependent/Koha/Biblio.t .. ok
All tests successful.
Files=1, Tests=6,  2 wallclock secs ( 0.03 usr  0.00 sys +  1.77 cusr  0.16
csys =  1.96 CPU)
Result: PASS

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/