[Bug 23281] New: Add Koha::Objects::Limit::Library

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 23281] New: Add Koha::Objects::Limit::Library

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

            Bug ID: 23281
           Summary: Add Koha::Objects::Limit::Library
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

Add a generic class that can be used to add ->search_with_library_limits method
to classes that already rely on Koha::Object::Limit::Library, but handle
searching with limits manually.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23281] Add Koha::Objects::Limit::Library

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17755
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755
[Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23281] Add Koha::Objects::Limit::Library

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

--- Comment #1 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 91415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91415&action=edit
Bug 23281: Add Koha::Objects::Limit::Library

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23281] Add Koha::Objects::Limit::Library

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

--- Comment #2 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 91416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91416&action=edit
Bug 23281: Implement ->search_with_library_limits in
Koha::Patron::Attribute::Types

This patch makes Koha::Patron::Attribute::Types inherit from
Koha::Objects::Limit::Library so it now has the
->search_with_library_limits method.

Tests are adjusted so it is clear that there is no behaviour change
compared to the (previsouly) called ->search

To test:
- Run:
 k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t
=> SUCCESS: Tests pass!
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t
=> SUCCESS: Tests still pass!
- Sign off :-D

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23281] Add Koha::Objects::Limit::Library

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

--- Comment #3 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 91417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91417&action=edit
Bug 23281: Cleanup Koha::Patron::Attribute::Types->search

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23281] Add Koha::Objects::Limit::Library

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org,
                   |                            |[hidden email],
                   |                            |martin.renvoize@ptfs-europe
                   |                            |.com
             Blocks|                            |23272, 23271

--- Comment #4 from Tomás Cohen Arazi <[hidden email]> ---
Note to testers: Koha::Patron::Attribute::Tyes->search is not actually used in
the code. It should be used for getting rid of C4::AttributeTypes. Once we have
a clear idea about this patchset, this tasks could be done easily during this
release cycle.

I have already filed bug 23272 and bug 23271, that would benefit from this dev.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271
[Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272
[Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23281] Add Koha::Objects::Limit::Library

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91415|0                           |1
        is obsolete|                            |
  Attachment #91416|0                           |1
        is obsolete|                            |
  Attachment #91417|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <[hidden email]> ---
Created attachment 91459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91459&action=edit
Bug 23281: Add Koha::Objects::Limit::Library

Signed-off-by: Kyle M Hall <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23281] Add Koha::Objects::Limit::Library

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

--- Comment #6 from Kyle M Hall <[hidden email]> ---
Created attachment 91460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91460&action=edit
Bug 23281: Implement ->search_with_library_limits in
Koha::Patron::Attribute::Types

This patch makes Koha::Patron::Attribute::Types inherit from
Koha::Objects::Limit::Library so it now has the
->search_with_library_limits method.

Tests are adjusted so it is clear that there is no behaviour change
compared to the (previsouly) called ->search

To test:
- Run:
 k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t
=> SUCCESS: Tests pass!
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t
=> SUCCESS: Tests still pass!
- Sign off :-D

Signed-off-by: Kyle M Hall <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23281] Add Koha::Objects::Limit::Library

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

--- Comment #7 from Kyle M Hall <[hidden email]> ---
Created attachment 91461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91461&action=edit
Bug 23281: Cleanup Koha::Patron::Attribute::Types->search

Signed-off-by: Kyle M Hall <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23281] Add Koha::Objects::Limit::Library

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/