[Bug 23051] New: Optionally renew fine accruing items when all fines on item are paid off

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 23051] New: Optionally renew fine accruing items when all fines on item are paid off

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

            Bug ID: 23051
           Summary: Optionally renew fine accruing items when all fines on
                    item are paid off
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]
  Target Milestone: ---

Currently, if a user pays an accruing fine on an overdue item but forgets to
renew the item fines start accruing again.

If a user pays off the amount outstanding on an item with an accruing fine
(accounttype "OVERDUE" & status "UNRETURNED" in 19.05) via the OPAC or
self-service, or a member of staff takes payment in the staff client, attempt
to automatically renew the item according to circulation rules.

This behaviour should be controlled by a new syspref
"RenewAccruingItemWhenPaid" which is initially turned off.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23051] Optionally renew fine accruing items when all fines on item are paid off

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[hidden email]-commun |andrew.isherwood@ptfs-europ
                   |ity.org                     |e.com

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23051] Optionally renew fine accruing items when all fines on item are paid off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

--- Comment #1 from Andrew Isherwood <[hidden email]> ---
Created attachment 90559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90559&action=edit
Bug 23051: Add RenewAccruingItemWhenPaid syspref

This patch adds the new syspref "RenewAccruingItemWhenPaid"

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23051] Optionally renew fine accruing items when all fines on item are paid off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

--- Comment #2 from Andrew Isherwood <[hidden email]> ---
Created attachment 90560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90560&action=edit
Bug 23051: Renew items when fines paid off

When the RenewAccruingItemWhenPaid syspref is enabled and all the fines
on an item that is accruing fines are paid, we automatically renew that
item to prevent it from starting to accrue fines again.

This patch adds an additional argument to C4::Circulation::AddRenewal
which allows us to skip the calculation of fines upon renewal, which we
don't want to do if the fines on that item have just been paid. Existing
calls to AddRenewal have not been amended because there seems to be a
convention of only passing undef when adding arguments that require
their positioning to be maintained. Since the new argument is the last
one, this is not the case with any existing call.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23051] Optionally renew fine accruing items when all fines on item are paid off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

--- Comment #3 from Andrew Isherwood <[hidden email]> ---
Created attachment 90561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90561&action=edit
Bug 23051: Add unit tests

This patch adds unit tests for all modules affected by this bug

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 23051] Optionally renew fine accruing items when all fines on item are paid off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #4 from Andrew Isherwood <[hidden email]> ---
Test plan:

- In Administration, search for the new syspref "RenewAccruingItemWhenPaid"
- TEST: Observe that the new syspref exists and is turned off by default
- Turn on the syspref
- Loan an item to a patron, ensure you choose a patron, branch and item
combination that will incur overdue fines
- Backdate the due date to the past so the loan will accrue fines
- Run the fines.pl cronjob (misc/cronjobs/fines.pl)
- Go to the patron's "Accounting" page and choose "Pay" against the item that
has the fine
- Enter an amount to pay that will fully pay off the item and click "Confirm"
- Go to the patron's checkouts list
- TEST: Observe that the item has been renewed as part of the fine payment
process

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/