[Bug 22877] New: Returning a lost item not marked as returned can generate additional overdue fines

classic Classic list List threaded Threaded
39 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] New: Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

            Bug ID: 22877
           Summary: Returning a lost item not marked as returned can
                    generate additional overdue fines
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Circulation
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]
  Target Milestone: ---

To recreate:
1 - Issue an item to a patron with a backdated due date
2 - Run fines.pl - note you generate a fine for the patron
3 - Run longoverdue.pl - make sure MarkLostItemsAsReturned is turned off and to
charge
4 - Confirm the patron has a lost fee and an overdue
5 - Return the item
6 - Patron now has 2 overdue fines and a lost fine?

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

--- Comment #1 from Nick Clemens <[hidden email]> ---
Created attachment 89505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89505&action=edit
Bug 22877: Unit test to highlight problem

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org,
                   |                            |martin.renvoize@ptfs-europe
                   |                            |.com, [hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22539

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

--- Comment #2 from Martin Renvoize <[hidden email]> ---
I presume 'CalculateFinesOnReturn' comes into play here too?

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

--- Comment #3 from Martin Renvoize <[hidden email]> ---
(In reply to Martin Renvoize from comment #2)
> I presume 'CalculateFinesOnReturn' comes into play here too?

Sorry.. it's right there in the test as enabled at the top.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

--- Comment #4 from Martin Renvoize <[hidden email]> ---
Created attachment 89507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89507&action=edit
Bug 22877: Prevent double overdue processing for lost and returned

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89505|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <[hidden email]> ---
Created attachment 89508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89508&action=edit
Bug 22877: Unit test to highlight problem

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89507|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <[hidden email]> ---
Created attachment 89509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89509&action=edit
Bug 22877: Prevent double overdue processing for lost and returned

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

--- Comment #7 from Martin Renvoize <[hidden email]> ---
Created attachment 89510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89510&action=edit
Bug 22877: (follow-up) Fix test plan count

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |martin.renvoize@ptfs-europe
                   |ity.org                     |.com

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_19_05_candidate

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89508|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <[hidden email]> ---
Created attachment 89511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89511&action=edit
Bug 22877: Unit test to highlight problem

Signed-off-by: Martin Renvoize <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89509|0                           |1
        is obsolete|                            |

--- Comment #9 from Martin Renvoize <[hidden email]> ---
Created attachment 89512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89512&action=edit
Bug 22877: Prevent double overdue processing for lost and returned

Signed-off-by: Martin Renvoize <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89510|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <[hidden email]> ---
Created attachment 89513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89513&action=edit
Bug 22877: (follow-up) Fix test plan count

Signed-off-by: Martin Renvoize <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

--- Comment #11 from Martin Renvoize <[hidden email]> ---
Created attachment 89514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89514&action=edit
Bug 22877: (QA follow-up) Clarify intent of tests and remove one.

The intent of these tests as a set were not entirely clear. This patch
clarifies the intent for future developers and removes a superflous one.

Signed-off-by: Martin Renvoize <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

--- Comment #12 from Martin Renvoize <[hidden email]> ---
Test plan..
1. Recreate the issue as in the first comment
2. Apply the first patch and watch the test fail
3. Apply patches 2 and 3 and watch the test pass
4. Fail to recreate the issue as in the first comment
5. Apply the last patch and re-run the tests and watch them still pass

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

--- Comment #13 from Jonathan Druart <[hidden email]> ---
(In reply to Martin Renvoize from comment #11)
> Created attachment 89514 [details] [review]
> Bug 22877: (QA follow-up) Clarify intent of tests and remove one.
>
> The intent of these tests as a set were not entirely clear. This patch
> clarifies the intent for future developers and removes a superflous one.

Can you explain a bit more?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89514|0                           |1
        is obsolete|                            |

--- Comment #14 from Martin Renvoize <[hidden email]> ---
Created attachment 89516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89516&action=edit
Bug 22877: (QA follow-up) Clarify intent of tests and remove one.

The intent of these tests as a set were not entirely clear. This patch
clarifies the intent for future developers and removes a superflous one.

Signed-off-by: Martin Renvoize <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

--- Comment #15 from Jonathan Druart <[hidden email]> ---
Wrong calls in test were caused by (just for ref):
  commit 004609e46814791fac540e1c8bfb21f647758143
  Bug 14591: Update unit tests

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Lisette Scheer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucy.vaux-harvey@ptfs-europ
                   |                            |e.com

--- Comment #16 from Lisette Scheer <[hidden email]> ---
*** Bug 20769 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Lisette Scheer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89516|0                           |1
        is obsolete|                            |

--- Comment #17 from Martin Renvoize <[hidden email]> ---
Created attachment 89527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89527&action=edit
Bug 22877: (QA follow-up) Clarify intent of tests and remove one.

This patch embelishes the existing comments slightly and removes a test
which had a FIXME, but was in fact just a duplicate of the test directly
above it.  I beleive it became a duplicate after the subroutine signature
changed at some point recently.  I also move the bug 22877 specific test
into a subtest.

Signed-off-by: Martin Renvoize <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

--- Comment #18 from Jonathan Druart <[hidden email]> ---
(In reply to Martin Renvoize from comment #17)
> Created attachment 89527 [details] [review]
> Bug 22877: (QA follow-up) Clarify intent of tests and remove one.
>
> This patch embelishes the existing comments slightly and removes a test
> which had a FIXME, but was in fact just a duplicate of the test directly
> above it.  I beleive it became a duplicate after the subroutine signature
> changed at some point recently.  I also move the bug 22877 specific test
> into a subtest.

The tests existed before the change of the signature
(bcfa31a8e37f88ab07c1e7ed954ab57684d0dcfa).

The last 3 tests were:

+    # specify return date 5 days later => overdue
+    AddIssue( $patron->unblessed, $item->{barcode}, $ten_days_ago ); # date
due was 10d ago
+    AddReturn( $item->{barcode}, $library->{branchcode}, undef, undef,
$five_days_ago );
+    is( int($patron->account->balance()), 5, 'AddReturn: pass return_date =>
overdue' );
+    Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber
})->delete;

+    # specify dropbox date 5 days before => no overdue
+    AddIssue( $patron->unblessed, $item->{barcode}, $five_days_ago ); # date
due was 5d ago
+    AddReturn( $item->{barcode}, $library->{branchcode}, undef, 1, undef,
$ten_days_ago );
+    is( int($patron->account->balance()), 0, 'AddReturn: pass return_date =>
no overdue' );
+    Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber
})->delete;

+    # specify dropbox date 5 days later => overdue, or... not
+    AddIssue( $patron->unblessed, $item->{barcode}, $ten_days_ago ); # date
due was 10d ago
+    AddReturn( $item->{barcode}, $library->{branchcode}, undef, 1, undef,
$five_days_ago );
+    is( int($patron->account->balance()), 0, 'AddReturn: pass return_date =>
no overdue in dropbox mode' ); # FIXME? This is weird, the FU fine is created (
_CalculateAndUpdateFine > C4::Overdues::UpdateFine ) then remove later (in
_FixOverduesOnReturn). Looks like it is a feature
+    Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber
})->delete;

There are all completely different, in short:
- due 10d ago, checked in 5d ago => overdue
- due 5d ago, checked in 10d ago => no overdue
- due 10d ago, checked in 5d ago (using the dropbox feature) => FIXME

Would be good to see if the FIXME is still needed or not, I'd no as we removed
the dropbox flag.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

--- Comment #19 from Jonathan Druart <[hidden email]> ---
(In reply to Jonathan Druart from comment #18)
> Would be good to see if the FIXME is still needed or not, I'd no as we
> removed the dropbox flag.

Looks ok at first glance.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22902

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Liz Rea <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Needs Signoff               |Failed QA

--- Comment #20 from Liz Rea <[hidden email]> ---
Hi,

I don't think the tests are working right :

t/db_dependent/Circulation.t (Wstat: 256 Tests: 130 Failed: 1)
  Failed test:  117
  Non-zero exit status: 1

That's the one you added yeah?

Functionally, it does seem to fix the problem. Happy to retest when you think
the tests are fixed up.

Cheers,
Liz

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89511|0                           |1
        is obsolete|                            |

--- Comment #21 from Martin Renvoize <[hidden email]> ---
Created attachment 89818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89818&action=edit
Bug 22877: Unit test to highlight problem

Signed-off-by: Martin Renvoize <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89512|0                           |1
        is obsolete|                            |

--- Comment #22 from Martin Renvoize <[hidden email]> ---
Created attachment 89819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89819&action=edit
Bug 22877: Prevent double overdue processing for lost and returned

Signed-off-by: Martin Renvoize <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12