[Bug 22744] New: 'Do not notify' is really a 'Clear' option

classic Classic list List threaded Threaded
23 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] New: 'Do not notify' is really a 'Clear' option

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

            Bug ID: 22744
           Summary: 'Do not notify' is really a 'Clear' option
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Notices
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
  Target Milestone: ---

'Do not notify' in messages sort of hints that messages will be prevented,
however, when checked it simply clear the other boxes.

Hold notices wil generate print even when nothing is selected, so we shouldn't
imply that there is an 'Opt out'/'Do not notify' (see bug 5501 for that)

The goal of this bug is to simply rename this option

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

--- Comment #1 from Nick Clemens <[hidden email]> ---
Created attachment 88357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88357&action=edit
Bug 22744: Rename 'Do no notify' to 'Clear'

To test:
1 - Enable enhanced messaging prefs
2 - Allow users to set their messaging on the opac
3 - Edit a patron and check 'Do not notify'
4 - Save and note the box is empty if editing again
5 - Same on opac
6 - Apply patch
7 - Repeat and note the option now says 'Clear'
8 - Confirm this makes more sense

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=5501
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

Christopher Brannon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22745

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

Liz Rea <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

Liz Rea <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88357|0                           |1
        is obsolete|                            |

--- Comment #2 from Liz Rea <[hidden email]> ---
Created attachment 88534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88534&action=edit
Bug 22744: Rename 'Do no notify' to 'Clear'

To test:
1 - Enable enhanced messaging prefs
2 - Allow users to set their messaging on the opac
3 - Edit a patron and check 'Do not notify'
4 - Save and note the box is empty if editing again
5 - Same on opac
6 - Apply patch
7 - Repeat and note the option now says 'Clear'
8 - Confirm this makes more sense

Signed-off-by: Liz Rea <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

--- Comment #3 from Liz Rea <[hidden email]> ---
Created attachment 88535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88535&action=edit
Bug 22774 - (QA follow-up) make "clear" a little more specific

Signed-off-by: Liz Rea <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

--- Comment #4 from Christopher Brannon <[hidden email]> ---
Not to nit-pick, but wouldn't make more sense for this to be a button or link
that clears the check boxes?  It's kind of weird to have a checkbox do this.
Especially since the checkbox isn't going to retain a setting.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion
                 CC|                            |[hidden email]

--- Comment #5 from Katrin Fischer <[hidden email]> ---
It's a little long. Maybe "Clear preferences" would work too?

I think the reason it's not a button is that you still need to save the
changes. Maybe a "Clear settings" or "Clear preferences" link like we have on
the z39.50 form?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

--- Comment #6 from Nick Clemens <[hidden email]> ---
Created attachment 90454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90454&action=edit
Bug 22744: Make checkboxes links

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #7 from Katrin Fischer <[hidden email]> ---
Sorry, still not quite happy:

The table is labelled "messaging preferences" but the colunn uses "notification
perference". I think it's prefer to have it just say "Clear", but if we want
the longer version, it should use the same terminology (think translators).

Should the days in advance be reset? I feel it's not strictly necessary, but
noting.

Please also fix the subject line on the second patch!

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

--- Comment #8 from Katrin Fischer <[hidden email]> ---
It might be questionable if we need the column at all? There are not that many
columns to not be able to uncheck them quickly. (just a side note as this
feature seems more confusing than helpful atm)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

--- Comment #9 from Katrin Fischer <[hidden email]> ---
bug 5501 seems a possible duplicate (just found it by accident, didn't read all
the discussion)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

--- Comment #10 from Nick Clemens <[hidden email]> ---
Created attachment 90568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90568&action=edit
Bug 22744: Name the column clear

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88534|0                           |1
        is obsolete|                            |
  Attachment #88535|0                           |1
        is obsolete|                            |
  Attachment #90454|0                           |1
        is obsolete|                            |
  Attachment #90568|0                           |1
        is obsolete|                            |

--- Comment #11 from Nick Clemens <[hidden email]> ---
Created attachment 90569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90569&action=edit
Bug 22744: Rename 'Do no notify' to 'Clear'

To test:
1 - Enable enhanced messaging prefs
2 - Allow users to set their messaging on the opac
3 - Edit a patron and check 'Do not notify'
4 - Save and note the box is empty if editing again
5 - Same on opac
6 - Apply patch
7 - Repeat and note the option now says 'Clear'
8 - Confirm this makes more sense

Signed-off-by: Liz Rea <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

--- Comment #12 from Nick Clemens <[hidden email]> ---
Created attachment 90570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90570&action=edit
Bug 22774 - (QA follow-up) make "clear" a little more specific

Signed-off-by: Liz Rea <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

--- Comment #13 from Nick Clemens <[hidden email]> ---
Created attachment 90571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90571&action=edit
Bug 22744: Make checkboxes links

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

--- Comment #14 from Nick Clemens <[hidden email]> ---
Created attachment 90572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90572&action=edit
Bug 22744: Name the column clear

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

--- Comment #15 from Nick Clemens <[hidden email]> ---
Created attachment 90574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90574&action=edit
Bug 22744: [alternate] Remove the 'do not notify' buttons

These checkboxes are simply a way to clear the prefs before editing. We are not
saving
a lot of click, and we are confusing people, this patch simply removes them

To test:
1 - Edit a patron's messaging preferences
2 - Think too hard about the 'Do not notify' boxes
3 - Feel confused
4 - Apply this patch
5 - Edit a patron's messaging preferences
6 - Confirm it feels better

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22744] 'Do not notify' is really a 'Clear' option

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

--- Comment #16 from Nick Clemens <[hidden email]> ---
(In reply to Katrin Fischer from comment #9)
> bug 5501 seems a possible duplicate (just found it by accident, didn't read
> all the discussion)

Bug 5501 goes the other way - it seeks to actually add a way to prevent sending
notifications to the patron all together. Actually implementing 'Do not notify'
as an option and not a clear button

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/