[Bug 22715] New: Searching for patrons with "" in the circulation note hangs patron search

classic Classic list List threaded Threaded
42 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] New: Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

            Bug ID: 22715
           Summary: Searching for patrons with "" in the circulation note
                    hangs patron search
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Patrons
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]
  Target Milestone: ---

To replicate:
Edit a patron to have a circ note, include quoted text in it, such as "this is
quoted string"

Go to the patron search, search for a set of results that would include the
patron with the quotes in the note

Enjoy looking at "Processing" for forever.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

--- Comment #1 from Kyle M Hall <[hidden email]> ---
Created attachment 88074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88074&action=edit
Bug 22715: Searching for patrons with "" in the circulation note hangs patron
search

To replicate:
Edit a patron to have a circ note, include quoted text in it, such as "this is
quoted string"
Go to the patron search, search for a set of results that would include the
patron with the quotes in the note
Enjoy looking at "Processing" for forever.

Test Plan:
1) Apply this patch
2) Attempt to replicate using the steps above

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Liz Rea <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Liz Rea <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88074|0                           |1
        is obsolete|                            |

--- Comment #2 from Liz Rea <[hidden email]> ---
Created attachment 88076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88076&action=edit
Bug 22715: Searching for patrons with "" in the circulation note hangs patron
search

To replicate:
Edit a patron to have a circ note, include quoted text in it, such as "this is
quoted string"
Go to the patron search, search for a set of results that would include the
patron with the quotes in the note
Enjoy looking at "Processing" for forever.

Test Plan:
1) Apply this patch
2) Attempt to replicate using the steps above

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Liz Rea <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88076|0                           |1
        is obsolete|                            |

--- Comment #3 from Liz Rea <[hidden email]> ---
Created attachment 88077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88077&action=edit
Bug 22715: Searching for patrons with "" in the circulation note hangs patron
search

To replicate:
Edit a patron to have a circ note, include quoted text in it, such as "this is
quoted string"
Go to the patron search, search for a set of results that would include the
patron with the quotes in the note
Enjoy looking at "Processing" for forever.

Test Plan:
1) Apply this patch
2) Attempt to replicate using the steps above

Signed-off-by: Liz Rea <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Liz Rea <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=21949

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88077|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <[hidden email]> ---
Created attachment 88116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88116&action=edit
Bug 22715: Searching for patrons with "" in the circulation note hangs patron
search

To replicate:
Edit a patron to have a circ note, include quoted text in it, such as "this is
quoted string"
Go to the patron search, search for a set of results that would include the
patron with the quotes in the note
Enjoy looking at "Processing" for forever.

Test Plan:
1) Apply this patch
2) Attempt to replicate using the steps above

Signed-off-by: Liz Rea <[hidden email]>

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22702
                 CC|                            |[hidden email]

--- Comment #5 from Katrin Fischer <[hidden email]> ---
This works as described, my only concern would be that we should handle these
kinds of characters in a more global approach - this only fixes one field.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22702
[Bug 22702] Circulation note on patron page should allow for HTML tags
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Passed QA                   |Failed QA

--- Comment #6 from Nick Clemens <[hidden email]> ---
I think we need to look a little more here.

A note like:
"Don't checkout to me!"

will still break the results page

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from Kyle M Hall <[hidden email]> ---
(In reply to Katrin Fischer from comment #5)
> This works as described, my only concern would be that we should handle
> these kinds of characters in a more global approach - this only fixes one
> field.

This entire script needs to be re-engineered to output json using the JSON
module at the end of the script instead of using a template to generate json.
This will solve all these encoding problems.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

--- Comment #8 from Katrin Fischer <[hidden email]> ---
(In reply to Kyle M Hall from comment #7)
> (In reply to Katrin Fischer from comment #5)
> > This works as described, my only concern would be that we should handle
> > these kinds of characters in a more global approach - this only fixes one
> > field.
>
> This entire script needs to be re-engineered to output json using the JSON
> module at the end of the script instead of using a template to generate
> json. This will solve all these encoding problems.

Makes sense. My thinking here was that as we have another patch right now
making HTML available for this field it might be worth catching some of the
possible problems that would break search immediately.

We also have similar problems in item search - we have a publisher with a
backslash that breaks the item search regularly. We might want to take a closer
look at the places where we work with JSON.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Liz Rea <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #9 from Liz Rea <[hidden email]> ---
I think we need to get this in, because this case will happen quite often and a
partial fix now is better than months later complete fix. I've been seeing this
crop up ever since the patron search results were converted to JSON, which
means this bug has technically been active for at least 5 releases now.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20891

--- Comment #10 from Jonathan Druart <[hidden email]> ---
See bug 20891 for a similar issue, I think it is the correct fix.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22316

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88116|0                           |1
        is obsolete|                            |

--- Comment #11 from Kyle M Hall <[hidden email]> ---
Created attachment 88749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88749&action=edit
Bug 22715: Searching for patrons with "" in the circulation note hangs patron
search

To replicate:
Edit a patron to have a circ note, include quoted text in it, such as "this is
quoted string"
Go to the patron search, search for a set of results that would include the
patron with the quotes in the note
Enjoy looking at "Processing" for forever.

Test Plan:
1) Apply this patch
2) Attempt to replicate using the steps above

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20891


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891
[Bug 20891] Lists in staff don't load when \ was used in the description
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Liz Rea <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Liz Rea <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88749|0                           |1
        is obsolete|                            |

--- Comment #12 from Liz Rea <[hidden email]> ---
Created attachment 88786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88786&action=edit
Bug 22715: Searching for patrons with "" in the circulation note hangs patron
search

To replicate:
Edit a patron to have a circ note, include quoted text in it, such as "this is
quoted string"
Go to the patron search, search for a set of results that would include the
patron with the quotes in the note
Enjoy looking at "Processing" for forever.

Test Plan:
1) Apply this patch
2) Attempt to replicate using the steps above

Signed-off-by: Liz Rea <[hidden email]>
I took this a step further and used <script>"something in
quotes"</script> for my test note and this worked just fine. YAY.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

--- Comment #13 from Katrin Fischer <[hidden email]> ---
I am in doubt about the filters used here:

"[% data.borrowernotes | html_line_break | collapse | html | $To %]"

html_line_break = turns line breaks into <br> OK
collapse = removes additional whitespace - OK
html = escapes... so it shoudl escape the <br> tags
$To = ?

We had other cases where we needed to switch to html html_line_break to make
things work. Can someone help me out here an explain?

That said.... it DOES work.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #14 from Katrin Fischer <[hidden email]> ---
Ok... actually it's me: I was testing without the patch applied. It did work.
But now with the patch, I have:

<b>TEst</b><br /> das <br /> Hier\

Instead of the correct display.

Without the patch (just master), I get:

TEst (in bold)
das
Hier\

Help?

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

--- Comment #15 from Nick Clemens <[hidden email]> ---
Created attachment 88804
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88804&action=edit
Bug 22715: Remove extraneous html filter

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

--- Comment #16 from Nick Clemens <[hidden email]> ---
(In reply to Katrin Fischer from comment #13)
> I am in doubt about the filters used here:
>
> "[% data.borrowernotes | html_line_break | collapse | html | $To %]"

I think we just need one html filter - the link break should take care of
filtering:
[% data.borrowernotes | html_line_break | collapse | $To %]

Alternately:
If we don't want to process any of the html here but add line breaks:
[% data.borrowernotes | html | html_line_break | collapse | $To %]

I suspect we do expect 'bold' etc to be processed though, I imagine some
libraries could have links here

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

--- Comment #17 from Katrin Fischer <[hidden email]> ---
(In reply to Nick Clemens from comment #16)

> (In reply to Katrin Fischer from comment #13)
> > I am in doubt about the filters used here:
> >
> > "[% data.borrowernotes | html_line_break | collapse | html | $To %]"
>
> I think we just need one html filter - the link break should take care of
> filtering:
> [% data.borrowernotes | html_line_break | collapse | $To %]
>
> Alternately:
> If we don't want to process any of the html here but add line breaks:
> [% data.borrowernotes | html | html_line_break | collapse | $To %]
>  
> I suspect we do expect 'bold' etc to be processed though, I imagine some
> libraries could have links here

I don't think that html_line_break does any escapign beyond changing the new
lines. I think actually there should be a $raw as we just allowed to add HTML
to that field.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

--- Comment #18 from Nick Clemens <[hidden email]> ---
(In reply to Katrin Fischer from comment #17)
> I don't think that html_line_break does any escapign beyond changing the new
> lines. I think actually there should be a $raw as we just allowed to add
> HTML to that field.


I don't think we need a raw since we are filtering in other ways, I think we do
want the link breaks, so this works as expected, no?

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715

--- Comment #19 from Katrin Fischer <[hidden email]> ---
I think the $raw would have no other effect than showing we want HTML there. We
are not really filtering.. we are adding and removing whitespace. Not sure what
$To all does. Need another opinion, maybe Jonathan?

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12