[Bug 22710] New: Return to the last advanced search link not filtering correctly in 18.11.x

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 22710] New: Return to the last advanced search link not filtering correctly in 18.11.x

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710

            Bug ID: 22710
           Summary: Return to the last advanced search link not filtering
                    correctly in 18.11.x
 Change sponsored?: ---
           Product: Koha
           Version: 18.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
  Target Milestone: ---

in 18.11.x the 'Return to the last advanced search' link is broken. The
opac-search template is using the uri filter when it should probably be using
url

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22710] Return to the last advanced search link not filtering correctly in 18.11.x

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710

Lucas Gass <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22710] Return to the last advanced search link not filtering correctly in 18.11.x

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710

--- Comment #1 from Lucas Gass <[hidden email]> ---
Created attachment 88036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88036&action=edit
Attachment to Bug 22710 - Return to the last advanced search link not filtering
correctly in 18.11.x

Bug 22710: Return to the last advanced search link not filtering correctly in
18.11.x

TEST PLAN:
1. from 18.11.x perform an advanced search.
2. from the results page click on the 'Return to the last advanced search'
link.
3. Get a 404 errror.
4. Apply patch and repeat steps 1 and 2.
5. This time you should be returned to the advanced search page.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22710] Return to the last advanced search link not filtering correctly in 18.11.x

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710

Lucas Gass <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]         |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22710] Return to the last advanced search link not filtering correctly in 18.11.x

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710

Séverine Queune <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |[hidden email]

--- Comment #2 from Séverine Queune <[hidden email]> ---
Sorry Lucas...

The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 22710:
<h1>Something went wrong !</h1>Applying: Bug 22710: Return to the last advanced
search link not filtering correctly in 18.11.x
fatal: sha1 information is lacking or useless
(koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 22710: Return to the last advanced search link not
filtering correctly in 18.11.x
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 22710 - Return to the last advanced search link not filtering correctly in
18.11.x

88036 - Attachment to Bug 22710 - Return to the last advanced search link not
filtering correctly in 18.11.x


For information : I noticed this bug in a 18.11.04 instance, but not on the
sandbox I used before applying the patch.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22710] Return to the last advanced search link not filtering correctly in 18.11.x

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710

--- Comment #3 from Lucas Gass <[hidden email]> ---
Séverine,

Did you checkout the 18.11 branch before applying this patch?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/