[Bug 22363] New: Move C4::Logs::GetLogs to Koha namespace

classic Classic list List threaded Threaded
37 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] New: Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

            Bug ID: 22363
           Summary: Move C4::Logs::GetLogs to Koha namespace
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
  Target Milestone: ---

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

--- Comment #1 from Josef Moravec <[hidden email]> ---
Created attachment 85248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85248&action=edit
Bug 22363: Add Koha::ActionLog[s] objects

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

--- Comment #2 from Josef Moravec <[hidden email]> ---
Created attachment 85249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85249&action=edit
Bug 22363: Add tests

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

--- Comment #3 from Josef Moravec <[hidden email]> ---
Created attachment 85250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85250&action=edit
Bug 22363: Use Koha::ActionLogs->search instead of GetLogs in log viewer

Test plan:
1) Use log viewer, try different parameters
2) Try screen and file export
3) prove t/db_dependent/Koha/ActionLogs.t

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20750


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
[Bug 20750] Allow timestamped auditing of ILL request events
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85250|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <[hidden email]> ---
Created attachment 85253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85253&action=edit
Bug 22363: Use Koha::ActionLogs->search instead of GetLogs in log viewer

Test plan:
1) Use log viewer, try different parameters
2) Try screen and file export
3) prove t/db_dependent/Koha/ActionLogs.t

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85253|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <[hidden email]> ---
Created attachment 85254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85254&action=edit
Bug 22363: Use Koha::ActionLogs->search instead of GetLogs in log viewer

Test plan:
1) Use log viewer, try different parameters
2) Try screen and file export
3) prove t/db_dependent/Koha/ActionLogs.t

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

--- Comment #6 from Josef Moravec <[hidden email]> ---
Created attachment 85261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85261&action=edit
Bug 22363: Update Circulation.t to use Koha::ActionLogs instead of GetLogs

Test plan:
prove t/db_dependent/Circulation.t

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew.isherwood@ptfs-europ
                   |                            |e.com

--- Comment #7 from Andrew Isherwood <[hidden email]> ---
Hi Josef - This test failure appears to be unrelated to your work, if you agree
I'm happy to sign off your patches.

koha-koha@aidev:~/kohaclone$ prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 28/124 Reducing fine for item 104734 borrower
4329 from 3.5 to 2 - MaxFine reached at
/home/koha-koha/kohaclone/C4/Overdues.pm line 570.
Use of uninitialized value $actionname in concatenation (.) or string at
/home/koha-koha/kohaclone/C4/Log.pm line 85.
Reducing fine for item 104734 borrower 4329 from 3.5 to 2 - MaxFine reached at
/home/koha-koha/kohaclone/C4/Overdues.pm line 570.
Use of uninitialized value $actionname in concatenation (.) or string at
/home/koha-koha/kohaclone/C4/Log.pm line 85.

#   Failed test at t/db_dependent/Circulation.t line 494.
#          got: '1'
#     expected: '2'
Can't call method "accounttype" on an undefined value at
t/db_dependent/Circulation.t line 496.
# Looks like your test exited with 2 just after 41.
t/db_dependent/Circulation.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 84/124 subtests

Test Summary Report
-------------------
t/db_dependent/Circulation.t (Wstat: 512 Tests: 41 Failed: 1)
  Failed test:  40
  Non-zero exit status: 2
  Parse errors: Bad plan.  You planned 124 tests but ran 41.
Files=1, Tests=41, 11 wallclock secs ( 0.03 usr  0.02 sys +  7.98 cusr  0.32
csys =  8.35 CPU)
Result: FAIL

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

--- Comment #8 from Josef Moravec <[hidden email]> ---
(In reply to Andrew Isherwood from comment #7)

> Hi Josef - This test failure appears to be unrelated to your work, if you
> agree I'm happy to sign off your patches.
>
> koha-koha@aidev:~/kohaclone$ prove t/db_dependent/Circulation.t
> t/db_dependent/Circulation.t .. 28/124 Reducing fine for item 104734
> borrower 4329 from 3.5 to 2 - MaxFine reached at
> /home/koha-koha/kohaclone/C4/Overdues.pm line 570.
> Use of uninitialized value $actionname in concatenation (.) or string at
> /home/koha-koha/kohaclone/C4/Log.pm line 85.
> Reducing fine for item 104734 borrower 4329 from 3.5 to 2 - MaxFine reached
> at /home/koha-koha/kohaclone/C4/Overdues.pm line 570.
> Use of uninitialized value $actionname in concatenation (.) or string at
> /home/koha-koha/kohaclone/C4/Log.pm line 85.
>
> #   Failed test at t/db_dependent/Circulation.t line 494.
> #          got: '1'
> #     expected: '2'
> Can't call method "accounttype" on an undefined value at
> t/db_dependent/Circulation.t line 496.
> # Looks like your test exited with 2 just after 41.
> t/db_dependent/Circulation.t .. Dubious, test returned 2 (wstat 512, 0x200)
> Failed 84/124 subtests
>
> Test Summary Report
> -------------------
> t/db_dependent/Circulation.t (Wstat: 512 Tests: 41 Failed: 1)
>   Failed test:  40
>   Non-zero exit status: 2
>   Parse errors: Bad plan.  You planned 124 tests but ran 41.
> Files=1, Tests=41, 11 wallclock secs ( 0.03 usr  0.02 sys +  7.98 cusr  0.32
> csys =  8.35 CPU)
> Result: FAIL

Hm, this one is not related with my patches, but yesterday I had it all green,
I'll try it again, but it may be caused by some data problem? Just guessing....

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85248|0                           |1
        is obsolete|                            |

--- Comment #9 from Andrew Isherwood <[hidden email]> ---
Created attachment 85594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85594&action=edit
Bug 22363: Add Koha::ActionLog[s] objects

Signed-off-by: Andrew Isherwood <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85254|0                           |1
        is obsolete|                            |

--- Comment #11 from Andrew Isherwood <[hidden email]> ---
Created attachment 85596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85596&action=edit
Bug 22363: Use Koha::ActionLogs->search instead of GetLogs in log viewer

Test plan:
1) Use log viewer, try different parameters
2) Try screen and file export
3) prove t/db_dependent/Koha/ActionLogs.t

Signed-off-by: Andrew Isherwood <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85249|0                           |1
        is obsolete|                            |

--- Comment #10 from Andrew Isherwood <[hidden email]> ---
Created attachment 85595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85595&action=edit
Bug 22363: Add tests

Signed-off-by: Andrew Isherwood <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85261|0                           |1
        is obsolete|                            |

--- Comment #12 from Andrew Isherwood <[hidden email]> ---
Created attachment 85597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85597&action=edit
Bug 22363: Update Circulation.t to use Koha::ActionLogs instead of GetLogs

Test plan:
prove t/db_dependent/Circulation.t

Signed-off-by: Andrew Isherwood <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

--- Comment #13 from Josef Moravec <[hidden email]> ---
(In reply to Andrew Isherwood from comment #12)
>
> Signed-off-by: Andrew Isherwood <[hidden email]>

Thanks for testing Andrew!

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

--- Comment #14 from Josef Moravec <[hidden email]> ---
Created attachment 85632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85632&action=edit
Bug 22363: (follow-up) Fix pod

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
             Status|Signed Off                  |Passed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85594|0                           |1
        is obsolete|                            |

--- Comment #15 from Katrin Fischer <[hidden email]> ---
Created attachment 85633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85633&action=edit
Bug 22363: Add Koha::ActionLog[s] objects

Signed-off-by: Andrew Isherwood <[hidden email]>

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85595|0                           |1
        is obsolete|                            |

--- Comment #16 from Katrin Fischer <[hidden email]> ---
Created attachment 85634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85634&action=edit
Bug 22363: Add tests

Signed-off-by: Andrew Isherwood <[hidden email]>

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85596|0                           |1
        is obsolete|                            |

--- Comment #17 from Katrin Fischer <[hidden email]> ---
Created attachment 85635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85635&action=edit
Bug 22363: Use Koha::ActionLogs->search instead of GetLogs in log viewer

Test plan:
1) Use log viewer, try different parameters
2) Try screen and file export
3) prove t/db_dependent/Koha/ActionLogs.t

Signed-off-by: Andrew Isherwood <[hidden email]>

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85597|0                           |1
        is obsolete|                            |

--- Comment #18 from Katrin Fischer <[hidden email]> ---
Created attachment 85636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85636&action=edit
Bug 22363: Update Circulation.t to use Koha::ActionLogs instead of GetLogs

Test plan:
prove t/db_dependent/Circulation.t

Signed-off-by: Andrew Isherwood <[hidden email]>

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85632|0                           |1
        is obsolete|                            |

--- Comment #19 from Katrin Fischer <[hidden email]> ---
Created attachment 85637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85637&action=edit
Bug 22363: (follow-up) Fix pod

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85633|0                           |1
        is obsolete|                            |

--- Comment #20 from Josef Moravec <[hidden email]> ---
Created attachment 85749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85749&action=edit
Bug 22363: Add Koha::ActionLog[s] objects

Signed-off-by: Andrew Isherwood <[hidden email]>

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85634|0                           |1
        is obsolete|                            |

--- Comment #21 from Josef Moravec <[hidden email]> ---
Created attachment 85750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85750&action=edit
Bug 22363: Add tests

Signed-off-by: Andrew Isherwood <[hidden email]>

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85635|0                           |1
        is obsolete|                            |

--- Comment #22 from Josef Moravec <[hidden email]> ---
Created attachment 85751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85751&action=edit
Bug 22363: Use Koha::ActionLogs->search instead of GetLogs in log viewer

Test plan:
1) Use log viewer, try different parameters
2) Try screen and file export
3) prove t/db_dependent/Koha/ActionLogs.t

Signed-off-by: Andrew Isherwood <[hidden email]>

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85636|0                           |1
        is obsolete|                            |

--- Comment #23 from Josef Moravec <[hidden email]> ---
Created attachment 85752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85752&action=edit
Bug 22363: Update Circulation.t to use Koha::ActionLogs instead of GetLogs

Test plan:
prove t/db_dependent/Circulation.t

Signed-off-by: Andrew Isherwood <[hidden email]>

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22363] Move C4::Logs::GetLogs to Koha namespace

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85637|0                           |1
        is obsolete|                            |

--- Comment #24 from Josef Moravec <[hidden email]> ---
Created attachment 85753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85753&action=edit
Bug 22363: (follow-up) Fix pod

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12