[Bug 22200] New: Forgiving a fine (FFOR) does not update the accountline date

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 22200] New: Forgiving a fine (FFOR) does not update the accountline date

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200

            Bug ID: 22200
           Summary: Forgiving a fine (FFOR) does not update the
                    accountline date
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]
  Target Milestone: ---

Each time a fine is incremented, the date column is updated. When that fine is
forgiven ( often via the "Forgive fines" option on the checkin page ), it does
not update the column. It makes sense that if updating a fine sets the date
column, forgiving it should do so as well.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22200] Forgiving a fine (FFOR) does not update the accountline date

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22200] Forgiving a fine (FFOR) does not update the accountline date

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200

--- Comment #1 from Kyle M Hall <[hidden email]> ---
Created attachment 84339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84339&action=edit
Bug 22200 - Forgiving a fine (FFOR) does not update the accountline date

Each time a fine is incremented, the date column is updated. When that fine is
forgiven ( often via the "Forgive fines" option on the checkin page ), it does
not update the column. It makes sense that if updating a fine sets the date
column, forgiving it should do so as well.

Test Plan:
1) Find a checkout that is overdue with fines, where the date is not today
2) Note the date in the accountlines table
3) Check it in, note the date is not updated
4) Apply this patch
5) Repeat steps 1-2
6) Note the date is updated!

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22200] Forgiving a fine (FFOR) does not update the accountline date

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200

Pierre-Marc Thibault <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pierre-marc.thibault@inlibr
                   |                            |o.com

--- Comment #2 from Pierre-Marc Thibault <[hidden email]> ---
I created a fine and changed it so its date is not today. I went to Pay fines
and paid, but the date did not update. Am I doing something wrong?

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22200] Forgiving a fine (FFOR) does not update the accountline date

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200

--- Comment #3 from Pierre-Marc Thibault <[hidden email]> ---
Sorry, I didn't follow the steps precisely. I didn't test on the checking in
page, but I did by the Create manual credit way and it wasn't still working.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22200] Forgiving a fine (FFOR) does not update the accountline date

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200

--- Comment #4 from Kyle M Hall <[hidden email]> ---
(In reply to Pierre-Marc Thibault from comment #2)
> I created a fine and changed it so its date is not today. I went to Pay
> fines and paid, but the date did not update. Am I doing something wrong?

That is not the action I meant. You'll need to check in the item with the
"forgive fine" option from the checkins page.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22200] Forgiving a fine (FFOR) does not update the accountline date

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200

--- Comment #5 from Kyle M Hall <[hidden email]> ---
(In reply to Pierre-Marc Thibault from comment #3)
> Sorry, I didn't follow the steps precisely. I didn't test on the checking in
> page, but I did by the Create manual credit way and it wasn't still working.

To test, you'll need a checked out overdue item with fines. Nothing else will
work.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22200] Forgiving a fine (FFOR) does not update the accountline date

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22200] Forgiving a fine (FFOR) does not update the accountline date

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200

Genevieve Beaudry <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |om
             Status|Needs Signoff               |Signed Off

--- Comment #6 from Genevieve Beaudry <[hidden email]> ---
patch working

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22200] Forgiving a fine (FFOR) does not update the accountline date

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84339|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <[hidden email]> ---
Created attachment 85219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85219&action=edit
Bug 22200: Forgiving a fine (FFOR) does not update the accountline date

Each time a fine is incremented, the date column is updated. When that fine is
forgiven ( often via the "Forgive fines" option on the checkin page ), it does
not update the column. It makes sense that if updating a fine sets the date
column, forgiving it should do so as well.

Test Plan:
1) Find a checkout that is overdue with fines, where the date is not today
2) Note the date in the accountlines table
3) Check it in, note the date is not updated
4) Apply this patch
5) Repeat steps 1-2
6) Note the date is updated!

Signed-off-by: Genevieve Beaudry <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22200] Forgiving a fine (FFOR) does not update the accountline date

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #8 from Katrin Fischer <[hidden email]> ---
I've fixed the commit subject and added Genevieve's sign-off line manually.

But I am a little confused here :(

I started my tests with verifying the current behavior and noticed that
accountlines.date is already updated to the current date when the entry is
changed to FFOR in my testing.

Can you please take a look?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/