[Bug 22044] New: NoRenewalBeforePrecision should be set by default

classic Classic list List threaded Threaded
22 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] New: NoRenewalBeforePrecision should be set by default

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

            Bug ID: 22044
           Summary: NoRenewalBeforePrecision should be set by default
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
  Target Milestone: ---

NoRenewalBeforePrecision was introduced in bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 but did not
recieve a default value

When not set the pref dropdown default to 'date' however, the behaviour if
unset matches 'exact time'

We should set it to 'exact time' by default since it is the default behaviour

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|NoRenewalBeforePrecision    |NoRenewalBeforePrecision
                   |should be set by default    |should be set by default
                   |                            |for new installations

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

--- Comment #1 from Nick Clemens <[hidden email]> ---
Created attachment 83469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83469&action=edit
Bug 22044: Set default and add NoRenewalBeforePrecision preference for
new/affected installs

I am not sure the correct answer - for upgraded installs the pref was
set to date, which changed behaviour

For new installs the pref was unset, behaved as if 'exact_time' so we
shouldn't change behaviour?

If the perceived default is date then the code should be changed, or
this shouldn't be a pref at all?

To test:
1 - Have a new system missing this pref
2 - Note when searchign the pref in staff client if appears as 'date'
3 - Check the db to confirm value is 'NULL'
4 - Apply patch and run update
5 - Pref is now set to 'exact_time'

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--- Comment #2 from Katrin Fischer <[hidden email]> ---
Nick, don't make your QAM grumpy, assign your bugs! ;)

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

Hayley Mapley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |z

--- Comment #3 from Hayley Mapley <[hidden email]> ---
(In reply to Katrin Fischer from comment #2)
> Nick, don't make your QAM grumpy, assign your bugs! ;)

Hi Nick,

I'm in the process of testing your patch, and am stuck at step 3 - check db to
confirm value is 'NULL'. Probably because I'm a newbie, but I can't locate the
NoRenewalBeforePrecision that you mention in the systempreferences table to
check that it has the value of NULL. The system preference does show up in the
staff client. Am I missing something?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

--- Comment #4 from Hayley Mapley <[hidden email]> ---

(In reply to Nick Clemens from comment #1)

> 3 - Check the db to confirm value is 'NULL'

I am guessing that this is instructing us to check whether the preference is
actually in the database, rather than whether it's value cell is set to null.
If this is the case, I am able to sign off as the test plan results were as
expected.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

Hayley Mapley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83469|0                           |1
        is obsolete|                            |

--- Comment #5 from Hayley Mapley <[hidden email]> ---
Created attachment 87975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87975&action=edit
Bug 22044: Set default and add NoRenewalBeforePrecision preference for
new/affected installs

I am not sure the correct answer - for upgraded installs the pref was
set to date, which changed behaviour

For new installs the pref was unset, behaved as if 'exact_time' so we
shouldn't change behaviour?

If the perceived default is date then the code should be changed, or
this shouldn't be a pref at all?

To test:
1 - Have a new system missing this pref
2 - Note when searchign the pref in staff client if appears as 'date'
3 - Check the db to confirm value is 'NULL'
4 - Apply patch and run update
5 - Pref is now set to 'exact_time'

Signed-off-by: Hayley Mapley <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

Hayley Mapley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

--- Comment #6 from Julian Maurice <[hidden email]> ---
Comment on attachment 87975
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87975
Bug 22044: Set default and add NoRenewalBeforePrecision preference for
new/affected installs

Review of attachment 87975:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22044&attachment=87975)
-----------------------------------------------------------------

::: installer/data/mysql/sysprefs.sql
@@ +310,4 @@
>  ('noissuescharge','5','','Define maximum amount withstanding before check outs are blocked','Integer'),
>  ('NoIssuesChargeGuarantees','','','Define maximum amount withstanding before check outs are blocked','Integer'),
>  ('noItemTypeImages','0',NULL,'If ON, disables item-type images','YesNo'),
> +('NoRenewalBefore','exact_time','date|exact_time','Calculate NoRenewalBefore based on date only or exact time of due date','Choice'),

'NoRenewalBefore' should be 'NoRenewalBeforePrecision'

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

Julian Maurice <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

--- Comment #7 from Nick Clemens <[hidden email]> ---
Created attachment 88003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88003&action=edit
Bug 22044: Correct syspref name

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

--- Comment #8 from Hayley Mapley <[hidden email]> ---
(In reply to Nick Clemens from comment #7)
> Created attachment 88003 [details] [review]
> Bug 22044: Correct syspref name

Sorry Nick, the syspref description still references NoRenewalBefore rather
than NoRenewalBeforePrecision. Not a big deal so I'll leave as signed off, but
would be good for consistency.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

--- Comment #9 from Julian Maurice <[hidden email]> ---
(In reply to Hayley Mapley from comment #8)
> (In reply to Nick Clemens from comment #7)
> > Created attachment 88003 [details] [review] [review]
> > Bug 22044: Correct syspref name
>
> Sorry Nick, the syspref description still references NoRenewalBefore rather
> than NoRenewalBeforePrecision. Not a big deal so I'll leave as signed off,
> but would be good for consistency.

Not sure if this is a reference to the syspref or to the feature.
Anyway, description in atomic update should match the one in sysprefs.sql

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

--- Comment #10 from Hayley Mapley <[hidden email]> ---
(In reply to Julian Maurice from comment #9)

> (In reply to Hayley Mapley from comment #8)
> > (In reply to Nick Clemens from comment #7)
> > > Created attachment 88003 [details] [review] [review] [review]
> > > Bug 22044: Correct syspref name
> >
> > Sorry Nick, the syspref description still references NoRenewalBefore rather
> > than NoRenewalBeforePrecision. Not a big deal so I'll leave as signed off,
> > but would be good for consistency.
>
> Not sure if this is a reference to the syspref or to the feature.
> Anyway, description in atomic update should match the one in sysprefs.sql

I am referring to your INSERT statement in the sysprefs.sql:

313
('NoRenewalBeforePrecision','exact_time','date|exact_time','Calculate
NoRenewalBefore based on date only or exact time of due date','Choice'),

It should read 'Calculate NoRenewalBeforePrecision based on...'

Like I say, not a big deal, but would be good for consistency

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

--- Comment #11 from Katrin Fischer <[hidden email]> ---
I am with Hayley, NoRenewalBefore is not a thing, the column in sysprefs is
labelled "No renewal before" - I'll put forward a follow-up patch :)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87975|0                           |1
        is obsolete|                            |

--- Comment #12 from Katrin Fischer <[hidden email]> ---
Created attachment 88121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88121&action=edit
Bug 22044: Set default and add NoRenewalBeforePrecision preference for
new/affected installs

I am not sure the correct answer - for upgraded installs the pref was
set to date, which changed behaviour

For new installs the pref was unset, behaved as if 'exact_time' so we
shouldn't change behaviour?

If the perceived default is date then the code should be changed, or
this shouldn't be a pref at all?

To test:
1 - Have a new system missing this pref
2 - Note when searchign the pref in staff client if appears as 'date'
3 - Check the db to confirm value is 'NULL'
4 - Apply patch and run update
5 - Pref is now set to 'exact_time'

Signed-off-by: Hayley Mapley <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88003|0                           |1
        is obsolete|                            |

--- Comment #13 from Katrin Fischer <[hidden email]> ---
Created attachment 88122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88122&action=edit
Bug 22044: Correct syspref name

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

--- Comment #14 from Katrin Fischer <[hidden email]> ---
Created attachment 88123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88123&action=edit
Bug 22044: Fix sysprefs.sql description to use circ column description

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #15 from Nick Clemens <[hidden email]> ---
Awesome work all!

Pushed to master for 19.05

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/