[Bug 21983] New: Deleting a bib does not delete a request's link to it - missing foreign key

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 21983] New: Deleting a bib does not delete a request's link to it - missing foreign key

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983

            Bug ID: 21983
           Summary: Deleting a bib does not delete a request's link to it
                    - missing foreign key
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: ILL
          Assignee: [hidden email]
          Reporter: [hidden email]

illrequests.biblio_id should be a foreign key to biblio.biblionumber, but it's
not! When a biblio is deleted, illrequests.biblio_id should be null-ed

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |5334


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334
[Bug 5334] add explicit foreign key constraints
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[hidden email]-commun |andrew.isherwood@ptfs-europ
                   |ity.org                     |e.com

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983

--- Comment #1 from Andrew Isherwood <[hidden email]> ---
Created attachment 83226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83226&action=edit
Bug 21983: Add foreign key constraint on biblio_id

This patch adds a foreign key constraint on biblio_id, this means that,
amongst other things, if a bib is deleted that an ILL request is a
attached to, the ILL request is no longer attached to that bib.

Test plan:
- Apply the patch
- Create an ILL request, a bib should automatically be created for the
item being requested
- Note that when viewing the request, a link to the bib is displayed in
the ILL request list view
- Delete the bib
- Refresh the ILL request list view
- TEST => Note that the link to the bib no longer exists

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83226|0                           |1
        is obsolete|                            |

--- Comment #2 from Andrew Isherwood <[hidden email]> ---
Created attachment 83227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83227&action=edit
Bug 21983: Add foreign key constraint on biblio_id

This patch adds a foreign key constraint on biblio_id, this means that,
amongst other things, if a bib is deleted that an ILL request is a
attached to, the ILL request is no longer attached to that bib.

Test plan:
- Apply the patch
- Create an ILL request, a bib should automatically be created for the
item being requested
- Note that when viewing the request, a link to the bib is displayed in
the ILL request list view
- Delete the bib
- Refresh the ILL request list view
- TEST => Note that the link to the bib no longer exists

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983

Michal Denar <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |[hidden email]

--- Comment #3 from Michal Denar <[hidden email]> ---
Please rebase on master.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from Katrin Fischer <[hidden email]> ---
I am not sure about this one, as we have deleted_biblio that is often useful
for reporting. I imagine some libraries will want to remove ILL records from
the catalog once the request is finished, but might still want to have the
bibliographic information for reporting.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983

--- Comment #5 from Magnus Enger <[hidden email]> ---
(In reply to Katrin Fischer from comment #4)
> I am not sure about this one, as we have deleted_biblio that is often useful
> for reporting. I imagine some libraries will want to remove ILL records from
> the catalog once the request is finished, but might still want to have the
> bibliographic information for reporting.

I can confirm that this is indeed very true, yes.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |In Discussion

--- Comment #6 from Andrew Isherwood <[hidden email]> ---
But it's just a foreign key to the (now deleted) bib ID, is that useful
information that needs preserving? Sorry, genuine question, I'm not being
facetious :)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/