--- Comment #23 from Martin Renvoize <[hidden email]> ---
I think we should leave the FinesLog stuff in (for backwards compatibility -
perhaps we can create a deprecation plan for removing this in the future).
Both the 'pay' and 'add_credit' methods need minor adjustments to account for
the new branchcode recording. These are the main routines that should, in
theory, be used throughout Koha to work with the accountlines and
account_offset tables for payments and credits. (though I'd leave in your
adaptation to 'new' in accountlines as it's a good catchall too).
Have you considered the debits case at all? With you're overriden 'new' method
in accountlines you'll be recording branchcodes with a fallback to userenv, but
I have not yet walked the codepath backwards to check that fine creation etc
would ever actually pass through a branchcode (or whether userenv will be set
and make sense).
All worth having a quick look at.
Please don't be put off.. I do like this enhancement :)
--- Comment #24 from Martin Renvoize <[hidden email]> ---
Oooh.. also.. we'de need library_id adding to the existing api endpoints
(especially aiming for this release as the endpoint will 'go live' with 18.11
for the first time)