[Bug 21346] New: Remove return2 div from returns.tt now that modal interface exists

classic Classic list List threaded Threaded
23 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] New: Remove return2 div from returns.tt now that modal interface exists

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

            Bug ID: 21346
           Summary: Remove return2 div from returns.tt now that modal
                    interface exists
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]

Someone added a new modal for holds/transfers in return.tt (yay!).  They left
the old dialog in the background, and if you ignore the modal, it remains.  To
replicate:

1) Place a hold on an item from Branch A to be delivered to Branch B.
2) Checkin in the item at Branch A and confirm the hold to transfer.
3) Be human and make a mistake.  Login as Branch C and check the item in.
4) Note the great modal to redirect the hold.  Note that the old dialog is
behind it!

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Remove return2 div from returns.tt now that modal interface exists

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

Christopher Brannon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Remove return2 div from returns.tt now that modal interface exists

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

--- Comment #1 from Christopher Brannon <[hidden email]> ---
Created attachment 78724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78724&action=edit
[PATCH] Bug 21346: Remove old hold/transfer dialog

TO TEST:
1) Place a hold on an item from Branch A to be delivered to Branch B.
2) Checkin the item at Branch A and confirm the hold to transfer.
3) Be human and make a mistake.  Login as Branch C and check the item
in.
4) Note the great modal to redirect the hold.  Note that the old dialog
is behind it!
5) Apply the patch.
6) Repeat step 3.  Now note that the old dialog is no longer on the
page.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Remove return2 div from returns.tt now that modal interface exists

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

Christopher Brannon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Remove return2 div from returns.tt now that modal interface exists

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

Chris Cormack <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Remove return2 div from returns.tt now that modal interface exists

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

Chris Cormack <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78724|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack <[hidden email]> ---
Created attachment 78726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78726&action=edit
Bug 21346: Remove old hold/transfer dialog

TO TEST:
1) Place a hold on an item from Branch A to be delivered to Branch B.
2) Checkin the item at Branch A and confirm the hold to transfer.
3) Be human and make a mistake.  Login as Branch C and check the item
in.
4) Note the great modal to redirect the hold.  Note that the old dialog
is behind it!
5) Apply the patch.
6) Repeat step 3.  Now note that the old dialog is no longer on the
page.

Signed-off-by: Chris Cormack <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Remove return2 div from returns.tt now that modal interface exists

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

Christopher Brannon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #3 from Christopher Brannon <[hidden email]> ---
I found that this broke something else.  Back to the drawing board!

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Remove return2 div from returns.tt now that modal interface exists / Fix waiting holds at wrong location

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

Christopher Brannon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Remove return2 div from     |Remove return2 div from
                   |returns.tt now that modal   |returns.tt now that modal
                   |interface exists            |interface exists / Fix
                   |                            |waiting holds at wrong
                   |                            |location

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Remove return2 div from returns.tt now that modal interface exists / Fix waiting holds at wrong location

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

--- Comment #4 from Christopher Brannon <[hidden email]> ---
I managed to fix the patch AND fix the bug with the waiting holds being checked
in at the wrong location that do nothing!  Test plan to come.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Remove return2 div from returns.tt now that modal interface exists / Fix waiting holds at wrong location

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

--- Comment #5 from Christopher Brannon <[hidden email]> ---
Created attachment 78902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78902&action=edit
Bug 21346: Update/Fix dialogs - Fix hold waiting

TEST PLAN
1) Place a hold on an item from Branch A to be delivered to Branch B.
2) Checkin the item at Branch A and confifm the hold to transfer.
3) Be human and make a mistake.  Login as Branch C and check the item in
4) Note the great modal to redirect the hold.  Note that the old dialog
is behind it!
5) Check in the item at Branch B to put it in waiting status.
6) Be human and make another mistake.  Login as Branch C and check the
item in.  Notice it does nothing except a local hold.
7) Check out an item at Branch A.
8) Check in the item at Branch B.  Notice the classic blue transfer
dialog at the top of page.
9) Apply the patch.
10) Check everything in at their branches.
11) Repeat steps 1-8.  Now note the classic dialogs are gone and nothing
but the modals left.  Note that the waiting hold will now reroute back
the place it should be waiting.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Remove return2 div from returns.tt now that modal interface exists / Fix waiting holds at wrong location

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

Christopher Brannon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78726|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Remove return2 div from returns.tt now that modal interface exists / Fix waiting holds at wrong location

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

Christopher Brannon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Remove return2 div from returns.tt now that modal interface exists / Fix waiting holds at wrong location

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

Spencer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Needs Signoff               |Failed QA

--- Comment #6 from Spencer <[hidden email]> ---
Everything is functional- however when an item is checked in to transfer back
to its home branch (not on hold) there is no confirm option- only a force to
print a slip.  WE don't print slips for non-hold transfers.

If that scenario offered a simple "confirm" choice, it would work well.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Remove return2 div from returns.tt now that modal interface exists / Fix waiting holds at wrong location

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

--- Comment #7 from Christopher Brannon <[hidden email]> ---
Created attachment 78915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78915&action=edit
Bug 21346: Update buttons on transfer only

Added a confirm only button and updated text on print button for the
transfer dialog so you are not forced to print.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Remove return2 div from returns.tt now that modal interface exists / Fix waiting holds at wrong location

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

Christopher Brannon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #8 from Christopher Brannon <[hidden email]> ---
Added button per Spencer's suggestion.  Thanks for testing!  Please try again.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Remove return2 div from returns.tt now that modal interface exists / Fix waiting holds at wrong location

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

ByWater Sandboxes <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78915|0                           |1
        is obsolete|                            |

--- Comment #9 from ByWater Sandboxes <[hidden email]> ---
Created attachment 78916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78916&action=edit
Bug 21346: Update buttons on transfer only

Added a confirm only button and updated text on print button for the
transfer dialog so you are not forced to print.

Signed-off-by: Spencer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Remove return2 div from returns.tt now that modal interface exists / Fix waiting holds at wrong location

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

--- Comment #10 from Christopher Brannon <[hidden email]> ---
*** Bug 17339 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

Christopher Brannon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Remove return2 div from     |Clean up dialogs in
                   |returns.tt now that modal   |returns.pl / Fix waiting
                   |interface exists / Fix      |holds at wrong location bug
                   |waiting holds at wrong      |
                   |location                    |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

--- Comment #11 from Christopher Brannon <[hidden email]> ---
(In reply to ByWater Sandboxes from comment #9)
> Created attachment 78916 [details] [review]
> Bug 21346: Update buttons on transfer only
>
> Added a confirm only button and updated text on print button for the
> transfer dialog so you are not forced to print.
>
> Signed-off-by: Spencer <[hidden email]>

Spencer, when signing off, if there is more than one patch involved, you need
to sign off on the whole thing, not just a single patch.  Have Ed show you how.
 :)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

Christopher Brannon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18490


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490
[Bug 18490] Transfer message confusing, cancel button missing
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

Fred King <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

ByWater Sandboxes <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78902|0                           |1
        is obsolete|                            |

--- Comment #12 from ByWater Sandboxes <[hidden email]> ---
Created attachment 78942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78942&action=edit
Bug 21346: Update/Fix dialogs - Fix hold waiting

TEST PLAN
1) Place a hold on an item from Branch A to be delivered to Branch B.
2) Checkin the item at Branch A and confifm the hold to transfer.
3) Be human and make a mistake.  Login as Branch C and check the item in
4) Note the great modal to redirect the hold.  Note that the old dialog
is behind it!
5) Check in the item at Branch B to put it in waiting status.
6) Be human and make another mistake.  Login as Branch C and check the
item in.  Notice it does nothing except a local hold.
7) Check out an item at Branch A.
8) Check in the item at Branch B.  Notice the classic blue transfer
dialog at the top of page.
9) Apply the patch.
10) Check everything in at their branches.
11) Repeat steps 1-8.  Now note the classic dialogs are gone and nothing
but the modals left.  Note that the waiting hold will now reroute back
the place it should be waiting.

Signed-off-by: Fred King <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

ByWater Sandboxes <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78916|0                           |1
        is obsolete|                            |

--- Comment #13 from ByWater Sandboxes <[hidden email]> ---
Created attachment 78943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78943&action=edit
Bug 21346: Update buttons on transfer only

Added a confirm only button and updated text on print button for the
transfer dialog so you are not forced to print.

Signed-off-by: Spencer <[hidden email]>

Signed-off-by: Fred King <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/