[Bug 21232] New: Problems when linking a subscription to a non-existing biblionumber

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 21232] New: Problems when linking a subscription to a non-existing biblionumber

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

            Bug ID: 21232
           Summary: Problems when linking a subscription to a non-existing
                    biblionumber
 Change sponsored?: ---
           Product: Koha
           Version: 16.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Serials
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

Appeared in 16.11, for retesting in newer versions:

1) Create a new subscription, for biblionumber enter a numberic high value not
existing in your database as a valid biblionumber
2) Verify that you can save (bug 1)
3) Edit the subscription (will show with empty title in search)
4) Correct the link to the record with an existing biblionumber
5) Verify that now the title displays correctly and link to the record works
6) Check "OPAC view" link, it will still show the wrong biblionumber value,
   leading to nowhere (bug 2)
   Reason: the biblionumber in subscriptionhistory hasn't been updated
7) Check the serial table for your subscription id: there is still the wrong
value
   (bug 3)
   I feel like at least the expected issue should have been updated to the
   correct biblionumber. I am not sure if it could make sense to keep the old
   one for received issues, to keep some history of name changes etc. Maybe
   worth checking if the serial.biblionumber is used somewhere in a sensible
way?

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21232] Problems when linking a subscription to a non-existing biblionumber

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20351

--- Comment #1 from Jonathan Druart <[hidden email]> ---
Certainly a duplicate of bug 20351.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21232] Problems when linking a subscription to a non-existing biblionumber

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

--- Comment #2 from Katrin Fischer <[hidden email]> ---
(In reply to Jonathan Druart from comment #1)
> Certainly a duplicate of bug 20351.

On first glance, I don't think it is. It's catching invalid subscriptionids,
while this is about an invalid biblionumber?

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21232] Problems when linking a subscription to a non-existing biblionumber

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|16.11                       |master

--- Comment #3 from Katrin Fischer <[hidden email]> ---
Updating to master, there is still no check in place for linking subscriptions
to non-existing biblionumbers. I think this should be checked on saving or
maybe even when moving from the first part of the subscription form to the
second

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21232] Problems when linking a subscription to a non-existing biblionumber

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from Katrin Fischer <[hidden email]> ---
*** Bug 12921 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21232] Problems when linking a subscription to a non-existing biblionumber

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--- Comment #5 from Jonathan Druart <[hidden email]> ---
Now failing with

Can't call method "title" on an undefined value at
/home/vagrant/kohaclone/Koha/Subscription.pm line 165
        Koha::Subscription::get_sharable_info('Koha::Subscription', 1) called
at /home/vagrant/kohaclone/Koha/SharedContent.pm line 123
        Koha::SharedContent::prepare_entity_data('', 51, 1, 'subscription')
called at /home/vagrant/kohaclone/Koha/SharedContent.pm line 82
        Koha::SharedContent::send_entity('', 51, 1, 'subscription') called at
/home/vagrant/kohaclone/serials/subscription-add.pl line 376
       
CGI::Compile::ROOT::home_vagrant_kohaclone_serials_subscription_2dadd_2epl::redirect_add_subscription
at /home/vagrant/kohaclone/serials/subscription-add.pl line 178


It's time to add the missing FK

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/