[Bug 21206] New: C4::Items - Remove GetItem

classic Classic list List threaded Threaded
45 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] New: C4::Items - Remove GetItem

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

            Bug ID: 21206
           Summary: C4::Items - Remove GetItem
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

Let's use Koha::Items!

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18252


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252
[Bug 18252] Move C4::Items code to the Koha namespace
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

--- Comment #1 from Jonathan Druart <[hidden email]> ---
Created attachment 77699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77699&action=edit
Bug 21206: Replace C4::Items::GetItem

Note: This is here for information purpose, feel free to test it if you
wan to play with it.

TODO: C4::Reserves::_get_itype is not longer in use

No more GetItem must be returned by:
git grep GetItem|grep -v GetItemsAvailableToFillHoldRequestsForBib|grep
-v GetItemsForInventory|grep -v GetItemsInfo|grep -v
GetItemsLocationInfo|grep -v GetItemsInCollection|grep -v
GetItemCourseReservesInfo|grep -v GetItemnumbersFromOrder|grep -v
GetItemSearchField|grep -v GetItemTypesCategorized|grep -v
GetItemNumbersFromImportBatch|cut -d':' -f1|sort|uniq

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

--- Comment #2 from Jonathan Druart <[hidden email]> ---
Created attachment 77700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77700&action=edit
Bug 21206: Remove GetItem

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

--- Comment #3 from Jonathan Druart <[hidden email]> ---
Created attachment 77701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77701&action=edit
Bug 21206: Fix Returns.t

we are calling several times effective_itemtype
Must be fixed later

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21205


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205
[Bug 21205] C4::Acquisition - Remove GetOrderFromItemnumber
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

--- Comment #4 from Jonathan Druart <[hidden email]> ---
The whole dependency tree has been pushed to
https://gitlab.com/joubu/Koha/commits/bug_21206

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #5 from Jonathan Druart <[hidden email]> ---
This is ready for testing, no test plan provided.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21184


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184
[Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Mason James <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21252


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21252
[Bug 21252] Koha::Patron->do_check_for_previous_checkout should take Koha::Item
as parameter
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

--- Comment #6 from Josef Moravec <[hidden email]> ---
Comment on attachment 77699
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77699
Bug 21206: Replace C4::Items::GetItem

Review of attachment 77699:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21206&attachment=77699)
-----------------------------------------------------------------

::: C4/ILSDI/Services.pm
@@ +615,5 @@
>      # Add renewal if possible
>      my @renewal = CanBookBeRenewed( $borrowernumber, $itemnumber );
>      if ( $renewal[0] ) { AddRenewal( $borrowernumber, $itemnumber ); }
>  
> +    my $issue = $item ? $item->checkout : return; # FIXME should be handled

This does not return....

::: labels/label-edit-batch.pl
@@ +87,4 @@
>          my @numbers_list = split /\n/, $number_list; # Entries are effectively passed in as a <cr> separated list
>          foreach my $number (@numbers_list) {
>              $number =~ s/\r$//; # strip any naughty return chars
> +            if( $number_type eq "itemnumber" && Koha::ITems->find($number) ) {

ITems -> Items

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |[hidden email]

--- Comment #7 from Josef Moravec <[hidden email]> ---
Also QA tool fails:

 FAIL   acqui/orderreceive.pl
   FAIL   valid
                Global symbol "@items" requires explicit package name
                acqui/orderreceive.pl had compilation errors.

 FAIL   catalogue/getitem-ajax.pl
   FAIL   valid
                catalogue/getitem-ajax.pl had compilation errors.
                Global symbol "$item_unblessed" requires explicit package name

 FAIL   misc/recreateIssueStatistics.pl
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 124)

 FAIL   t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
   FAIL   valid
                syntax error

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77699|0                           |1
        is obsolete|                            |
  Attachment #77700|0                           |1
        is obsolete|                            |
  Attachment #77701|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <[hidden email]> ---
Created attachment 78080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78080&action=edit
Bug 21206: Replace C4::Items::GetItem

Note: This is here for information purpose, feel free to test it if you
wan to play with it.

TODO: C4::Reserves::_get_itype is not longer in use

No more GetItem must be returned by:
git grep GetItem|grep -v GetItemsAvailableToFillHoldRequestsForBib|grep
-v GetItemsForInventory|grep -v GetItemsInfo|grep -v
GetItemsLocationInfo|grep -v GetItemsInCollection|grep -v
GetItemCourseReservesInfo|grep -v GetItemnumbersFromOrder|grep -v
GetItemSearchField|grep -v GetItemTypesCategorized|grep -v
GetItemNumbersFromImportBatch|cut -d':' -f1|sort|uniq

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

--- Comment #9 from Jonathan Druart <[hidden email]> ---
Created attachment 78081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78081&action=edit
Bug 21206: Remove GetItem

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

--- Comment #10 from Jonathan Druart <[hidden email]> ---
Created attachment 78082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78082&action=edit
Bug 21206: Fix Returns.t

we are calling several times effective_itemtype
Must be fixed later

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

--- Comment #11 from Josef Moravec <[hidden email]> ---
Comment on attachment 78080
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78080
Bug 21206: Replace C4::Items::GetItem

Review of attachment 78080:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21206&attachment=78080)
-----------------------------------------------------------------

::: C4/ILSDI/Services.pm
@@ +614,5 @@
>      if ( $renewal[0] ) { AddRenewal( $borrowernumber, $itemnumber ); }
>  
> +    return unless $item; # FIXME should be handled
> +
> +    my $issue = $item->checkout;

I see still little problem here:
If item exists and is not checked out -> boom
The check and return on item is done on line 610 here, so here should be
"return unless $issue;"

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78080|0                           |1
        is obsolete|                            |
  Attachment #78081|0                           |1
        is obsolete|                            |
  Attachment #78082|0                           |1
        is obsolete|                            |

--- Comment #12 from Jonathan Druart <[hidden email]> ---
Created attachment 78153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78153&action=edit
Bug 21206: Replace C4::Items::GetItem

Note: This is here for information purpose, feel free to test it if you
wan to play with it.

TODO: C4::Reserves::_get_itype is not longer in use

No more GetItem must be returned by:
git grep GetItem|grep -v GetItemsAvailableToFillHoldRequestsForBib|grep
-v GetItemsForInventory|grep -v GetItemsInfo|grep -v
GetItemsLocationInfo|grep -v GetItemsInCollection|grep -v
GetItemCourseReservesInfo|grep -v GetItemnumbersFromOrder|grep -v
GetItemSearchField|grep -v GetItemTypesCategorized|grep -v
GetItemNumbersFromImportBatch|cut -d':' -f1|sort|uniq

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

--- Comment #13 from Jonathan Druart <[hidden email]> ---
Created attachment 78154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78154&action=edit
Bug 21206: Remove GetItem

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

--- Comment #14 from Jonathan Druart <[hidden email]> ---
Created attachment 78155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78155&action=edit
Bug 21206: Fix Returns.t

we are calling several times effective_itemtype
Must be fixed later

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206
Bug 21206 depends on bug 21184, which changed state.

Bug 21184 Summary: C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206
Bug 21206 depends on bug 21205, which changed state.

Bug 21205 Summary: C4::Acquisition - Remove GetOrderFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78153|0                           |1
        is obsolete|                            |
  Attachment #78154|0                           |1
        is obsolete|                            |
  Attachment #78155|0                           |1
        is obsolete|                            |

--- Comment #15 from Josef Moravec <[hidden email]> ---
Created attachment 82831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82831&action=edit
Bug 21206: Replace C4::Items::GetItem

Note: This is here for information purpose, feel free to test it if you
wan to play with it.

TODO: C4::Reserves::_get_itype is not longer in use

No more GetItem must be returned by:
git grep GetItem|grep -v GetItemsAvailableToFillHoldRequestsForBib|grep
-v GetItemsForInventory|grep -v GetItemsInfo|grep -v
GetItemsLocationInfo|grep -v GetItemsInCollection|grep -v
GetItemCourseReservesInfo|grep -v GetItemnumbersFromOrder|grep -v
GetItemSearchField|grep -v GetItemTypesCategorized|grep -v
GetItemNumbersFromImportBatch|cut -d':' -f1|sort|uniq

Signed-off-by: Josef Moravec <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

--- Comment #16 from Josef Moravec <[hidden email]> ---
Created attachment 82832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82832&action=edit
Bug 21206: Remove GetItem

Signed-off-by: Josef Moravec <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

--- Comment #17 from Josef Moravec <[hidden email]> ---
Created attachment 82833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82833&action=edit
Bug 21206: Fix Returns.t

we are calling several times effective_itemtype
Must be fixed later

Signed-off-by: Josef Moravec <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21206] C4::Items - Remove GetItem

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

--- Comment #18 from Josef Moravec <[hidden email]> ---
Created attachment 82834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82834&action=edit
Bug 21206: (follow-up) Fix Circulation.t

Test plan:
prove t/db_dependent/Circulation.t

Signed-off-by: Josef Moravec <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12