[Bug 21159] New: Blank item shelving location (952$c) on issue and return based on syspref values

classic Classic list List threaded Threaded
23 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] New: Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

            Bug ID: 21159
           Summary: Blank item shelving location (952$c) on issue and
                    return based on syspref values
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]

Items shelving location (952$c) is blanked when the item is issued (if the new
syspref BlankShelvingLocationOnIssue is enabled) and returned (if the new
syspref BlankShelvingLocationOnReturn is enabled).

i.e. This patch will blank shelving location on circulation actions, it will
utilise two system preferences rather than one so it can work however people
want it to.

The sysprefs will both be off by default.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

--- Comment #1 from Alex Buckley <[hidden email]> ---
Created attachment 77487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77487&action=edit
Bug 21159 - Implementing 2 sysprefs to enable blanking location

This patch introduces two new system preferences:
BlankingShelvingLocationOnIssue and BlankingShelvingLocationOnReturn. By
default both are off.

If BlankingShelvingLocationOnIssue is enabled then when an item is issued it's
shelving location 952$c field will be set to '' in
C4::Items->BlankShelvingLocation()

If BlankingShelvingLocationOnReturn is enabled then when an item is returned
it's shelving location field will be set to '' in
C4::Items->BlankShelvingLocation().

t/db_dependent/Circulation/issue.t contains tests for
BlankShelvingLocationOnIssue

t/db_dependen/Circulation/Returns.t contains tests for
BlankShelvingLocationOnReturn

Test plan:
1. Create a new biblio and associated item and set the value of the shelving
location for the item to 'CART'
2. Checkout the item to a user and notice that the status does not change
3. Apply patch, and run ./updatedatabase.pl inside the koha shell
4. Now return the checked out item (when you updated the database you added two
new sysprefs: BlankShelvingLocationOnIssue and BlankShelvingLocationOnReturn
both of which are off by default)
5. Notice the shelving location has not changed, showing with the
BlankShelvingLocationOnReturn syspref not enabled the shelving location is not
changed upon return
6. Check the item out again and notice the shelving location is not changed,
showing that when the BlankShelvingLocationOnIssue is not enabled the shelving
location is not changed upon issue.
7. Enable both aforementioned sysprefs in the Administration->Global system
preferences->Circulation interface
8. Return the item and notice the Shelving location has changed from 'Cart' to
no value, showing when the BlankShelvingLocationOnReturn syspref is enabled it
blanks the shelving location value on the return of the item
9. Edit the item changing the shelving location back to 'Shelving
Trolley'(CART)
10. Check out the item and notice the shelving location is changed to no value,
showing when the BlankShelvingLocationOnIssue syspref is enabled it blanks the
shelving location on the issue of an item.
11. Run t/db_dependent/Circulation/Returns.t
12. Run t/db_dependent/Circulation/issue.t

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77487|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

--- Comment #2 from Alex Buckley <[hidden email]> ---
Created attachment 77549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77549&action=edit
Bug 21159 - Implementing 2 sysprefs to enable blanking location

This patch introduces two new system preferences:
BlankingShelvingLocationOnIssue and BlankingShelvingLocationOnReturn. By
default both are off.

If BlankingShelvingLocationOnIssue is enabled then when an item is issued it's
shelving location 952$c field will be set to '' in
C4::Items->BlankShelvingLocation()

If BlankingShelvingLocationOnReturn is enabled then when an item is returned
it's shelving location field will be set to '' in
C4::Items->BlankShelvingLocation().

t/db_dependent/Circulation/issue.t contains tests for
BlankShelvingLocationOnIssue

t/db_dependen/Circulation/Returns.t contains tests for
BlankShelvingLocationOnReturn

Test plan:
1. Create a new biblio and associated item and set the value of the shelving
location for the item to 'CART'
2. Checkout the item to a user and notice that the status does not change
3. Apply patch, and run ./updatedatabase.pl inside the koha shell
4. Now return the checked out item (when you updated the database you added two
new sysprefs: BlankShelvingLocationOnIssue and BlankShelvingLocationOnReturn
both of which are off by default)
5. Notice the shelving location has not changed, showing with the
BlankShelvingLocationOnReturn syspref not enabled the shelving location is not
changed upon return
6. Check the item out again and notice the shelving location is not changed,
showing that when the BlankShelvingLocationOnIssue is not enabled the shelving
location is not changed upon issue.
7. Enable both aforementioned sysprefs in the Administration->Global system
preferences->Circulation interface
8. Return the item and notice the Shelving location has changed from 'Cart' to
no value, showing when the BlankShelvingLocationOnReturn syspref is enabled it
blanks the shelving location value on the return of the item
9. Edit the item changing the shelving location back to 'Shelving
Trolley'(CART)
10. Check out the item and notice the shelving location is changed to no value,
showing when the BlankShelvingLocationOnIssue syspref is enabled it blanks the
shelving location on the issue of an item.
11. Run t/db_dependent/Circulation/Returns.t
12. Run t/db_dependent/Circulation/issue.t

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Katrin Fischer <[hidden email]> ---
Hi Alex,

I think this might be kind of a partial duplicate to bug 14576 that allows
arbitrary updates on the location field on checkin. I think if that makes it
in, it would make BlankingShelvingLocationOnReturn obsolete.

Maybe you could take a look and see if it fits your use case? The code might be
reusable for checkout too.

I'd also be interesting if the use case is CART on how this works different to
the existing features: NewItemsDefaultLocation, ReturnToShelvingCart,
InProcessingToShelvingCart

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14576

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77549|0                           |1
        is obsolete|                            |

--- Comment #4 from Alex Buckley <[hidden email]> ---
Created attachment 77594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77594&action=edit
Bug 21159 - Implementing 2 sysprefs to enable blanking location

This patch introduces two new system preferences:
BlankingShelvingLocationOnIssue and BlankingShelvingLocationOnReturn. By
default both are off.

If BlankingShelvingLocationOnIssue is enabled then when an item is issued it's
shelving location 952$c field will be set to '' in
C4::Items->BlankShelvingLocation()

If BlankingShelvingLocationOnReturn is enabled then when an item is returned
it's shelving location field will be set to '' in
C4::Items->BlankShelvingLocation().

t/db_dependent/Circulation/issue.t contains tests for
BlankShelvingLocationOnIssue

t/db_dependen/Circulation/Returns.t contains tests for
BlankShelvingLocationOnReturn

Test plan:
1. Create a new biblio and associated item and set the value of the shelving
location for the item to 'CART'
2. Checkout the item to a user and notice that the status does not change
3. Apply patch, and run ./updatedatabase.pl inside the koha shell
4. Now return the checked out item (when you updated the database you added two
new sysprefs: BlankShelvingLocationOnIssue and BlankShelvingLocationOnReturn
both of which are off by default)
5. Notice the shelving location has not changed, showing with the
BlankShelvingLocationOnReturn syspref not enabled the shelving location is not
changed upon return
6. Check the item out again and notice the shelving location is not changed,
showing that when the BlankShelvingLocationOnIssue is not enabled the shelving
location is not changed upon issue.
7. Enable both aforementioned sysprefs in the Administration->Global system
preferences->Circulation interface
8. Return the item and notice the Shelving location has changed from 'Cart' to
no value, showing when the BlankShelvingLocationOnReturn syspref is enabled it
blanks the shelving location value on the return of the item
9. Edit the item changing the shelving location back to 'Shelving
Trolley'(CART)
10. Check out the item and notice the shelving location is changed to no value,
showing when the BlankShelvingLocationOnIssue syspref is enabled it blanks the
shelving location on the issue of an item.
11. Run t/db_dependent/Circulation/Returns.t
12. Run t/db_dependent/Circulation/issue.t

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

--- Comment #5 from Katrin Fischer <[hidden email]> ---
Hi Alex, did you see my comment#3 here? Also, please don't forget to assign
yourself to the bug :)

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--- Comment #6 from Alex Buckley <[hidden email]> ---
Yup thanks Katrin looking now.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #7 from Alex Buckley <[hidden email]> ---
Hi Katrin

Sorry for the delay I think I should be able to modify this commit so it
depends on (builds on) whats in 14576.

In other words instead of implementing the BlankShelvingLocationOnReturn
syspref which I have in this commit I can leave that out as it is being covered
by 14576.

However, 14576 does not set/blank the items.locations field when an item is
issued as the BlankShelvingLocationOnIssue syspref in this commit does so I can
leverage some of the code of 14576 to implement this functionality. Being able
to blank the shelving location of an item when it is issued was the main thing
our client wanted to be able to do.

Thanks for bringing 14576 to my attention I will make changes to my commits so
it builds on 14576.

Cheers,
Alex

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77594|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

--- Comment #8 from Alex Buckley <[hidden email]> ---
Created attachment 77775
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77775&action=edit
Bug 21159 - Implementing syspref to enable blanking of item shelving location
on issue.

This patch builds upon the functionality implemented in bug 14576,
by allowing library staff to automatically change the item shelving
location of items which are circulated.

In the case of this patch it automatically blanks the item shelving locations
of items
when they are issued if the
BlankItemLocationOnCheckout syspref is enabled.

t/db_dependent/Circulation/issue.t contains tests for
BlankItemLocationOnCheckout.

Test plan:
1. Create a new biblio and associated item and set the value of the
shelving location for the item to 'CART'
2. Checkout the item to a user and notice that the status does not
change
3. Apply patches on bug report 14576, and this patch, and run
./updatedatabase.pl inside the koha shell
4. Now return the checked out item (when you updated the database you
added one new syspref: UpdateItemLocationOnCheckout which is off by default)
5. Check the item out again and notice the shelving location is not
changed, showing that when the UpdateItemLocationOnCheckout is not
enabled and the shelving location is not changed upon issue.
6. Enable the aforementioned syspref in the Administration->Global
system preferences->Circulation interface
7. Check out the item and notice the shelving location is changed to no
value, showing when the UpdateItemLocationOnCheckout syspref is enabled
it blanks the shelving location on the issue of an item.
8. Run t/db_dependent/Circulation/issue.t

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
         Depends on|                            |14576


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
[Bug 14576] Allow arbitrary automatic update of location on checkin
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77775|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

--- Comment #9 from Alex Buckley <[hidden email]> ---
Created attachment 77859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77859&action=edit
Bug 21159 - Implementing syspref to enable blanking of item shelving location
on issue.

This patch builds upon the functionality implemented in bug 14576,
by allowing library staff to automatically change the item shelving
location of items which are circulated.

In the case of this patch it automatically blanks the item shelving locations
of items
when they are issued if the
BlankItemLocationOnCheckout syspref is enabled.

t/db_dependent/Circulation/issue.t contains tests for
BlankItemLocationOnCheckout.

Test plan:
1. Create a new biblio and associated item and set the value of the
shelving location for the item to 'CART'
2. Checkout the item to a user and notice that the status does not
change
3. Apply patches on bug report 14576, and this patch, and run
./updatedatabase.pl inside the koha shell
4. Now return the checked out item (when you updated the database you
added one new syspref: UpdateItemLocationOnCheckout which is off by default)
5. Check the item out again and notice the shelving location is not
changed, showing that when the UpdateItemLocationOnCheckout is not
enabled and the shelving location is not changed upon issue.
6. Enable the aforementioned syspref in the Administration->Global
system preferences->Circulation interface
7. Check out the item and notice the shelving location is changed to no
value, showing when the UpdateItemLocationOnCheckout syspref is enabled
it blanks the shelving location on the issue of an item.
8. Run t/db_dependent/Circulation/issue.t

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77859|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

--- Comment #10 from Alex Buckley <[hidden email]> ---
Created attachment 77869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77869&action=edit
Bug 21159 - Implementing syspref to enable blanking of item shelving location
on issue.

This patch builds upon the functionality implemented in bug 14576,
by allowing library staff to automatically change the item shelving
location of items which are circulated.

In the case of this patch it automatically blanks the item shelving locations
of items
when they are issued if the
BlankItemLocationOnCheckout syspref is enabled.

t/db_dependent/Circulation/issue.t contains tests for
BlankItemLocationOnCheckout.

Test plan:
1. Create a new biblio and associated item and set the value of the
shelving location for the item to 'CART'
2. Checkout the item to a user and notice that the status does not
change
3. Apply patches on bug report 14576, and this patch, and run
./updatedatabase.pl inside the koha shell
4. Now return the checked out item (when you updated the database you
added one new syspref: UpdateItemLocationOnCheckout which is off by default)
5. Check the item out again and notice the shelving location is not
changed, showing that when the UpdateItemLocationOnCheckout is not
enabled and the shelving location is not changed upon issue.
6. Enable the aforementioned syspref in the Administration->Global
system preferences->Circulation interface
7. Check out the item and notice the shelving location is changed to no
value, showing when the UpdateItemLocationOnCheckout syspref is enabled
it blanks the shelving location on the issue of an item.
8. Run t/db_dependent/Circulation/issue.t

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77869|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

--- Comment #11 from Alex Buckley <[hidden email]> ---
Created attachment 77870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77870&action=edit
Bug 21159 - Implementing syspref to enable blanking of item shelving location
on issue.

This patch builds upon the functionality implemented in bug 14576,
by allowing library staff to automatically change the item shelving
location of items which are circulated.

In the case of this patch it automatically blanks the item shelving locations
of items
when they are issued if the
BlankItemLocationOnCheckout syspref is enabled.

t/db_dependent/Circulation/issue.t contains tests for
BlankItemLocationOnCheckout.

Test plan:
1. Create a new biblio and associated item and set the value of the
shelving location for the item to 'CART'
2. Checkout the item to a user and notice that the status does not
change
3. Apply patches on bug report 14576, and this patch, and run
./updatedatabase.pl inside the koha shell
4. Now return the checked out item (when you updated the database you
added one new syspref: UpdateItemLocationOnCheckout which is off by default)
5. Check the item out again and notice the shelving location is not
changed, showing that when the UpdateItemLocationOnCheckout is not
enabled and the shelving location is not changed upon issue.
6. Enable the aforementioned syspref in the Administration->Global
system preferences->Circulation interface
7. Check out the item and notice the shelving location is changed to no
value, showing when the UpdateItemLocationOnCheckout syspref is enabled
it blanks the shelving location on the issue of an item.
8. Run t/db_dependent/Circulation/issue.t

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

--- Comment #12 from Alex Buckley <[hidden email]> ---
I think this one is ready to test.

It is building on (depends on) the functionality provided by 14576. Many thanks
to Katrin for informing me about 14576 so I was able to remove the duplicated
functionality that my original patch had.

This new patch does not deal with automatically updating the item location when
the item is returned as this is covered by 14576.

Instead, this new commit blanks out the items.location field when the item is
checked out if the UpdateItemLocationOnCheckout syspref is enabled. This makes
an easier workflow for automatically removing the items.location value if the
item is issued.

Please let me know if further changes are required :)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

--- Comment #13 from Alex Buckley <[hidden email]> ---
Created attachment 77871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77871&action=edit
Bug 21159 - Corrected typo

Same test plan as first patch.

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=21173

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/