[Bug 21073] New: Improve plugin performance

classic Classic list List threaded Threaded
159 messages Options
1234 ... 6
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] New: Improve plugin performance

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

            Bug ID: 21073
           Summary: Improve plugin performance
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

Right now, to check if a plugin is functional and what methods it exposes we
load the module and test for a given method at run time. This is highly
inefficient. It makes far more sense to do this at install time and store the
data in the db. I believe we should store a table of methods that each plugin
exposes and check that instead. Then, at install time we can test that a) the
plugin can be loaded and b) add the available methods to the plugin_methods
table.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #1 from Kyle M Hall <[hidden email]> ---
Created attachment 76955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76955&action=edit
Bug 21073: Add new table, schema and classes

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #2 from Kyle M Hall <[hidden email]> ---
Created attachment 76956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76956&action=edit
Bug 21073: Improve plugin performance

Right now, to check if a plugin is functional and what methods it exposes we
load the module and test for a given method at run time. This is highly
inefficient. It makes far more sense to do this at install time and store the
data in the db. I believe we should store a table of methods that each plugin
exposes and check that instead. Then, at install time we can test that a) the
plugin can be loaded and b) add the available methods to the plugin_methods
table.

Test Plan:
1) Apply this patch
2) Restart all the things
3) Run updatedatabase.pl
4) Verify you can use existing plugins
5) Verify you can install new plugins

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76955|0                           |1
        is obsolete|                            |
  Attachment #76956|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <[hidden email]> ---
Created attachment 76957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76957&action=edit
Bug 21073: Add new table, schema and classes

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #4 from Kyle M Hall <[hidden email]> ---
Created attachment 76958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76958&action=edit
Bug 21073: Improve plugin performance

Right now, to check if a plugin is functional and what methods it exposes we
load the module and test for a given method at run time. This is highly
inefficient. It makes far more sense to do this at install time and store the
data in the db. I believe we should store a table of methods that each plugin
exposes and check that instead. Then, at install time we can test that a) the
plugin can be loaded and b) add the available methods to the plugin_methods
table.

Test Plan:
1) Apply this patch
2) Restart all the things
3) Run updatedatabase.pl
4) Verify you can use existing plugins
5) Verify you can install new plugins

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76958|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <[hidden email]> ---
Created attachment 76973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76973&action=edit
Bug 21073: Improve plugin performance

Right now, to check if a plugin is functional and what methods it exposes we
load the module and test for a given method at run time. This is highly
inefficient. It makes far more sense to do this at install time and store the
data in the db. I believe we should store a table of methods that each plugin
exposes and check that instead. Then, at install time we can test that a) the
plugin can be loaded and b) add the available methods to the plugin_methods
table.

Test Plan:
1) Apply this patch
2) Restart all the things
3) Run updatedatabase.pl
4) Verify you can use existing plugins
5) Verify you can install new plugins

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

David Cook <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #6 from David Cook <[hidden email]> ---
Do you have some examples of plugins we can use before and after this patch?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Michal Denar <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #7 from Kyle M Hall <[hidden email]> ---
(In reply to David Cook from comment #6)
> Do you have some examples of plugins we can use before and after this patch?

Any and all plugins should be valid. The Kitchen Sink would be a good test.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #8 from David Cook <[hidden email]> ---
(In reply to Kyle M Hall from comment #7)
> (In reply to David Cook from comment #6)
> > Do you have some examples of plugins we can use before and after this patch?
>
> Any and all plugins should be valid. The Kitchen Sink would be a good test.

Cool, so something like the following?

0) Install Kitchen Sink plugin
1) Apply this patch
2) Restart all the things
3) Run updatedatabase.pl
4) Verify you can use existing Kitchen Sink plugin
5) Remove Kitchen Sink plugin
6) Verify you can install new Kitchen Sink plugin

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #9 from Kyle M Hall <[hidden email]> ---
(In reply to David Cook from comment #8)

> (In reply to Kyle M Hall from comment #7)
> > (In reply to David Cook from comment #6)
> > > Do you have some examples of plugins we can use before and after this patch?
> >
> > Any and all plugins should be valid. The Kitchen Sink would be a good test.
>
> Cool, so something like the following?
>
> 0) Install Kitchen Sink plugin
> 1) Apply this patch
> 2) Restart all the things
> 3) Run updatedatabase.pl
> 4) Verify you can use existing Kitchen Sink plugin
> 5) Remove Kitchen Sink plugin
> 6) Verify you can install new Kitchen Sink plugin

Yes, that plan looks great!

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #10 from M. Tompsett <[hidden email]> ---
Revised Test Plan.

0) Backup DB as desired && Install Kitchen Sink plugin
1) Apply this patch
2) Restart all the things
3) Run updatedatabase.pl (testing upgrade)
4) Verify you can use existing Kitchen Sink plugin
5) Remove Kitchen Sink plugin
6) Reset all the things (testing fresh install)
7) Verify you can install new Kitchen Sink plugin
8) Remove Kitchen Sink plugin && Restore DB if backed up.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Liz Rea <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |[hidden email]

--- Comment #11 from Liz Rea <[hidden email]> ---
Terribly sorry to report that this no longer applies:

Auto-merging t/db_dependent/Plugins.t
CONFLICT (content): Merge conflict in t/db_dependent/Plugins.t
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
error: Failed to merge in the changes.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76957|0                           |1
        is obsolete|                            |
  Attachment #76973|0                           |1
        is obsolete|                            |

--- Comment #12 from Kyle M Hall <[hidden email]> ---
Created attachment 88379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88379&action=edit
Bug 21073: Add new table, schema and classes

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #13 from Kyle M Hall <[hidden email]> ---
Created attachment 88380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88380&action=edit
Bug 21073: Improve plugin performance

Right now, to check if a plugin is functional and what methods it exposes we
load the module and test for a given method at run time. This is highly
inefficient. It makes far more sense to do this at install time and store the
data in the db. I believe we should store a table of methods that each plugin
exposes and check that instead. Then, at install time we can test that a) the
plugin can be loaded and b) add the available methods to the plugin_methods
table.

Test Plan:
1) Apply this patch
2) Restart all the things
3) Run updatedatabase.pl
4) Verify you can use existing plugins
5) Verify you can install new plugins

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #14 from Kyle M Hall <[hidden email]> ---
Created attachment 88381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88381&action=edit
Bug 21073: Upgrade the kitchen sink plugin to get rid of warnings

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #15 from Tomás Cohen Arazi <[hidden email]> ---
Proposal for discussion:
- Make it explicit by declaring what 'capabilities' the plugin has, like
our $capabilities = { tools => 1, ... };
- Rename methods => capabilities:
    CREATE TABLE IF NOT EXISTS plugin_capabilities (
      class varchar(255) NOT NULL,
      capability varchar(255) NOT NULL,
      PRIMARY KEY ( `class` (191), `capability` (191) )
    ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #16 from David Cook <[hidden email]> ---
(In reply to Tomás Cohen Arazi from comment #15)
> Proposal for discussion:
> - Make it explicit by declaring what 'capabilities' the plugin has, like
> our $capabilities = { tools => 1, ... };
> - Rename methods => capabilities:

Just for the sake of discussion, is there a different word that could be used
instead of capabilities? It seems to me like a word where typos might be easily
introduced?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Liz Rea <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #17 from Liz Rea <[hidden email]> ---
Hi,

Sorry to report that the updatadatabase failed with

DEV atomic update: plugin_methods.perl
Atomic update generated errors: Can't call method "InstallPlugins" on an
undefined value at (eval 1398) line 13.

Have a look?

Cheers,
Liz

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #18 from Tomás Cohen Arazi <[hidden email]> ---
(In reply to David Cook from comment #16)
> (In reply to Tomás Cohen Arazi from comment #15)
> > Proposal for discussion:
> > - Make it explicit by declaring what 'capabilities' the plugin has, like
> > our $capabilities = { tools => 1, ... };
> > - Rename methods => capabilities:
>
> Just for the sake of discussion, is there a different word that could be
> used instead of capabilities? It seems to me like a word where typos might
> be easily introduced?

As THE native speaker, it is your responsbility to propose another word :-D

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #19 from David Cook <[hidden email]> ---
(In reply to Tomás Cohen Arazi from comment #18)
> As THE native speaker, it is your responsbility to propose another word :-D

Hehe fair enough, although I'm not sure of the exact context. Why do you want
to rename it from "methods" to something else? Is methods too low-level or
overloaded in terms of meaning?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|[hidden email]-communit |[hidden email]
                   |y.org                       |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #20 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 89247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89247&action=edit
Bug 21073: (QA follow-up) Atomic update shouldn't fail if plugins are disabled

Signed-off-by: Tomas Cohen Arazi <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |19.05
            Version|unspecified                 |master
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 21073] Improve plugin performance

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #21 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 89251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89251&action=edit
Bug 21073: (QA follow-up) Restore check on template

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
1234 ... 6