[Bug 20968] New: Plugins: Add hooks to enable plugin integration into catalogue

classic Classic list List threaded Threaded
76 messages Options
123
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] New: Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

            Bug ID: 20968
           Summary: Plugins: Add hooks to enable plugin integration into
                    catalogue
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

This bug will add Koha Plugin hooks into catalogue related code allowing
integration into areas such as
koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[hidden email]-commun |andrew.isherwood@ptfs-europ
                   |ity.org                     |e.com

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #1 from Andrew Isherwood <[hidden email]> ---
Created attachment 76374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76374&action=edit
Add hooks into cat-toolbar.inc to display buttons

This commit adds hooks into cat-toolbar.inc to allow the display of
arbitrary buttons as supplied by plugins within the
intranet_catalog_biblio_enhancements class that provide the method
get_toolbar_button

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #2 from Andrew Isherwood <[hidden email]> ---
Created attachment 76375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76375&action=edit
Bug 20968: Add hooks into cat-toolbar.inc to display buttons

This commit adds hooks into cat-toolbar.inc to allow the display of
arbitrary buttons as supplied by plugins within the
intranet_catalog_biblio_enhancements class that provide the method
get_toolbar_button

To test:

1) Download the plugin from
https://github.com/PTFS-Europe/cla-permissions-check-plugin
2) Follow the installation instructions from:
https://github.com/PTFS-Europe/cla-permissions-check-plugin
3) TEST: Observe that the "CLA Check Permissions" button takes the user
to the Check Permissions page and a modal displays containing the
results of the query
4) Remove the API key from the plugin "Configuration" page
5) TEST: Ensure that the "CLA Check Permissions" button takes the user
to the Check Permissions page and message displays informing the user
that "Did not receive required request parameters"

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76374|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|[hidden email]-communit |[hidden email]
                   |y.org                       |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Kyle M Hall <[hidden email]> ---
I see a few issues the shouldn't be hard to resolve:
1) Unit tests ( they are super simple, but should be there anyway )
2) Why test for the method intranet_catalog_biblio_enhancements, but then call
the method get_toolbar_button? A) You can check for the method
get_toolbar_button directly, and B) You are calling get_toolbar_button twice
per plugin, which seems like waste of cycles.
3) After resolving 1 and 2, could you also make pull request to the kitchen
sink plugin (https://github.com/bywatersolutions/koha-plugin-kitchen-sink) to
add an example to it? That plugin is basically out documentation for the plugin
system's functionality at this time.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #4 from Kyle M Hall <[hidden email]> ---
4) I forgot to make explicit that it seems like the method
intranet_catalog_biblio_enhancements is not really necessary and should be
removed and replaced with a GetPlugins call for get_toolbar_button instead.

5) Can you make the method names a bit more explicit? I think
get_opac_toolbar_button would be better than get_toolbar_button so future
developers have a bit better an idea what it does without further research.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #5 from Kyle M Hall <[hidden email]> ---
On further inspection, I go with something even more specific,
get_opac_catalog_toolbar_button, which completely disambiguates where this
button will appear.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #6 from Andrew Isherwood <[hidden email]> ---
Hi Kyle

Many thanks for this feedback, very helpful indeed.

1) Yes indeed, I completely overlooked tests, I'll address this.
2) Good point, well spotted. I'll fix this.
3) Yes, will do
4) I'm not clear whether you're suggesting we should ditch the
intranet_catalog_biblio_enhancements method entirely. I don't think we can do
this as we need to be able to test in plugins-home.pl/.tt for plugins that are
within this class. If you just meant I should drop it from detail.pm as
mentioned in 2), yes, I will do this.
5) Yes, good idea, will do

Thanks again. I'll update here once this is all done.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #7 from Andrew Isherwood <[hidden email]> ---
Hi Kyle

Looking at 1), I'm not sure writing tests for this tiny amount of core
integration is even possible. All we're doing is populating a template
parameter under a certain condition, I don't think we can meaningfully test
that.

Any thoughts?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #8 from Andrew Isherwood <[hidden email]> ---
Created attachment 76530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76530&action=edit
Bug 20968: (follow-up) Respond to feedback

This patch:

- Removes the unecessary testing for
intranet_catalog_biblio_enhancements method in detail.pl
- Renames get_toolbar_button to get_intranet_catalog_toolbar_button

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #9 from Kyle M Hall <[hidden email]> ---
Created attachment 76531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76531&action=edit
Bug 20968: Add unit tests

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #10 from Kyle M Hall <[hidden email]> ---
Created attachment 76532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76532&action=edit
Bug 20968: Rename method get_intranet_catalog_toolbar_button to
intranet_catalog_biblio_enhancements_toolbar_button

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #11 from Kyle M Hall <[hidden email]> ---
> 4) I'm not clear whether you're suggesting we should ditch the
> intranet_catalog_biblio_enhancements method entirely. I don't think we can
> do this as we need to be able to test in plugins-home.pl/.tt for plugins
> that are within this class. If you just meant I should drop it from
> detail.pm as mentioned in 2), yes, I will do this.

I didn't fully understand it's purpose at first. What you've done in the
followup is excellent.

I've added to more patches for you, one that add's those unit tests, and
another that renames get_intranet_catalog_toolbar_button to
intranet_catalog_biblio_enhancements_toolbar_button

I know that's quite wordy, but it keeps the naming convention to be in line
with the naming convention for the opac payment methods.

If you these followups work for you, I think we'll be good to go! Just sign off
on my patches, I'll sign off on yours and we can let someone else QA. Once it's
passed qa, I'll add those methods to the Kitchen Sink plugin as well!

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #12 from Kyle M Hall <[hidden email]> ---
Apologies for all the typos in my last reply. It's just one of those days I
guess ;)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76532|0                           |1
        is obsolete|                            |

--- Comment #13 from Andrew Isherwood <[hidden email]> ---
Created attachment 76540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76540&action=edit
Bug 20968: Rename method get_intranet_catalog_toolbar_button to
intranet_catalog_biblio_enhancements_toolbar_button

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76531|0                           |1
        is obsolete|                            |

--- Comment #14 from Andrew Isherwood <[hidden email]> ---
Created attachment 76541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76541&action=edit
Bug 20968: Add unit tests

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #15 from Andrew Isherwood <[hidden email]> ---
Hi Kyle

Perfect, thanks very much for that.

I've tested and signed off (I think) your patches.

Cheers

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #16 from Andrew Isherwood <[hidden email]> ---
Created attachment 76555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76555&action=edit
Bug 20968: (follow-up) Replace tabs with spaces

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76375|0                           |1
        is obsolete|                            |
  Attachment #76530|0                           |1
        is obsolete|                            |
  Attachment #76540|0                           |1
        is obsolete|                            |
  Attachment #76541|0                           |1
        is obsolete|                            |
  Attachment #76555|0                           |1
        is obsolete|                            |

--- Comment #17 from Kyle M Hall <[hidden email]> ---
Created attachment 76564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76564&action=edit
Bug 20968: Add hooks into cat-toolbar.inc to display buttons

This commit adds hooks into cat-toolbar.inc to allow the display of
arbitrary buttons as supplied by plugins within the
intranet_catalog_biblio_enhancements class that provide the method
get_toolbar_button

To test:

1) Download the plugin from
https://github.com/PTFS-Europe/cla-permissions-check-plugin
2) Follow the installation instructions from:
https://github.com/PTFS-Europe/cla-permissions-check-plugin
3) TEST: Observe that the "CLA Check Permissions" button takes the user
to the Check Permissions page and a modal displays containing the
results of the query
4) Remove the API key from the plugin "Configuration" page
5) TEST: Ensure that the "CLA Check Permissions" button takes the user
to the Check Permissions page and message displays informing the user
that "Did not receive required request parameters"

https://bugs.koha-community.org/show_bug.cgi?id=20968

Signed-off-by: Kyle M Hall <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #18 from Kyle M Hall <[hidden email]> ---
Created attachment 76565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76565&action=edit
Bug 20968: (follow-up) Respond to feedback

This patch:

- Removes the unecessary testing for
intranet_catalog_biblio_enhancements method in detail.pl
- Renames get_toolbar_button to get_intranet_catalog_toolbar_button

Signed-off-by: Kyle M Hall <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #19 from Kyle M Hall <[hidden email]> ---
Created attachment 76566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76566&action=edit
Bug 20968: Add unit tests

Signed-off-by: Kyle M Hall <[hidden email]>

Signed-off-by: Andrew Isherwood <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #20 from Kyle M Hall <[hidden email]> ---
Created attachment 76567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76567&action=edit
Bug 20968: Rename method get_intranet_catalog_toolbar_button to
intranet_catalog_biblio_enhancements_toolbar_button

Signed-off-by: Kyle M Hall <[hidden email]>

Signed-off-by: Andrew Isherwood <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #21 from Kyle M Hall <[hidden email]> ---
Created attachment 76568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76568&action=edit
Bug 20968: (follow-up) Replace tabs with spaces

Signed-off-by: Kyle M Hall <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
123