[Bug 20658] New: Move template JavaScript to the footer: Installer and onboarding

classic Classic list List threaded Threaded
16 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 20658] New: Move template JavaScript to the footer: Installer and onboarding

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658

            Bug ID: 20658
           Summary: Move template JavaScript to the footer: Installer and
                    onboarding
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for the installer and onboarding templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20658] Move template JavaScript to the footer: Installer and onboarding

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20658] Move template JavaScript to the footer: Installer and onboarding

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658

--- Comment #1 from Owen Leonard <[hidden email]> ---
Created attachment 74851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74851&action=edit
Bug 20658: Move template JavaScript to the footer: Installer and onboarding

This patch updates the installer and onboarding templates so that
JavaScript is included in the footer instead of the header. A new
include file is added, installer-intranet-bottom.inc, so that only
required JS is being loaded.

Some markup changes are included to improve validity.

To test, apply the patch and start with a blank Koha database. Run
through the installer and onboarding processes and confirm that there
are no problems. Check especially JS-related interactions like
datepickers and fields which are validated via JS, like the password
inputs.

NOTE: The qa tool will flag this patch for not using the Asset plugin,
but it doesn't work correctly for installer files.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20658] Move template JavaScript to the footer: Installer and onboarding

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20658] Move template JavaScript to the footer: Installer and onboarding

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Patch doesn't apply

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20658] Move template JavaScript to the footer: Installer and onboarding

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20658] Move template JavaScript to the footer: Installer and onboarding

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74851|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <[hidden email]> ---
Created attachment 78910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78910&action=edit
Bug 20658: Move template JavaScript to the footer: Installer and onboarding

This patch updates the installer and onboarding templates so that
JavaScript is included in the footer instead of the header. A new
include file is added, installer-intranet-bottom.inc, so that only
required JS is being loaded.

Some markup changes are included to improve validity.

To test, apply the patch and start with a blank Koha database. Run
through the installer and onboarding processes and confirm that there
are no problems. Check especially JS-related interactions like
datepickers and fields which are validated via JS, like the password
inputs.

NOTE: The qa tool will flag this patch for not using the Asset plugin,
but it doesn't work correctly for installer files.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20658] Move template JavaScript to the footer: Installer and onboarding

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658

Claire Gravely <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20658] Move template JavaScript to the footer: Installer and onboarding

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658

Claire Gravely <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78910|0                           |1
        is obsolete|                            |

--- Comment #3 from Claire Gravely <[hidden email]> ---
Created attachment 78912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78912&action=edit
Bug 20658: Move template JavaScript to the footer: Installer and onboarding

This patch updates the installer and onboarding templates so that
JavaScript is included in the footer instead of the header. A new
include file is added, installer-intranet-bottom.inc, so that only
required JS is being loaded.

Some markup changes are included to improve validity.

To test, apply the patch and start with a blank Koha database. Run
through the installer and onboarding processes and confirm that there
are no problems. Check especially JS-related interactions like
datepickers and fields which are validated via JS, like the password
inputs.

NOTE: The qa tool will flag this patch for not using the Asset plugin,
but it doesn't work correctly for installer files.

Signed-off-by: Claire Gravely <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20658] Move template JavaScript to the footer: Installer and onboarding

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #4 from Jonathan Druart <[hidden email]> ---
html filters have been removed in the include file.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20658] Move template JavaScript to the footer: Installer and onboarding

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20658] Move template JavaScript to the footer: Installer and onboarding

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658

--- Comment #5 from Owen Leonard <[hidden email]> ---
Created attachment 79300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79300&action=edit
Bug 20658: (follow-up) Fix for QA: Add missing html filters

This patch adds missing filters to the installer header and footer
include files.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20658] Move template JavaScript to the footer: Installer and onboarding

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Signed Off                  |Failed QA

--- Comment #6 from Katrin Fischer <[hidden email]> ---
QA script is quite unhappy, can you please check?

OK      koha-tmpl/intranet-tmpl/prog/en/includes/installer-doc-head-close.inc
   OK     filters
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   koha-tmpl/intranet-tmpl/prog/en/includes/installer-intranet-bottom.inc
   OK     filters
   FAIL   forbidden patterns
                forbidden pattern: Do *not* include full path to js files, use
the Asset TT plugin (bug 20538) (line 4)
                forbidden pattern: Do *not* include full path to js files, use
the Asset TT plugin (bug 20538) (line 1)
                forbidden pattern: Do *not* include full path to js files, use
the Asset TT plugin (bug 20538) (line 2)
                forbidden pattern: Do *not* include full path to js files, use
the Asset TT plugin (bug 20538) (line 3)
                forbidden pattern: Do *not* include full path to js files, use
the Asset TT plugin (bug 20538) (line 5)
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   FAIL   valid_template
                : filter not found

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/installer/auth.tt
   OK     filters
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   FAIL   valid_template
                : filter not found

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt
   OK     filters
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   FAIL   valid_template
                : filter not found

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/installer/step2.tt
   OK     filters
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   FAIL   valid_template
                : filter not found

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt
   OK     filters
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   FAIL   valid_template
                : filter not found

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep1.tt
   OK     filters
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   FAIL   valid_template
                : filter not found

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt
   OK     filters
   FAIL   forbidden patterns
                forbidden pattern: Do *not* include full path to js files, use
the Asset TT plugin (bug 20538) (line 132)
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   FAIL   valid_template
                : filter not found

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt
   OK     filters
   FAIL   forbidden patterns
                forbidden pattern: Do *not* include full path to js files, use
the Asset TT plugin (bug 20538) (line 116)
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   FAIL   valid_template
                : filter not found

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep4.tt
   OK     filters
   FAIL   forbidden patterns
                forbidden pattern: Do *not* include full path to js files, use
the Asset TT plugin (bug 20538) (line 52)
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   FAIL   valid_template
                : filter not found

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt
   OK     filters
   FAIL   forbidden patterns
                forbidden pattern: Do *not* include full path to js files, use
the Asset TT plugin (bug 20538) (line 139)
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   FAIL   valid_template
                : filter not found

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20658] Move template JavaScript to the footer: Installer and onboarding

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20658] Move template JavaScript to the footer: Installer and onboarding

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79300|0                           |1
        is obsolete|                            |

--- Comment #7 from Owen Leonard <[hidden email]> ---
Created attachment 81504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81504&action=edit
Bug 20658: (follow-up) Fix for QA: Add missing html filters

This patch adds missing filters to the installer header and footer
include files.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20658] Move template JavaScript to the footer: Installer and onboarding

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |m

--- Comment #8 from Owen Leonard <[hidden email]> ---
*** Bug 22309 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/