[Bug 20639] New: Allow setting a default/single backend for OPAC driven requests

classic Classic list List threaded Threaded
33 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] New: Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

            Bug ID: 20639
           Summary: Allow setting a default/single backend for OPAC driven
                    requests
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: ILL
          Assignee: [hidden email]
          Reporter: [hidden email]

If you have more than one ILL backend installed, and OPAC ILL Requests enabled
the OPAC users are currently faced with a dropdown list of backends to start a
request on. This is often meaningless to the end user and as such a default
should be configurable at the least and preferably the ability to set a fast
path to only allow a prefered backend to be used from the OPAC.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7317


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

--- Comment #1 from Martin Renvoize <[hidden email]> ---
Created attachment 74806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74806&action=edit
Bug 20639: Add ILLOpacbackends syspref

This adds the ILLOpacbackends syspref, allowing users to refine the ill
backends available to opac users for initiating ill requests

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74806|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <[hidden email]> ---
Created attachment 74811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74811&action=edit
Bug 20639: Add ILLOpacbackends syspref

This adds the ILLOpacbackends syspref, allowing users to refine the ill
backends available to opac users for initiating ill requests

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

Joe McGlynn <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew.isherwood@ptfs-europ
                   |                            |e.com
  Attachment #74811|0                           |1
        is obsolete|                            |

--- Comment #3 from Andrew Isherwood <[hidden email]> ---
Comment on attachment 74811
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74811
Bug 20639: Add ILLOpacbackends syspref

Obsoleted due to updated patch

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

--- Comment #4 from Andrew Isherwood <[hidden email]> ---
Created attachment 75165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75165&action=edit
Bug 20639: Add ILLOpacbackends syspref

This adds the ILLOpacbackends syspref, allowing users to refine the ill
backends available to opac users for initiating ill requests

Remove default assignment for backends

We don't need a default assignment for the ILLOpacbackends assignment,
if the pref isn't set, it returns undef anyway. Also, having this
default assignment actually breaks the fetching of the preference

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
           Assignee|[hidden email]-commun |andrew.isherwood@ptfs-europ
                   |ity.org                     |e.com

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639
Bug 20639 depends on bug 7317, which changed state.

Bug 7317 Summary: Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75165|0                           |1
        is obsolete|                            |

--- Comment #5 from Andrew Isherwood <[hidden email]> ---
Created attachment 78119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78119&action=edit
Bug 20639: Add ILLOpacbackends syspref

This adds the ILLOpacbackends syspref, allowing users to refine the ill
backends available to opac users for initiating ill requests

Remove default assignment for backends

We don't need a default assignment for the ILLOpacbackends assignment,
if the pref isn't set, it returns undef anyway. Also, having this
default assignment actually breaks the fetching of the preference

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

--- Comment #6 from Andrew Isherwood <[hidden email]> ---
Created attachment 79033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79033&action=edit
Bug 20639: (follow-up) Fix variable not passed

available_backends expects a variable declaring the contents
of the ILLopacbackends syspref. This wasn't being passed in all calls to
it, so I've removed the requirement for it being passed, we now check
the contents of the syspref in available_backends itselfBug

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

--- Comment #7 from Andrew Isherwood <[hidden email]> ---
To test:

1. Ensure you have at least two ILL backends installed
2. From the OPAC user's home page, choose "your interlibrary loan requests"
3. Click the "Create a new request" button
4. TEST: Observe that all backends are available
5. As a user with sufficient privileges, go to the System Preferences
6. Search the privileges for "interlibrary"
7. TEST: Observe that a "ILLOpacbackends" preference is available
8. Enter the name of *one* of the installed backends in the input box for
"ILLOpacbackends", for example BLDSS
9. From the OPAC user's home page, choose "your interlibrary loan requests"
10. TEST: Observe that the "Create a new request" button is no longer a select
box
11. TEST: Observe that clicking the "Create a new request" button takes you
straight to the form for creating a request with the single available backend
12. As a user with sufficient privileges, go to the System Preferences
13. Search the privileges for "interlibrary"
14. Enter the name of *two* of the installed backends in the input box for
"ILLOpacbackends", separated by a | character for example: BLDSS|Koha
15. From the OPAC user's home page, choose "your interlibrary loan requests"
16. TEST: Observe that the "Create a new request" button is now a select box
17. TEST: Observe that clicking the "Create a new request" button only offers
the backends specified in step 14

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79033|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

--- Comment #8 from Andrew Isherwood <[hidden email]> ---
Created attachment 79474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79474&action=edit
Bug 20639: (follow-up) Fix population of backends

The OPAC view wasn't correctly restricting the display of backends when
the ILLOpacbackends preference was set.

See the test plan on comment 7

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

PTFS Europe Sandboxes <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78119|0                           |1
        is obsolete|                            |

--- Comment #9 from PTFS Europe Sandboxes <[hidden email]> ---
Created attachment 79477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79477&action=edit
Bug 20639: Add ILLOpacbackends syspref

This adds the ILLOpacbackends syspref, allowing users to refine the ill
backends available to opac users for initiating ill requests

Remove default assignment for backends

We don't need a default assignment for the ILLOpacbackends assignment,
if the pref isn't set, it returns undef anyway. Also, having this
default assignment actually breaks the fetching of the preference

Signed-off-by: [hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

PTFS Europe Sandboxes <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

PTFS Europe Sandboxes <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79474|0                           |1
        is obsolete|                            |

--- Comment #10 from PTFS Europe Sandboxes <[hidden email]> ---
Created attachment 79478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79478&action=edit
Bug 20639: (follow-up) Fix population of backends

The OPAC view wasn't correctly restricting the display of backends when
the ILLOpacbackends preference was set.

See the test plan on comment 7

Signed-off-by: [hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20581


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581
[Bug 20581] Allow manual selection of custom ILL request statuses
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

Andrew Isherwood <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20750


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
[Bug 20750] Allow timestamped auditing of ILL request events
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|7317                        |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79477|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <[hidden email]> ---
Created attachment 84932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84932&action=edit
Bug 20639: Add ILLOpacbackends syspref

This adds the ILLOpacbackends syspref, allowing users to refine the ill
backends available to opac users for initiating ill requests

Remove default assignment for backends

We don't need a default assignment for the ILLOpacbackends assignment,
if the pref isn't set, it returns undef anyway. Also, having this
default assignment actually breaks the fetching of the preference

Signed-off-by: [hidden email]

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79478|0                           |1
        is obsolete|                            |

--- Comment #12 from Katrin Fischer <[hidden email]> ---
Created attachment 84933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84933&action=edit
Bug 20639: (follow-up) Fix population of backends

The OPAC view wasn't correctly restricting the display of backends when
the ILLOpacbackends preference was set.

See the test plan on comment 7

Signed-off-by: [hidden email]

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

--- Comment #13 from Katrin Fischer <[hidden email]> ---
Created attachment 84934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84934&action=edit
Bug 20639: (QA follow-up) Rephrase system preference

Rephrases system preference a tiny bit and explaining case
of leaving the pref empty.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

--- Comment #14 from Katrin Fischer <[hidden email]> ---
This works as described but doesn't cover one use case: A library that doens't
want to allow OPAC initiated requests. Something to think about later maybe?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #15 from Katrin Fischer <[hidden email]> ---
On second thought - Andrew, can we have some unit tests for testing the new
behaviour of the method please?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

--- Comment #16 from Andrew Isherwood <[hidden email]> ---
(In reply to Katrin Fischer from comment #14)
> This works as described but doesn't cover one use case: A library that
> doens't want to allow OPAC initiated requests. Something to think about
> later maybe?

Yes, indeed. Having ILL enabled only for the staff interface is definitely
outside the scope of this bug I think.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

--- Comment #17 from Andrew Isherwood <[hidden email]> ---
(In reply to Katrin Fischer from comment #14)
> This works as described but doesn't cover one use case: A library that
> doens't want to allow OPAC initiated requests. Something to think about
> later maybe?

I have now added Bug 22305 to record this

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20639] Allow setting a default/single backend for OPAC driven requests

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

--- Comment #18 from Andrew Isherwood <[hidden email]> ---
(In reply to Katrin Fischer from comment #15)
> On second thought - Andrew, can we have some unit tests for testing the new
> behaviour of the method please?

Hi Katrin - The method in question "available_backends" has never had tests due
to it needing at least one backend installing in the filesystem in order to
run, it looks at the directory specified in the config and enumerates the
backends it finds.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12